Re: Review Request 110264: Change uses of QCoreApplication::translate() with no context to tr() in tier1 frameworks.

viewboard.kde.org/r/110264/#review31987 ------- On May 4, 2013, 6:27 p.m., George Goldberg wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 110264: Change uses of QCoreApplication::translate() with no context to tr() in tier1 frameworks.

c/solid/backends/wmi/wmidevice.cpp 0e85ae9c31eaab8c863e86845733dff17453456a tier1/solid/src/solid/deviceinterface.cpp 0cfc8e84ddbcbf31b44e881055ae173a6c589fdb Diff: http://git.reviewboard.kde.org/r/110264/diff/ Testing --- Everything still compiles. Than

Re: Review Request 110264: Change uses of QCoreApplication::translate() with no context to tr() in tier1 frameworks.

0264/diff/ Testing --- Everything still compiles. Thanks, George Goldberg ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 110264: Fix QObject::tr use in solid.

ds/wmi/wmidevice.cpp 0e85ae9c31eaab8c863e86845733dff17453456a tier1/solid/src/solid/deviceinterface.cpp 0cfc8e84ddbcbf31b44e881055ae173a6c589fdb Diff: http://git.reviewboard.kde.org/r/110264/diff/ Testing --- Everything still compiles. Thanks, George Goldberg ___

Re: Review Request 110264: Fix QObject::tr use in solid.

c/solid/backends/wmi/wmidevice.cpp > 0e85ae9c31eaab8c863e86845733dff17453456a > tier1/solid/src/solid/deviceinterface.cpp > 0cfc8e84ddbcbf31b44e881055ae173a6c589fdb > > Diff: http://git.reviewboard.kde.org/r/110264/diff/ > > > Testing > --- > > Everything still compiles. > > > Thanks, > > George Goldberg > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 110264: Fix QObject::tr use in solid.

, George Goldberg ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 110264: Change uses of QCoreApplication::translate() with no context to QObject::tr() in tier1 frameworks.

-- Everything still compiles. Thanks, George Goldberg ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Use of tr/i18n/QApplication::translate in tier1/2 frameworks

There's a task in the kdelibs_cleanup epic that's been assigned to me for a few months, namely using the correct method call for translatable strings in tier1/2 frameworks where ki18n isn't available. Way back, I changed them all to QCoreApplication::translate with no context, which at the time wa

Review Request 110209: macro_add_file_dependencies -> set_property in tier2/kconfig

nks, George Goldberg ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request: do translation correctly in solid

/ Testing --- compiles Thanks, George Goldberg ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request: Make kcodecs framework build standalone

tier1/kcodecs/src/kcharsets.cpp c64aa12361583cd9184bc39495c7149e6b0d7796 tier1/kcodecs/src/kencodingprober.cpp 1dad3272986c2b0c693cd1bbf49fd40055300e39 Diff: http://git.reviewboard.kde.org/r/105860/diff/ Testing --- Works for me, both standalone and as part of kdelibs Thanks, George Gol

Re: Review Request: Make kcodecs framework build standalone

as part of kdelibs Thanks, George Goldberg ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: ECM and FindFoo.cmake files

On 5 August 2012 16:08, Alexander Neundorf wrote: > On Sunday 05 August 2012, George Goldberg wrote: > >> What is the policy on moving FindFoo.cmake files from frameworks to >> ECM or upstream. In particular, I have found the following ones still >> existing in the

Re: Review Request: Make kcodecs framework build standalone

Testing --- Works for me, both standalone and as part of kdelibs Thanks, George Goldberg ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

ECM and FindFoo.cmake files

Hi, What is the policy on moving FindFoo.cmake files from frameworks to ECM or upstream. In particular, I have found the following ones still existing in the various tier1 and tier2 migrated frameworks: kcoreaddons --FindFAM.cmake kidletime --FindX11.cmake --FindX11XCB.cmake --FindXCB.cmake soli

Re: Review Request: remove FindLibLZMA.cmake from karchive framework

sed and whenever we depend on it. - George --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105866/#review16896 --- On Aug. 5, 2012,