D29084: Make the HTML file template more useful

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:5adaa7cba102: Make the HTML file template more useful (authored by gszymaszek). REPOSITORY R241 KIO CHANGES SINCE L

D29084: Make the HTML file template more useful

gszymaszek requested review of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29084 To: gszymaszek, #frameworks, dfaure, ognarb Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29084: Make the HTML file template more useful

gszymaszek updated this revision to Diff 80859. gszymaszek added a comment. - Add common HTML elements to the HTML file template REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29084?vs=80853&id=80859 BRANCH html-file-template (branched from master) REVISION

D29084: Make the HTML file template more useful

gszymaszek updated this revision to Diff 80853. gszymaszek added a comment. - Remove stylesheets from the HTML file template REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29084?vs=80839&id=80853 BRANCH html-file-template (branched from master) REVISION DET

D29084: Make the HTML file template more useful

gszymaszek added a comment. In D29084#654484 , @ognarb wrote: > - Don't include `

D29084: Make the HTML file template more useful

gszymaszek created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. gszymaszek requested review of this revision. REVISION SUMMARY This commit removes the empty meta tag and adds the following: - a DOCTYPE declaration, - an html[lang] att

D24306: Highlight GeoJSON files as if they were plain JSON

This revision was automatically updated to reflect the committed changes. Closed by commit R216:25b08fe3f4c6: Highlight GeoJSON files as if they were plain JSON (authored by gszymaszek). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24306?vs=67059

D24306: Highlight GeoJSON files as if they were plain JSON

gszymaszek created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. gszymaszek requested review of this revision. REVISION SUMMARY Currently, GeoJSON files syntax isn’t highlighted in any way. GeoJSON is a subset of JSON and,

D18148: Use HTTPS, if available, in links visible to users

This revision was automatically updated to reflect the committed changes. Closed by commit R39:b64681408d84: Use HTTPS, if available, in links visible to users (authored by gszymaszek). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18148?vs=49138&id=49140

D18148: Use HTTPS, if available, in links visible to users

gszymaszek marked 2 inline comments as done. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18148 To: gszymaszek, #ktexteditor Cc: lueck, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D18148: Use HTTPS, if available, in links visible to users

gszymaszek updated this revision to Diff 49138. gszymaszek added a comment. Fixed two links to docs.kde.org REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18148?vs=49135&id=49138 BRANCH https-in-end-user-links (branched from master) REVISION DETAIL

D18148: Use HTTPS, if available, in links visible to users

gszymaszek retitled this revision from "Use HTTPS, if available, in links visible by users" to "Use HTTPS, if available, in links visible to users". gszymaszek added a reviewer: KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18148 To: gszymaszek, #ktext

D18148: Use HTTPS, if available, in links visible by users

gszymaszek created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. gszymaszek requested review of this revision. REPOSITORY R39 KTextEditor BRANCH https-in-end-user-links (branched from master) REVISION DETAIL https://ph

D7864: Basic support for PHP and Python fenced code blocks in Markdown

gszymaszek updated this revision to Diff 19631. gszymaszek added a comment. - Removed JavaScript code blocks in Markdown support since it didn’t work - Added test cases for new code blocks in Markdown REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.

D7864: Basic support for PHP and Python fenced code blocks in Markdown

gszymaszek added a subscriber: cfeck. gszymaszek added a comment. Not ready to land, but uploaded per @cfeck’s suggestion (bug 356974 ). REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7864 To: gszymaszek,

D7864: Basic support for PHP and Python fenced code blocks in Markdown

gszymaszek created this revision. gszymaszek added a reviewer: KTextEditor. Restricted Application added a project: Frameworks. REVISION SUMMARY This patch enables syntax highlighting of PHP and Python code blocks in Markdown code. REPOSITORY R216 Syntax Highlighting BRANCH markdown-code-

D5799: Rebase Less syntax highlighting on SCSS one

This revision was automatically updated to reflect the committed changes. Closed by commit R216:ca846fbda318: Rebased Less syntax highlighting on SCSS one (authored by gszymaszek). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5799?vs=18296&id=183

D5799: Rebase Less syntax highlighting on SCSS one

gszymaszek updated this revision to Diff 18296. gszymaszek added a comment. Removed leading and trailing spaces inside XML tags (in `less.xml`), to make it possible to build the framework. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5799?vs=

D5799: Rebase Less syntax highlighting on SCSS one

gszymaszek updated this revision to Diff 15814. gszymaszek added a comment. Added a test file (`autotests/input/highlight.less`). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5799?vs=14376&id=15814 REVISION DETAIL https://phabricator.kde.or

D5799: Rebase Less syntax highlighting on SCSS one

gszymaszek created this revision. gszymaszek added a project: Framework: Syntax Hightlighting. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY I’ve rebased Less syntax highlighting definitions on those from current SCSS

[Differential] [Commented On] D4537: EditorConfig support

gszymaszek added a comment. In https://phabricator.kde.org/D4537#87411, @cullmann wrote: > Do you have commit rights? If not, paste your mail address and full name and I can push your change with you as author. No, I don’t have. Grzegorz Szymaszek, `gszymas...@short

[Differential] [Updated, 256 lines] D4537: EditorConfig support

gszymaszek updated this revision to Diff 11486. gszymaszek marked 5 inline comments as done. gszymaszek added a comment. Updated to work with new `cmake/FindEditorConfig.cmake`. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4537?vs=11366&id=11486 REVIS

[Differential] [Updated, 259 lines] D4537: EditorConfig support

gszymaszek updated this revision to Diff 11366. gszymaszek added a comment. key and value are const. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4537?vs=11365&id=11366 REVISION DETAIL https://phabricator.kde.org/D4537 AFFECTED FILES CMakeLists.t

[Differential] [Updated, 259 lines] D4537: EditorConfig support

gszymaszek updated this revision to Diff 11365. gszymaszek marked 2 inline comments as done. gszymaszek added a comment. Pulled check-variable-functions out of EditorConfig class, moved some variable definitions into main loop of parser. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

[Differential] [Updated, 254 lines] D4537: EditorConfig support

gszymaszek updated this revision to Diff 11349. gszymaszek added a comment. Simplified the constructor and reduced parser indentation. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4537?vs=11279&id=11349 REVISION DETAIL https://phabricator.kde.org/D4

[Differential] [Commented On] D4537: EditorConfig support

gszymaszek added a comment. Yes, it was good when actual parsing was delegated to a separate function, but we’ve decided to merge all parsing-related functions. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4537 EMAIL PREFERENCES https://phabricator.kde.org/s

[Differential] [Commented On] D4537: EditorConfig support

gszymaszek added a comment. In https://phabricator.kde.org/D4537#86356, @cullmann wrote: > On the other side, I see no real copyrightable material beside you are using the editor config API. As I’ve written, I used Builder’s source to //learn// that (1) I have to call `editorconf

[Differential] [Commented On] D4589: EditorConfig module

gszymaszek added a comment. `FindLibGit2.cmake` and other files include such fragment: if(LIBGIT2_FOUND AND NOT TARGET LibGit2::LibGit2) add_library(LibGit2::LibGit2 UNKNOWN IMPORTED) set_target_properties(LibGit2::LibGit2 PROPERTIES IMPORTED_LOCATION "${LIBGI

[Differential] [Updated, 88 lines] D4589: EditorConfig module

gszymaszek updated this revision to Diff 11329. gszymaszek added a comment. Added description. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4589?vs=11308&id=11329 REVISION DETAIL https://phabricator.kde.org/D4589 AFFECTED FILES find-modu

[Differential] [Updated, 67 lines] D4589: EditorConfig module

gszymaszek updated this revision to Diff 11308. gszymaszek added a comment. Added version checking support. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4589?vs=11263&id=11308 REVISION DETAIL https://phabricator.kde.org/D4589 AFFECTED FILE

[Differential] [Commented On] D4589: EditorConfig module

gszymaszek added a comment. editorconfig-core-lua doesn’t check C library version (CMakeLists.txt:49 ). Actually I’m not sure if setting oldest accept

[Differential] [Commented On] D4589: EditorConfig module

gszymaszek added a comment. It seems there isn’t any version string in library headers (editorconfig.h, editorconfig_handle.h), is there any other cross-distribution way to obtain library version? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D4589 EMA

[Differential] [Updated, 253 lines] D4537: EditorConfig support

gszymaszek updated this revision to Diff 11279. gszymaszek added a comment. Fixed src/CMakeLists.txt to make EditorConfig support truly optional, removed interpret and interpretLine functions (so parsing is back in parse), simplified EditorConfig class constructor, fixed memory leak in Docume

[Differential] [Updated] D4537: EditorConfig support

gszymaszek marked 6 inline comments as done. gszymaszek added inline comments. INLINE COMMENTS > dhaumann wrote in editorconfig.cpp:23 > Better is to write: > > EditorConfig::EditorConfig(KTextEditor::DocumentPrivate *document) > : m_document(document) > , m_handle(0) > { >

[Differential] [Commented On] D4537: EditorConfig support

gszymaszek added a comment. In https://phabricator.kde.org/D4537#85846, @dhaumann wrote: > Btw, did you copy some code from another project? If so, we need to be careful, since KTextEditor is LGPLv+2. I’ve used mentioned gnome-builder’s file

[Differential] [Request, 41 lines] D4589: EditorConfig module

gszymaszek created this revision. gszymaszek added reviewers: Build System, Frameworks. gszymaszek set the repository for this revision to R240 Extra CMake Modules. gszymaszek added a project: Frameworks. Restricted Application added a project: Build System. REVISION SUMMARY EditorConfig support

[Differential] [Updated, 265 lines] D4537: EditorConfig support

gszymaszek updated this revision to Diff 11262. gszymaszek added a comment. Moved EditorConfig-related logic into a separate class and made it optional (no longer a KTextEditor dependency). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4537?vs=11133&id

[Differential] [Commented On] D4537: EditorConfig support

gszymaszek added a comment. In the new `EditorConfig` class I need to use `DocumentPrivate`’s `checkBoolValue` and `checkIntValue` methods, but they’re declared private. I think it should be OK to make them public as they’re static anyway, but I’d like to hear what’s your opinion. Setting `E

[Differential] [Commented On] D4537: EditorConfig support

gszymaszek added a comment. Thanks for your comments. I’ve managed to make editorconfig optional using the mentioned `FindEditorConfig.cmake` module (I had to change its name to `Findeditorconfig.cmake`). Should I create a new diff in ECM repository to add this file? Now I’m going to creat

[Differential] [Request, 109 lines] D4537: EditorConfig support

gszymaszek created this revision. gszymaszek added a reviewer: KTextEditor. gszymaszek set the repository for this revision to R39 KTextEditor. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY This diff enabl

[Differential] [Request, 2 lines] D4300: Simpler calculation of longest line limit

gszymaszek created this revision. gszymaszek added a reviewer: KTextEditor. gszymaszek set the repository for this revision to R39 KTextEditor. gszymaszek added a project: KTextEditor. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Framew

[Differential] [Request, 4 lines] D4296: Fixed single line comments in Less starting new regions

gszymaszek created this revision. gszymaszek added a reviewer: Framework: Syntax Hightlighting. gszymaszek set the repository for this revision to R216 Syntax Highlighting. gszymaszek added a project: Framework: Syntax Hightlighting. Restricted Application added a project: Frameworks. Restricted Ap