shumski added inline comments.
INLINE COMMENTS
> config-kcrash.h.cmake:7
> +
> +#cmakedefine KCRASH_PLUGIN_INSTALL_DIR "${KCRASH_PLUGIN_INSTALL_DIR}"
CMAKE_INSTALL_FULL_PLUGINDIR/kcrashhandlers
REPOSITORY
R285 KCrash
REVISION DETAIL
https://phabricator.kde.org/D4201
EMAIL PREFERENCES
ht
shumski added inline comments.
INLINE COMMENTS
> kossebau wrote in KDEInstallDirs.cmake:534
> Fear I am still missing what you mean. So let's go explicitely, here is what
> I understand to happen:
>
> There are six different cases when using this macro and on the first
> invocation of cmake, f
shumski added inline comments.
INLINE COMMENTS
> kossebau wrote in KDEInstallDirs.cmake:534
> But isn't this free recognition happening via KDE_INSTALL_USE_QT_SYS_PATHS as
> well?
> At least this is how I understand
> https://cgit.kde.org/extra-cmake-modules.git/tree/kde-modules/KDEInstallDirs.
shumski added inline comments.
INLINE COMMENTS
> kossebau wrote in KDEInstallDirs.cmake:534
> But that is the same for the current QTPLUGINDIR, QTQUICKIMPORTSDIR, &
> QMLDIR, no? They also only get set to the Qt system paths if
> KDE_INSTALL_USE_QT_SYS_PATHS=ON, otherwise get set to something b
shumski added inline comments.
INLINE COMMENTS
> kossebau wrote in KDEInstallDirs.cmake:534
> Not sure what you mean, please point out the issue you see here with more
> details :)
>
> The plan here is:
> if KDE_INSTALL_USE_QT_SYS_PATHS is set, install QCH files to QT_INSTALL_DOCS,
> if not, s
shumski added inline comments.
INLINE COMMENTS
> KDEInstallDirs.cmake:534
> +else()
> +_define_relative(QTQCHDIR DATAROOTDIR "doc/QCH"
> +"documentation bundles in QCH format for Qt-extending libraries")
I think e.g. QMLDIR, PLUGINDIR, ECM_MKSPECS_INSTALL_DIR, etc. are vanilla Qt's.
shumski added inline comments.
INLINE COMMENTS
> kossebau wrote in CMakeLists.txt:82
> Imagine another project with a lib MyLib linking against KJobWidgets (in the
> public interface). For MyLib also a QCH file should be created. To create
> proper links from the QCH file for MyLib into the QCH
shumski added a comment.
> a) recommended install path for qch and tag files?
At least when KDE_INSTALL_USE_QT_SYS_PATHS is TRUE, one could use
QT_INSTALL_DOCS (via ECMQueryQmake) var.
REVISION DETAIL
https://phabricator.kde.org/D2854
EMAIL PREFERENCES
https://phabricator.kde.org/s
shumski added inline comments.
INLINE COMMENTS
> CMakeLists.txt:82
>
> +ecm_install_qch_export(
> +TARGETS KF5JobWidgets_QCH
I wonder about the reasoning behind the existence of this export, and
installation of it...
> CMakeLists.txt:98
> +TAGFILE_INSTALL_DESTINATION ${KDE_INSTALL_FU
> On Oct. 25, 2016, 1:31 p.m., Hrvoje Senjan wrote:
> > find-modules/FindQt5PlatformSupport.cmake, line 75
> > <https://git.reviewboard.kde.org/r/129260/diff/1/?file=482953#file482953line75>
> >
> > Shouldn't this be rather Qt5Pla
> On Oct. 25, 2016, 1:31 p.m., Hrvoje Senjan wrote:
> > find-modules/FindQt5PlatformSupport.cmake, line 75
> > <https://git.reviewboard.kde.org/r/129260/diff/1/?file=482953#file482953line75>
> >
> > Shouldn't this be rather Qt5Pla
> On Oct. 25, 2016, 1:37 p.m., Aleix Pol Gonzalez wrote:
> > Shouldn't this be in Qt? What am I missing?
>
> Martin Gräßlin wrote:
> Yes it should, but it isn't. No idea why not.
The module is internal, so it intentionally doesn't install any cmake files.
- Hrvoje
--
tps://git.reviewboard.kde.org/r/129260/#comment67323>
Shouldn't this be rather Qt5PlatformSupport_PRIVATE_INCLUDE_DIRS, and
${PKG_Qt5PlatformSupport_INCLUDEDIR}/QtPlatformSupport/ be marked as
Qt5PlatformSupport_INCLUDE_DIR?
- Hrvoje Senjan
On Oct. 25, 2016, 1:21 p.m., Kai Uwe Br
)
<https://git.reviewboard.kde.org/r/128763/#comment67000>
This is added in Qt 5.6, but:
set (REQUIRED_QT_VERSION "5.3.0")
which is also wrong.
- Hrvoje Senjan
On Sept. 3, 2016, 10:33 a.m., David Edmundson wrote:
>
>
tps://git.reviewboard.kde.org/r/127169/#comment65096>
FWIW, this defacto makes Qt5Core required for anyone that doesn't
explicitly disables KDE_INSTALL_USE_QT_SYS_PATHS.
E.g. labplot uses ECM and Qt4.
- Hrvoje Senjan
On April 7, 2016, 1:08 a.m., Aleix Pol Gon
proof for both
relative and absolute PLUGIN_INSTALL_DIR
- Hrvoje Senjan
On Tra. 7, 2016, 9:55 ujutro, Martin Gräßlin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
, so doc subdir is now
never added.
- Hrvoje Senjan
On Feb. 25, 2016, 1:34 a.m., Aleix Pol Gonzalez wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
that it requires a higher version as I'm running
> Debian and just use what's available. As I don't want the change to be
> disruptive for devs I think not increasing the build-dep is better.
>
> Hrvoje Senjan wrote:
> IMO, rasing te dep is better, as
tomatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126723/
> ---
>
> (Updated Jan. 12, 2016, 10:09 a.m.)
>
>
> Review request for KDE Frameworks, David Edmundson, Hrvoje Senjan, and
> Matthias Klumpp.
>
>
> Repository: polkit-qt-1
> On Dec. 21, 2015, 5:33 p.m., Hrvoje Senjan wrote:
> > A public header here (DownloadWidget) includes QWidget
>
> Kevin Funk wrote:
> Qt5::Widgets is still in PUBLIC scope
Oops, i could swear i've seen it moved into PRIVATE sect
- Hrvoje Senjan
On Dec. 21, 2015, 5:06 p.m., Kevin Funk wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
panel would be
shown). this patch fixes the problem here.
- Hrvoje Senjan
On Dec. 11, 2015, 7:48 p.m., Martin Klapetek wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
her
don't assume this ;-) at least send a mail to kde-distro-packagers about the
sideeffects if those 3 are pushed asynchronously
- Hrvoje Senjan
On Nov. 16, 2015, 6:06 p.m., Boudhayan Gupta wrote:
>
> ---
> This is an automati
c/kio/kfilemetadatawidget.cpp 1edb069
src/kio/kfilemetainfo.cpp eae1295
src/kio/kfilemetainfoitem.cpp 62f760d
src/kio/kfilemetainfoitem_p.h 8929e46
src/kio/knfotranslator.cpp 8eec6a1
Diff: https://git.reviewboard.kde.org/r/120393/diff/
Testing
---
Thanks,
Hrvoje S
> On Oct. 3, 2015, 10:08 a.m., David Faure wrote:
> > I just realized another problem with this approach: since the latest
> > libkonq release installs konqpopupmenuplugin.desktop already, this patch
> > will make the next KIO release conflict with that last libkonq release
> > (which by defin
uming every distro renames
the file)
- Hrvoje Senjan
On Sept. 17, 2015, 11:32 a.m., Harald Sitter wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit f1731c26fd27d8eafcf487bd5fae181beefcc904 by Hrvoje Senjan
to branch master.
Repository: baloo
Description
---
1) Be explicit about which modules are required
2) Find dependancies as the rest
.
Thanks,
Hrvoje Senjan
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
-
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123031/#review81472
-------
On May 26, 2015, 10:04 p.m., Hrvoje Senjan wrote:
>
>
marked as submitted.
Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
Changes
---
Submitted with commit 093c96c87b3267ed16dce6faae98df139e1c1407 by Hrvoje Senjan
to branch master.
Repository: khtml
Description
---
Only search for public deps in cmake config
tps://git.reviewboard.kde.org/r/124220/#comment56613>
After updating to latest master, i wonder do we need this debug enabled by
default? :D
- Hrvoje Senjan
On July 7, 2015, 1:31 p.m., Martin Gräßlin wrote:
>
> ---
> This is an automatically g
ot declared in this scope
[ 55s] return d->window;
[ 55s] ^
```
- Hrvoje Senjan
On Srp. 7, 2015, 1:31 popodne, Martin Gräßlin wrote:
>
> ---
> This is an automatically
tps://git.reviewboard.kde.org/r/124186/#comment56093>
I can't say what's more correct, as this would be a precedent for
installing private headers, maybe maybe going Qt way would be more consistent?
($module/$version/$module)
- Hrvoje Senjan
On June 26, 2015, 1:51 p.m., Mart
marked as submitted.
Review request for KDE Frameworks, Aleix Pol Gonzalez and Daniel Vrátil.
Changes
---
Submitted with commit add32bbfc92b89ad5e77c99427f22743589c6c5d by Hrvoje Senjan
to branch master.
Repository: kauth
Description
---
Not only those that use
forwarding headers? They
are still installed
- Hrvoje Senjan
On March 18, 2015, 7:24 p.m., Hrvoje Senjan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
Senjan
On March 18, 2015, 7:30 p.m., Hrvoje Senjan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
-
KF5KrossConfig.cmake.in e89cee2
Diff: https://git.reviewboard.kde.org/r/123031/diff/
Testing
---
Thanks,
Hrvoje Senjan
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123030/#review80864
---
ping
- Hrvoje Senjan
On April 16, 2015, 4:06 p.m., Hrvoje
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123438/#review80863
---
ping
- Hrvoje Senjan
On April 20, 2015, 3:07 p.m., Hrvoje
> On May 15, 2015, 8:08 p.m., Hrvoje Senjan wrote:
> > src/platformtheme/kdeplatformfiledialoghelper.cpp, line 300
> > <https://git.reviewboard.kde.org/r/123335/diff/1-2/?file=360850#file360850line300>
> >
> > This somehow breaks dialogs from
the problem here
- Hrvoje Senjan
On April 17, 2015, 10 a.m., David Rosca wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.
marked as submitted.
Review request for KDE Frameworks and Aleix Pol Gonzalez.
Changes
---
Submitted with commit 38b0eeec41de0e916dd834b849f7ddcfa06bdafc by Hrvoje Senjan
to branch master.
Repository: kauth
Description
---
Let cmake know ALL is not the name in this custom command
clude)
```
Also make org.kde.powerdevil.backlighthelper.policy now works.
Thanks,
Hrvoje Senjan
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
f a distro would release with $someotherproductversion-1, and update KF5
monthly they would get nice reports about broken desktops - and in principle
all non-rolling distros won't deliver new feature releases for desktop and
applications.
- Hrvoje Senjan
On May 6, 2015, 7:21 p.m
x27;t been found via
KPluginLoader?
- Hrvoje Senjan
On April 29, 2015, 1:16 a.m., Aleix Pol Gonzalez wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard
revert this one,
or still provide fallback for kservice plugins...
I know KF5 guarantees binary and source compatibility, not explicitly runtime,
but this will upset users and distros if they'll have broken contacts for 2
months until 15.08 get out...
- Hrvoje Senjan
On April 20, 2015,
, for org.kde.fontinst.service in plasma-desktop we get e.g.
Exec=/fontinst, as KAUTH_HELPER_INSTALL_ABSOLUTE_DIR is empty. This means that
Plasma 5.2.95 has a broken fontinst service.
Thanks,
Hrvoje Senjan
___
Kde-frameworks-devel mailing list
Kde
ublic API.
- Hrvoje
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123421/#review79182
---
On April 19, 2015, 3:24 a.m.
marked as submitted.
Review request for KDE Frameworks, Gregor Mi and Jeremy Whiting.
Changes
---
Submitted with commit 31d27cb16d370774af3ef291117d161619b30c48 by Hrvoje Senjan
to branch master.
Repository: knewstuff
Description
---
Like it's done with the rest of the frame
hanks,
Hrvoje Senjan
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
marked as submitted.
Review request for KDE Frameworks, David Faure and Jan Grulich.
Changes
---
Submitted with commit 13c90ad8e83dc24e8c4e88d2f152ae692b6bdc34 by Hrvoje Senjan
to branch master.
Repository: networkmanager-qt
Description
---
The headers include , which is now in
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123401/#review79137
-------
On April 17, 2015, 5:53 p.m., Hrvoje Senjan wrote:
>
> ---
/diff/
Testing (updated)
---
Plasma-nm no longer fails due to original problem, but incorect usage of nm-qt
includes:
vpnuiplugin.h:31:43: fatal error: NetworkManagerQt/generictypes.h: No such file
or directory
Thanks,
Hrvoje Senjan
___
Kde
/wirelessnetwork.h 1d5cb7b
Diff: https://git.reviewboard.kde.org/r/123401/diff/
Testing
---
Thanks,
Hrvoje Senjan
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
> On April 17, 2015, 5:24 p.m., Hrvoje Senjan wrote:
> > This breaks the build of plasma-workspace
> > ```
> > [ 413s] In file included from
> > /usr/include/KF5/NetworkManagerQt/NetworkManagerQt/Manager:1:0,
> > [ 413s] from
> > /home
,
Hrvoje Senjan
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/manager.h:26:37:
fatal error: networkmanagerqt_export.h: No such file or directory
[ 413s] #include
[ 413s] ^
```
The headers include , which is now in lowercase
directory, and is not in public INTERFACE includes...
- Hrvoje Senjan
On April 17, 2015, 2:10
/CMakeLists.txt c6f5fab
Diff: https://git.reviewboard.kde.org/r/123030/diff/
Testing
---
Thanks,
Hrvoje Senjan
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
> On March 19, 2015, 12:23 a.m., Vishesh Handa wrote:
> > I'm all for getting rid of the Nepomuk code. However, I'm not too sure
> > about the strigi part. That should still work.
>
> Hrvoje Senjan wrote:
> It does not ;-)
> Originally, this revi
: I9025505d57fe82438dea8c0270f962bf9fed36cf
Gerrit-PatchSet: 1
Gerrit-Project: kio
Gerrit-Branch: master
Gerrit-Owner: Hrvoje Senjan
Gerrit-Reviewer: Aleix Pol Gonzalez
Gerrit-Reviewer: David Faure
Gerrit-Reviewer: Michael Palimaka
Gerrit-Reviewer: Patrick S
org/r/120393/#review77714
---
On March 18, 2015, 7:24 p.m., Hrvoje Senjan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> htt
marked as submitted.
Review request for KDE Frameworks and David Faure.
Changes
---
Submitted with commit acf078d84d8f1c4d5fcf28cf9a9f570760ba1501 by Hrvoje Senjan
to branch master.
Repository: kpty
Description
---
Equivalent to https://svn.reviewboard.kde.org/r/2468/
It was lost
> On March 18, 2015, 8:40 p.m., Christophe Giboudeaux wrote:
> > KF5KrossConfig.cmake.in, line 9
> > <https://git.reviewboard.kde.org/r/123031/diff/1/?file=355503#file355503line9>
> >
> > Are you sure ?
> >
> > ./ui/actioncollectio
marked as submitted.
Review request for KDE Frameworks and David Faure.
Changes
---
Submitted with commit 14ec99b72ec8f71f0b3bf3486808370dea3b8be9 by Hrvoje Senjan
to branch master.
Repository: kbookmarks
Description
---
this adds KWidetsAddons to public linker flags, but also
marked as submitted.
Review request for KDE Frameworks and Marco Martin.
Changes
---
Submitted with commit ca1e2377fbf98f2bb5567c6984d55e0fefb34bc0 by Hrvoje Senjan
to branch master.
Repository: plasma-framework
Description
---
It's a public dep, so make sure it's pulle
marked as submitted.
Review request for KDE Frameworks and Marco Martin.
Changes
---
Submitted with commit b7a966a737b11278128d86f6d384d7aee96699d1 by Hrvoje Senjan
to branch master.
Repository: kpackage
Description
---
They are (only) public dep, so make sure they are pulled in
:
https://git.reviewboard.kde.org/r/123031/#review77700
-------
On March 18, 2015, 9:13 p.m., Hrvoje Senjan wrote:
>
> ---
> This is an automatically generated e-m
.
Changes
---
search Qt5Widgets also
Repository: kross
Description
---
Only search for public deps in cmake config
Diffs (updated)
-
KF5KrossConfig.cmake.in e89cee2
Diff: https://git.reviewboard.kde.org/r/123031/diff/
Testing
---
Thanks,
Hrvoje Senjan
make.in 05ae340
Diff: https://git.reviewboard.kde.org/r/123032/diff/
Testing
---
Thanks,
Hrvoje Senjan
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
src/kio/kfilemetadatawidget.cpp 1edb069
src/kio/kfilemetainfo.cpp eae1295
src/kio/kfilemetainfoitem.cpp 62f760d
src/kio/kfilemetainfoitem_p.h 8929e46
src/kio/knfotranslator.cpp 8eec6a1
Diff: https://git.reviewboard.kde.org/r/120393/diff/
Testing
---
Thanks,
Hrvoje S
org/r/120393/diff/
Testing (updated)
---
Thanks,
Hrvoje Senjan
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122828/#review77693
---
ping
- Hrvoje Senjan
On March 5, 2015, 8:41 p.m., Hrvoje
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122313/#review77694
---
ping
- Hrvoje Senjan
On Jan. 29, 2015, 7:54 p.m., Hrvoje
: kpeople
Description
---
Both KF5::PeopleBackend and KF5::PeopleWidgets need Qt5Widgets publicly, so
search them.
Diffs
-
KF5PeopleConfig.cmake.in 05ae340
Diff: https://git.reviewboard.kde.org/r/123032/diff/
Testing
---
Thanks,
Hrvoje Senjan
Description
---
They are (only) public dep, so make sure they are pulled in for KPackage
consumers
Diffs
-
KF5PackageConfig.cmake.in 469f7a7
Diff: https://git.reviewboard.kde.org/r/123033/diff/
Testing
---
Thanks,
Hrvoje Senjan
---
Only search for public deps in cmake config
Diffs
-
KF5KrossConfig.cmake.in e89cee2
Diff: https://git.reviewboard.kde.org/r/123031/diff/
Testing
---
Thanks,
Hrvoje Senjan
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel
.
Repository: khtml
Description
---
Only search for public deps in cmake config
Diffs
-
KF5KHtmlConfig.cmake.in 74e822c
Diff: https://git.reviewboard.kde.org/r/123030/diff/
Testing
---
Thanks,
Hrvoje Senjan
___
Kde-frameworks
-framework
Description
---
It's a public dep, so make sure it's pulled in for p-f consumers
Diffs
-
KF5PlasmaConfig.cmake.in 48fceb3
Diff: https://git.reviewboard.kde.org/r/123034/diff/
Testing
---
Thanks,
Hrvoje Senjan
_
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit 2f47d9308a952f765c2752728733c9404e77bd47 by Hrvoje Senjan
to branch master.
Repository: kemoticons
Description
---
KF5Archive isn't public dep, no need to find it as such
marked as submitted.
Review request for KDE Frameworks and David Faure.
Changes
---
Submitted with commit af6342fe8a938558ed6a04f8f644e44ea5a5a935 by Hrvoje Senjan
to branch master.
Repository: kparts
Description
---
KF5Notifications isn't public dep, no need to find it as
marked as submitted.
Review request for KDE Frameworks and David Faure.
Changes
---
Submitted with commit b954ffc2fe52f787cf77dc6c720d4f79cf8c5ba8 by Hrvoje Senjan
to branch master.
Repository: kservice
Description
---
KF5DBusAddons and KF5I18n are private deps, don't searc
marked as submitted.
Review request for KDE Frameworks and Laurent Montel.
Changes
---
Submitted with commit 1669fdbe670da1be935052f5d27aee7cfa12a735 by Hrvoje Senjan
to branch master.
Repository: ktextwidgets
Description
---
KF5Completion, KF5ConfigWidgets, KF5IconThemes
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit 842cf9872c9db0c1618b919feeec8f04d657c4f9 by Hrvoje Senjan
to branch master.
Repository: kxmlgui
Description
---
KF5GlobalAccel, KF5IconThemes, KF5ItemViews, KF5TextWidgets, KF5WindowSystem
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit 316cb50dd9b778e3edda253897d5ff288a958909 by Hrvoje Senjan
to branch master.
Repository: kded
Description
---
There's no shlib, only location of DBus interface is exposed there. So no nee
marked as submitted.
Review request for KDE Frameworks and Valentin Rusu.
Changes
---
Submitted with commit 6259a4c9bf71d451784e65909460aecf794b31e6 by Hrvoje Senjan
to branch master.
Repository: kwallet
Description
---
(only) QtGui is used publicly, so make the buildsystem also
marked as submitted.
Review request for KDE Frameworks and Christoph Feck.
Changes
---
Submitted with commit dc49bca7426f2ad9518364900407ee06a2e096cb by Hrvoje Senjan
to branch master.
Repository: kiconthemes
Description
---
Only Qt5::Widgets are public, so let the config searches
marked as submitted.
Review request for KDE Frameworks and David Edmundson.
Changes
---
Submitted with commit 7f6306cc303bbca636d4c8f1e035d377fdaa419b by Hrvoje Senjan
to branch master.
Repository: knotifyconfig
Description
---
KF5KIO and KF5I18n are private deps, don't searc
marked as submitted.
Review request for KDE Frameworks and Martin Klapetek.
Changes
---
Submitted with commit 20fb23c58d5b94e652c476372d1d8f61bf48f0fc by Hrvoje Senjan
to branch master.
Repository: knotifications
Description
---
KF5WindowSystem isn't public dep, no need to fi
marked as submitted.
Review request for KDE Frameworks and Jeremy Whiting.
Changes
---
Submitted with commit 2db4df1d650951bd46fb6bafe38d3ddc741c425e by Hrvoje Senjan
to branch master.
Repository: knewstuff
Description
---
KF5Archive and KF5KIO are private deps, don't searc
ependencies are
> > there, but their headers are missing or something?
>
> Hrvoje Senjan wrote:
> if i want to implement something with knewstuff, in principle i shouldn't
> need karchive and kio headers, etc. - unless i want also access to their API,
> but
ependencies are
> > there, but their headers are missing or something?
>
> Hrvoje Senjan wrote:
> if i want to implement something with knewstuff, in principle i shouldn't
> need karchive and kio headers, etc. - unless i want also access to their API,
> but
---
KF5GlobalAccel, KF5IconThemes, KF5ItemViews, KF5TextWidgets, KF5WindowSystem
and KF5Attica are all private deps, don't search for them in config
Diffs
-
KF5XmlGuiConfig.cmake.in cb0e66f
Diff: https://git.reviewboard.kde.org/r/122960/diff/
Testing
---
Thanks,
Hrvoje S
//git.reviewboard.kde.org/r/122953/#review77472
-------
On March 14, 2015, 8:06 p.m., Hrvoje Senjan wrote:
>
> ---
> This is an automatically generated e-mail. To
/
Testing
---
builds
Thanks,
Hrvoje Senjan
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
hanks,
Hrvoje Senjan
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
: kiconthemes
Description
---
Only Qt5::Widgets are public, so let the config searches only them
Diffs
-
KF5IconThemesConfig.cmake.in 2eab79c
Diff: https://git.reviewboard.kde.org/r/122952/diff/
Testing
---
Thanks,
Hrvoje Senjan
___
Kde
Description
---
KF5Notifications isn't public dep, no need to find it as such
Diffs
-
KF5PartsConfig.cmake.in d501254
Diff: https://git.reviewboard.kde.org/r/122956/diff/
Testing
---
Thanks,
Hrvoje Senjan
___
Kde-frameworks-
: knotifications
Description
---
KF5WindowSystem isn't public dep, no need to find it as such
Diffs
-
KF5NotificationsConfig.cmake.in 0466797
Diff: https://git.reviewboard.kde.org/r/122954/diff/
Testing
---
Thanks,
Hrvoje S
Description
---
KF5DBusAddons and KF5I18n are private deps, don't search for them in config
Diffs
-
KF5ServiceConfig.cmake.in 969248e
Diff: https://git.reviewboard.kde.org/r/122957/diff/
Testing
---
Thanks,
Hrvoje Senjan
__
: knotifyconfig
Description
---
KF5KIO and KF5I18n are private deps, don't search for them in config
Diffs
-
KF5NotifyConfigConfig.cmake.in e44bd62
Diff: https://git.reviewboard.kde.org/r/122955/diff/
Testing
---
Thanks,
Hrvoje S
1 - 100 of 261 matches
Mail list logo
