D10719: Highlighting for OpenSCAD

julianstirling added a comment. Hi, This has been sitting idle for about 6 weeks. @dhaumann is everything OK with the current patch for integration Cheers Julian REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10719 To: julianstirling, dhaumann

D10719: Highlighting for OpenSCAD

julianstirling added a comment. `git diff HEAD^^ HEAD > ../PatchCombined.patch` has hopefully done the trick. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10719 To: julianstirling, dhaumann Cc: dhaumann, ngraham, #frameworks, michaelh

D10719: Highlighting for OpenSCAD

julianstirling updated this revision to Diff 28190. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10719?vs=27770=28190 REVISION DETAIL https://phabricator.kde.org/D10719 AFFECTED FILES autotests/input/highlight.scad

D10719: Highlighting for OpenSCAD

julianstirling added a comment. `git format-patch HEAD^^` creates two separate patch files... REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10719 To: julianstirling, dhaumann Cc: dhaumann, ngraham, #frameworks, michaelh

D10719: Highlighting for OpenSCAD

julianstirling added a comment. Oh, I was following the guide here https://community.kde.org/Infrastructure/Github_Mirror So everything I uploaded was a git format-patch, which makes a patch file for each commit I made. I shall look into arc when I get a chance. REPOSITORY R216 Syntax

D10719: Highlighting for OpenSCAD

julianstirling planned changes to this revision. julianstirling added a comment. I am confused. If I look in the commit history of this revision there are two diffs, the first commit, and then the subsequent commit. Can phabricator not handle both of them sequentially? REPOSITORY R216

D10719: Highlighting for OpenSCAD

julianstirling updated this revision to Diff 27770. julianstirling added a comment. Added the test file as requested and updated the license to MIT. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10719?vs=27698=27770 REVISION DETAIL

D10719: Highlighting for OpenSCAD

julianstirling created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. julianstirling requested review of this revision. REVISION SUMMARY Added XML file to highlight OpenSCAD .scad files. REPOSITORY R216 Syntax