SGOrava abandoned this revision.
SGOrava added a comment.
Done in https://phabricator.kde.org/D26815
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D26793
To: SGOrava, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
SGOrava added a reviewer: Frameworks.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D26793
To: SGOrava, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
SGOrava created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
SGOrava requested review of this revision.
REVISION SUMMARY
Fix python binding compilation error.
- Add *.pyc files to .gitignore
REPOSITORY
R237 KConfig
BRANCH
pyqt5-ks
SGOrava added a comment.
it would, but I am not such great guru.
I tried few ways to change the behaviour but it was even worse,
and since this is used in many programs I do not want to break them.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D26755
To:
SGOrava added a comment.
This is the test I used to check the validity of my change, it kind of always
fails.
I only hope someone can fix this widget at least for KF6.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D26755
To: SGOrava, #frameworks
Cc: anthon
SGOrava updated this revision to Diff 73872.
SGOrava added a comment.
- KMessageWidget: Add resize autotest
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26755?vs=73845&id=73872
BRANCH
more-proper-height (branched from master)
REVISION DETAIL
SGOrava added a comment.
It looks good.
But I wrote a test as you suggested which still fails.
The test creates parent widget and puts the kmesagewidget and qlistwidget in
it in vertical order (as in my test app)
and than it resizes the parent widget and compares the height (the availabl
SGOrava retitled this revision from "KMessageWidget: Set widget height on
resize event" to "[WIP] KMessageWidget: Set widget height on resize event".
REPOSITORY
R236 KWidgetsAddons
BRANCH
more-proper-height (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D26755
To: SGO
SGOrava added a comment.
No, my tests say no.
This does not update sizeHint which can cause some issue later.
It sure looks nice in my test app but it is wrong in the core.
This is not the right solution.
REPOSITORY
R236 KWidgetsAddons
BRANCH
more-proper-height (branched from master
SGOrava added a comment.
OK, I will try to write a test for it.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D26755
To: SGOrava, #frameworks
Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
SGOrava edited the summary of this revision.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D26755
To: SGOrava, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
SGOrava created this revision.
SGOrava added a reviewer: Frameworks.
Herald added a project: Frameworks.
SGOrava requested review of this revision.
REVISION SUMMARY
When the resize event was triggered only the content
was resized and the widget itself was kept with same
height. This results
12 matches
Mail list logo