D22569: [Dialog] Apply window type after changing flags

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Changing flags might override the window type, ensure we set it back properly TEST PL

D22523: Remove visibilityChanged connection in favor of existing eventFilter

This revision was automatically updated to reflect the committed changes. Closed by commit R263:d4af86d8d56d: Remove visibilityChanged connection in favor of existing eventFilter (authored by broulik). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22523?vs=61

D13867: [KMessageWidget] Pass widget to standardIcon()

broulik updated this revision to Diff 61989. broulik added a comment. - Pass `QStyleOption` REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13867?vs=37101&id=61989 REVISION DETAIL https://phabricator.kde.org/D13867 AFFECTED FILES src/kmessagewid

D22531: [KColorSchemeManager] Optimize preview generation

broulik created this revision. broulik added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Create them only on-demand (e.g. when the menu opens or the DecorationRole is que

D22528: KIO FTP: File copy hangs when copying to existing file

broulik added a reviewer: sitter. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22528 To: ZaWertun, sitter Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22523: Remove visibilityChanged connection in favor of existing eventFilter

broulik created this revision. broulik added reviewers: Frameworks, dfaure, aacid. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY KMainWindow compresses saving its configuration by a 500ms timer. Ho

D22521: Fix a mistake with "Pb"

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R292 KUnitConversion BRANCH Pb_fix (branched from master) REVISION DETAIL https://phabricator.kde.org/D22521 To: ppeter, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, sbergeron, michael

D22520: Remove Growl support

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. (Once the replacement backends are actually in) INLINE COMMENTS > notifybypopupgrowl.cpp:27 > -#define GROWL_LOCATION_MACOSX > "/Library/PreferencePanes/Growl.prefPane/Contents/MacOS/Gro

D22365: KNotification macOS native support by NSNotificationCenter

broulik added a comment. Thanks a lot! INLINE COMMENTS > notifybymacosnotificationcenter.h:6 > + > +class MacOSNotificationCenterPrivate; > + Unused > notifybymacosnotificationcenter.h:14 > +NotifyByMacOSNotificationCenter(QObject* parent); > +~NotifyByMacOSNotificationCenter(); > +

D22365: KNotification macOS native support by NSNotificationCenter

broulik added a reviewer: rjvbb. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22365 To: Inoki, rjvbb Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22515: Add support for additional QML keywords not part of JavaScript

broulik added inline comments. INLINE COMMENTS > qml.xml:41 >Timer >QtObject >Item It's already there REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D22515 To: vkrause Cc: broulik, kwrite-devel, kde-frameworks-devel, LeGast00n, sber

D22510: Added dialog to set execute permission for executable file when trying to run it.

broulik added a comment. Doesn't AppImageLauncher take care of this? When I download an AppImage, I click on it in Dolphin and I get prompted whether to integrate it or run once. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22510 To: mdlubakowski, #frameworks Cc: bro

D22488: invoke QIcon::setFallbackThemeName a bit later

broulik added inline comments. INLINE COMMENTS > kicontheme.cpp:267 > +#if QT_VERSION >= QT_VERSION_CHECK(5, 12, 0) > +if (!d->fallbackThemeInitialized) { > +QIcon::setFallbackThemeName(QStringLiteral("breeze")); I guess you can just do a static s_fallbackThemeInitialized = false;

D21672: [PowerStateMonitor] Be conservative when determining power state

broulik added a comment. > Why don't you notify the relevant people first He kinda did by writing a bug report, but let's not argue but investigate and fix why this seemingly innocent patch caused the behavior described. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.

D22472: Port KXMessages away from QWidget

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH master REVISION DETAIL https://phabricator.kde.org/D22472 To: davidedmundson, #plasma, broulik Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22471: [KProcessList] Split command line and process name

broulik added a comment. +1 INLINE COMMENTS > kprocesslist_p.h:46 > qint64 pid; > +QString command; > QString name; Order name before since that's how the methods are ordered REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D22471 To: davidedmundso

D22413: Fix build after 0b2fe3cf21

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kstringhandler.cpp:346 > int length = 0; > auto chrs = text.toUcs4(); > for (auto chr : chrs) { for the reference, `toUcs4()` returns a `QVector` REPO

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

broulik added inline comments. INLINE COMMENTS > sitter wrote in kbusyindicatorwidget.cpp:111 > I was thinking about it, and honestly I am not sure. I don't think we have > access to anything to do with icon units, so we could hardcode some > dimensions (22,22 I guess) but that's about it. How

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

broulik added a comment. Cool! INLINE COMMENTS > kbusyindicatorwidget.cpp:28 > + > +class KBusyIndicatorWidget::Private : public QObject > +{ `Q_DECL_HIDDEN` > kbusyindicatorwidget.cpp:31 > +Q_OBJECT > +Q_PROPERTY(qreal rotation MEMBER rotation WRITE setRotation) > +public: You

D22275: [Svg] Fix porting error from QRegExp::exactMatch

This revision was automatically updated to reflect the committed changes. Closed by commit R242:214838313d9f: [Svg] Fix porting error from QRegExp::exactMatch (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22275?vs=611

D22275: [Svg] Fix porting error from QRegExp::exactMatch

broulik created this revision. broulik added reviewers: Plasma, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY The `CACHE_ID_NATURAL_SIZE` adds stuff around the argument string, so explicitly

D22258: Improve plugin caching

broulik added inline comments. INLINE COMMENTS > pluginloader.cpp:84 > +public: > +QVector findPluginsById(const QString& name, const > QStringList &dirs) { > +const qint64 now = qRound64(QDateTime::currentMSecsSinceEpoch() > / 1000.0); Can you move the function impleme

D22241: KModifierKeyInfo: we are sharing the internal implementation

broulik added a comment. > So why does KModifierKeyInfo::Private need to be shared? It needs to be refcounted. In 0fe2990dbad992a4925a7b7bee09b1cdfbe5a7a7 a plugin infrastructure was introduced. Unbeknownst to us

D22147: Better use of Qt APIs in Plasma::Theme

broulik added inline comments. INLINE COMMENTS > broulik wrote in svg.cpp:313 > When you make it `static` it would only have to compile it once Oh, I think the `static` might be the culprit, I didn't realize the `status` and `ratio` were changing. Sorry REPOSITORY R242 Plasma Framework (Libr

D22241: KModifierKeyInfo: we are sharing the internal implementation

broulik added a comment. I don't think any of these changes are ABI-compatible? REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D22241 To: apol, broulik Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21882: RFC: [CopyJob] Batch reporting processed amount

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a6d24222fdc1: [CopyJob] Batch reporting processed amount (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21882?vs=60022&id=61005 REVISION DETAIL

D19585: [CopyJob] Report results after finishing copy

This revision was automatically updated to reflect the committed changes. Closed by commit R241:0532047f8b97: [CopyJob] Report results after finishing copy (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19585?vs=53345&id=61004 REVISION DETA

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

broulik added inline comments. INLINE COMMENTS > fstabhandling.cpp:227 > +QStringList devices = globalFstabCache->m_mtabCache.keys(); > +const QStringList fstabDevices = globalFstabCache->m_fstabCache.keys(); > + Don't create a temporary `keys()` list just to iterate it. Use a loop like

D22147: Better use of Qt APIs in Plasma::Theme

broulik added inline comments. INLINE COMMENTS > svg.cpp:313 > // and store them locally. > -QRegExp > sizeHintedKeyExpr(CACHE_ID_NATURAL_SIZE(QStringLiteral("(\\d+)-(\\d+)-(.+)"), > status, ratio)); > +const QRegularExpression > sizeHintedKeyExpr(CACHE_ID_NATURAL_SIZE

D21901: Calendar events: allow plugins to show event details

broulik added a comment. Adding a new `virtual` to a non-leaf class is never ABI compatible. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D21901 To: dvratil, #frameworks, mart Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21882: RFC: [CopyJob] Batch reporting processed amount

broulik added a comment. Well, that would just be another symptom of the "doesn't call `slotReport` when finishing the call, no? cf. D19585 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21882 To: broulik, #frameworks, dfaure, chinm

D22073: [KCM GridDelegate] Silence warning

This revision was automatically updated to reflect the committed changes. Closed by commit R296:94479bd7f3e2: [KCM GridDelegate] Silence warning (authored by broulik). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22073?vs=60585&id=60639 REVISION DETAIL

D22076: [KCM GridDelegate] Take into account implicitCellHeight for inner delegate height

This revision was automatically updated to reflect the committed changes. Closed by commit R296:3df42d7f0eb6: [KCM GridDelegate] Take into account implicitCellHeight for inner delegate… (authored by broulik). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D22081: [Fstab] Select appropriate icon for home or root directory

broulik accepted this revision. REPOSITORY R245 Solid BRANCH fstab_overlayfs REVISION DETAIL https://phabricator.kde.org/D22081 To: bruns, ngraham, fvogt, broulik Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22080: [Fstab] Show mounted "overlay" filesystems

broulik accepted this revision. REPOSITORY R245 Solid BRANCH submit REVISION DETAIL https://phabricator.kde.org/D22080 To: bruns, ngraham, fvogt, broulik Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22081: [Fstab] Select appropriate icon for home or root directory

broulik added a comment. +1 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D22081 To: bruns, ngraham, fvogt, broulik Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22076: [KCM GridDelegate] Take into account implicitCellHeight for inner delegate height

broulik added a dependent revision: D22077: [Colors KCM] Add title bar to preview delegate. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22076 To: broulik, #plasma, mart Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22076: [KCM GridDelegate] Take into account implicitCellHeight for inner delegate height

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It only affected the `cellHeight` of the `GridView` but not the actual size of t

D22073: [KCM GridDelegate] Silence warning

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY When the model doesn't have a `pluginName` property TEST PLAN Color kcm no lon

D20210: [Label] Bump import version so padding properties are available

broulik abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20210 To: broulik, #plasma Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22015: [KUiServerJobTracker] Handle ownership change

This revision was automatically updated to reflect the committed changes. Closed by commit R288:cf6cdbb3ad9b: [KUiServerJobTracker] Handle ownership change (authored by broulik). REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22015?vs=60417&id=60419 REVIS

D22015: [KUiServerJobTracker] Handle ownership change

broulik created this revision. broulik added reviewers: Frameworks, dfaure, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Just look whether we have a new service instead of assuming

D21989: Don't show error message if sharing is cancelled by the user

broulik added inline comments. INLINE COMMENTS > sharefileitemaction.cpp:55 > +// error == 0 means no error, error == 1 means cancelled by the user > +if (error <= 1) { > if (output.contains(QLatin1String("url"))) If possible use `KIO::ERR_USER_CANCELED`, otherwise d

D21882: RFC: [CopyJob] Batch reporting processed amount

broulik created this revision. broulik added reviewers: Frameworks, dfaure, chinmoyr. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY While reporting the number of files is batched, the processed amo

D21780: Add X-Flatpak-RenamedFrom as recognized key

This revision was automatically updated to reflect the committed changes. Closed by commit R309:d39cabf2ae86: Add X-Flatpak-RenamedFrom as recognized key (authored by broulik). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21780?vs=59727&id=60015 REVISION D

D21780: Add X-Flatpak-RenamedFrom as recognized key

broulik created this revision. broulik added reviewers: Frameworks, dfaure, sitter. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Flatpak enforces RDN notation (`com.example.foo.bar`) from appstrea

D21618: Allow QtQuick applets and wallpapers to defer UiReadyConstraint

broulik added inline comments. INLINE COMMENTS > appletinterface.cpp:172 > > -applet()->updateConstraints(Plasma::Types::UiReadyConstraint); > +if (m_loadingRef == 0) { > +applet()->updateConstraints(Plasma::Types::UiReadyConstraint); In my case this code path is hit before any

D21425: [UDev Backend] Filter for ID_MEDIA_PLAYER already when querying

broulik abandoned this revision. broulik added a comment. Pushed as part of D21379 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21425 To: broulik, #frameworks, davidedmundson, bruns Cc: kde-frameworks-devel, LeGast00n, michaelh,

D21379: [UDev Backend] Narrow device queried for

This revision was automatically updated to reflect the committed changes. Closed by commit R245:fe1c9c02e09f: [UDev Backend] Narrow device queried for (authored by broulik). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21379?vs=59052&id=59253 REVISION DETAIL

D21379: [UDev Backend] Narrow device queried for

broulik added a comment. Ping :) In D21379#472870 , @bruns wrote: > The question now is, should we also differnentiate here, i.e. map `QVariant()` to `nullptr`, and use `"*"` for wildcards? What do you mean? REPOSITORY R245 Solid

D21572: [UnindexedFileIndexer] Loop optimizations (avoid detach, invariants)

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D21572 To: bruns, #baloo, ngraham, astippich, poboiko, broulik Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, micha

D21502: [PlasmaComponents3] Vertically center button text as well

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH vertically-center-button-text (branched from master) REVISION DETAIL https://phabricator.kde.org/D21502 To: ngraham, #plasma, broulik Cc: broulik, apol, kde-f

D21555: [KFilePlacesModel] Explicitly query for PTP cameras

broulik added a comment. The Solid predicate actually uses `Camera.supportedDrivers == 'gphoto'` and while this patch worked perfectly fine this morning somehow not nothing works :( REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21555 To: broulik, #frameworks, bruns Cc

D21379: [UDev Backend] Narrow device queried for

broulik updated this revision to Diff 59052. broulik edited the test plan for this revision. broulik added a comment. - Use `*` wildcard REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21379?vs=58850&id=59052 REVISION DETAIL https://phabricator.kde.org/D213

D21555: [KFilePlacesModel] Explicitly query for PTP cameras

broulik created this revision. broulik added reviewers: Frameworks, bruns. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY From what I can tell Solid UDev backend returns all kinds of devices that w

D21440: Delay running UnindexedFileIndexer and IndexCleaner

This revision was automatically updated to reflect the committed changes. Closed by commit R293:a24624c88d79: Delay running UnindexedFileIndexer and IndexCleaner (authored by broulik). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21440?vs=58853&id=59047 REVIS

D21379: [UDev Backend] Narrow device queried for

broulik added a comment. For some reason here my `udev_enumerate_add_match_property("ID_MEDIA_PLAYER", null)` doesn't work. If I check for "1" it works but `null` doesn't find any devices. Since the systemd code uses `fnmatch`, we can probably just pass `*` to it to match anything. REPOSITO

D21379: [UDev Backend] Narrow device queried for

broulik reopened this revision. broulik added a comment. This revision is now accepted and ready to land. I just reverted it as it indeed causes problems with initial device lookup. Not just in plasmashell but also in Dolphin. Since Frameworks tagging is tomrrow, better leave it for now and i

D21502: [PlasmaComponents3] Vertically center button text as well

broulik added inline comments. INLINE COMMENTS > ngraham wrote in Button.qml:56 > Apparently not, because explicitly adding this does make a difference, as the > before-and-after images show. I think he was asking why not just make it `true` unconditionally REPOSITORY R242 Plasma Framework (

D21440: Delay running UnindexedFileIndexer and IndexCleaner

broulik added a comment. Thanks for the shipit but I'd like @bruns to have the final word on this REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21440 To: broulik, bruns, #baloo, davidedmundson, ngraham Cc: ngraham, poboiko, kde-frameworks-devel, gennad, domson, ashap

D21440: Delay running UnindexedFileIndexer and IndexCleaner

broulik added a task: T10958: Faster Startup. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21440 To: broulik, bruns, #baloo, davidedmundson Cc: poboiko, kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21440: Delay running UnindexedFileIndexer and IndexCleaner

broulik updated this revision to Diff 58853. broulik retitled this revision from "Start baloo_file later" to "Delay running UnindexedFileIndexer and IndexCleaner". broulik edited the summary of this revision. broulik edited the test plan for this revision. broulik added a comment. - Delay inde

D21440: Start baloo_file later

broulik added a comment. I would assume so. In the graph, which is a VM, ksplashqml is signalled to quit 2 seconds into the startup at which point plasmashell is pretty much done. So if we delay it by 5 seconds or so that could already be plenty I think. I'll give it a go next week. REPOSIT

D21440: Start baloo_file later

broulik planned changes to this revision. broulik added a comment. Look into delaying the `UnindexedFileIndexer` and `IndexCleaner`. Can I just use `QTimer` or do you want something more sophisticated? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21440 To: broulik,

D20833: Simpler check for flatpak

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D20833 To: apol, #frameworks, broulik Cc: jgrulich, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D21379: [UDev Backend] Narrow device queried for

This revision was automatically updated to reflect the committed changes. Closed by commit R245:079b2bc91cb2: [UDev Backend] Narrow device queried for (authored by broulik). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21379?vs=58839&id=58850 REVISION DETAIL

D21379: [UDev Backend] Narrow device queried for

broulik updated this revision to Diff 58839. broulik retitled this revision from "[UDev Backend] Narrow subsystems queried for cameras" to "[UDev Backend] Narrow device queried for". broulik edited the summary of this revision. broulik edited the test plan for this revision. broulik added a commen

D21440: Start baloo_file later

broulik added a comment. So, I can haz shipit? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21440 To: broulik, bruns, #baloo, davidedmundson Cc: poboiko, kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21379: [UDev Backend] Narrow subsystems queried for cameras

broulik added inline comments. INLINE COMMENTS > bruns wrote in udevqtclient.cpp:223 > Nitpick - the existing code uses `toLatin1()`, and for the ASCII subset it > doesn't matter, but I am quite sure properties and values are UTF8 in general. > > I have no strong proof, but the udev changelog h

D21379: [UDev Backend] Narrow subsystems queried for cameras

broulik added a comment. So, you want me to change that `1` to `QVariant()` then? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21379 To: broulik, #frameworks, davidedmundson, bruns Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21440: Start baloo_file later

broulik added a comment. The idle tracking is only in the extractor process, not in baloo_file itself. On startup it runs the `UnindexedFileIndexer` and iterates all the folders looking for files to re-index, consuming a considerable amount of CPU time, spending most of its time doing regexp

D21440: Start baloo_file later

broulik added a comment. Thanks for your input. Yeah, I was mostly interested in having the file extractor wait some more. I'll poke the thing a bit then. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21440 To: broulik, bruns, #baloo, davidedmundson Cc: kde-framewor

D21441: Start krunner later

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5bb4680bcffc: Start krunner later (authored by broulik). Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://

D21441: Start krunner later

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. TEST PLAN Ideally, KRunner were DBus-activated and launched the first time you hit the shortcut, or ne

D21440: Start baloo_file later

broulik created this revision. broulik added reviewers: bruns, Baloo, davidedmundson. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY We noticed that `baloo_file` starts quite early in the proc

D21425: [UDev Backend] Filter for ID_MEDIA_PLAYER already when querying

broulik added a comment. However in `queryDeviceInterface` we actually check for it being `"1"` REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21425 To: broulik, #frameworks, davidedmundson, bruns Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19677: WIP: Port UDisks to using DBus ObjectManager

broulik added a comment. You mean I kill that entire `DeviceBackend` wrapper and have `Device` do all the things with all the data stored in the `DeviceManager`? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D19677 To: broulik, #frameworks, bruns Cc: apol, nicolasfel

D21379: [UDev Backend] Narrow subsystems queried for cameras

broulik added a dependent revision: D21425: [UDev Backend] Filter for ID_MEDIA_PLAYER already when querying. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21379 To: broulik, #frameworks, davidedmundson, bruns Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21425: [UDev Backend] Filter for ID_MEDIA_PLAYER already when querying

broulik created this revision. broulik added reviewers: Frameworks, davidedmundson, bruns. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This avoids us creating wrapper objects for UDev devices we

D21379: [UDev Backend] Narrow subsystems queried for cameras

broulik updated this revision to Diff 58706. broulik edited the summary of this revision. broulik edited the test plan for this revision. broulik added a comment. - Limit to `usb` subsystem only - Add docs REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2137

D21419: Export SortFilterModel sort column to QML

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > datamodel.cpp:197 > +sort(sortColumn(), order); > +} > + please add a `sortOrderChanged` signal (in a separate patch, if you feel like it) REPOSITORY R242 Pla

D21379: [UDev Backend] Narrow subsystems queried for cameras

broulik added a comment. Okay, so we can just filter for "usb" then since we don't monitor "block" and "scsi_generic" > This definitely needs some documentation Agreed REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21379 To: broulik, #frameworks, davidedmun

D21379: [UDev Backend] Narrow subsystems queried for cameras

broulik added a comment. Thanks, @bruns but what does this mean for this patch? :D REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21379 To: broulik, #frameworks, davidedmundson, bruns Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21379: [UDev Backend] Narrow subsystems queried for cameras

broulik created this revision. broulik added reviewers: Frameworks, davidedmundson, bruns. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It currently scans all UDev devices, including processors, f

D19585: [CopyJob] Report results after finishing copy

broulik edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19585 To: broulik, dfaure, chinmoyr Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21099: Use locale currency for donate icon

This revision was automatically updated to reflect the committed changes. Closed by commit R265:80cc612a50e9: Use locale currency for donate icon (authored by broulik). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21099?vs=57806&id=58540 REVISION DET

D21235: Add handling of fuseiso filesystem type

broulik added a comment. Right. +1 INLINE COMMENTS > fstabdevice.cpp:88 > } else { > m_description = QCoreApplication::translate("", "%1 (%2)", > "%1 is mountpoint, %2 is fs type").arg(m_product, m_vendor); Can we maybe give it a better description then? Fo

D21235: Add handling of fuseiso filesystem type

broulik added a comment. I had iso images shown as loop devices through udisks already, why is this needed? Patch looks fine, just curious. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21235 To: hallas, bruns, ngraham Cc: broulik, kde-frameworks-devel, michaelh, ng

D21339: Block a bit less when introspecting udisks

broulik added a comment. Please see D19677 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21339 To: apol, #frameworks, bruns Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D21115: [KCModuleQML] Fix typo breaking implicitWidth for modules

broulik closed this revision. broulik added a comment. https://cgit.kde.org/kcmutils.git/commit/?id=0af14cfe4dc55c6dcc6680b367fd78d2cf79b37d REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D21115 To: broulik, #plasma, mart Cc: heikobecker, kde-frameworks-devel, mich

D21119: [JobDialog] Also signal cancellation when window is closed by the user

This revision was automatically updated to reflect the committed changes. Closed by commit R495:b70018ee4b3e: [JobDialog] Also signal cancellation when window is closed by the user (authored by broulik). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2

D21126: [KUiServerJobTracker] Register jobs asynchronously

broulik updated this revision to Diff 57864. broulik added a comment. - When reply comes in after job already finished, call terminate on the jobview to end it gracefully REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21126?vs=57862&id=57864 REVISION

D21126: [KUiServerJobTracker] Register jobs asynchronously

broulik planned changes to this revision. broulik added a comment. However now it obviously misses the first calls to set message and what not because the job view doesn't yet exist there... REPOSITORY R288 KJobWidgets REVISION DETAIL https://phabricator.kde.org/D21126 To: broulik, #fra

D21127: [KDynamicJobTracker] Ask kuiserver asynchronously

broulik created this revision. broulik added reviewers: Frameworks, dfaure, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This is only a fallback option so it shouldn't jeopardize t

D21126: [KUiServerJobTracker] Register jobs asynchronously

broulik edited the summary of this revision. REPOSITORY R288 KJobWidgets REVISION DETAIL https://phabricator.kde.org/D21126 To: broulik, #frameworks, dfaure, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21126: [KUiServerJobTracker] Register jobs asynchronously

broulik created this revision. broulik added reviewers: Frameworks, dfaure, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Don't block waiting for the server to register the job, esp

D21119: [JobDialog] Also signal cancellation when window is closed by the user

broulik created this revision. broulik added reviewers: Plasma, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This signal is emitted when the user tries to close the window manually, not whe

D21115: [KCModuleQML] Fix typo breaking implicitWidth for modules

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. TEST PLAN Now the notification KCM opens at a saner size The grid view kcms with a wider delegat

D21099: Use locale currency for donate icon

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in kstandardaction.cpp:202 > else iconName = "help-donate" ? That's the default specified in the struct already REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D21099 To: broulik, #frameworks,

D21099: Use locale currency for donate icon

broulik added a comment. https://en.wikipedia.org/wiki/ISO_4217#Active_codes if you want to have fun with it I guess :D REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D21099 To: broulik, #frameworks, #vdg, ngraham Cc: ngraham, sitter, kde-frameworks-devel, mi

<    1   2   3   4   5   6   7   8   9   10   >