[Differential] [Updated] D3568: Find the correct path to the cmake command

kfunk edited reviewers, added: Frameworks; removed: Framework: Syntax Hightlighting. BRANCH find-cmake-binary REVISION DETAIL https://phabricator.kde.org/D3568 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: obogdan, kfunk, #frameworks Cc: kfunk

[Differential] [Requested Changes To] D2075: Fix bug in kfiledialog.cpp that causes crashing when native widgets are used.

kfunk requested changes to this revision. kfunk added a reviewer: kfunk. kfunk added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kfiledialog.cpp:607 > +if (d->native) { > +return; > +} Should we rather check for `!d->w` here and below? Would

[Differential] [Updated] D3586: [WIP] Fix logging category usage on Windows

kfunk added a reviewer: Frameworks. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D3586 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: vonreth, sandsmark, kfunk, leinir, #frameworks Cc: kfunk, leinir, mutlaqja

[Differential] [Updated] D3691: Update QMake syntax highlighting file

kfunk added a reviewer: Frameworks. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D3691 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks

[Differential] [Updated, 674 lines] D3691: Update QMake syntax highlighting file

kfunk updated this revision to Diff 9048. kfunk added a comment. Add generator REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3691?vs=9047&id=9048 BRANCH master REVISION DETAIL https://phabricator.kde.org/D3691 AFFECTED FILES data/gener

[Differential] [Commented On] D2545: Cleanup KSharedUiServerProxy before qApp exists

kfunk added a comment. > Here's the other problem: it's possible for threads to simply disappear on Windows. Given that I see "dllmain" in the backtrace (though not DllMain), I can't rule out that this has happened. Qt 5.6 has a workaround to another deadlock caused by Windows. Can you try t

[Differential] [Commented On] D2545: Cleanup KSharedUiServerProxy before qApp exists

kfunk added a comment. For the record, since I don't see an easy fix I'm pondering about patching qtbase in craft.git: Ideas: a ) Add this to QDBusConnectionManager ctor: qAddPostRoutine([]() { QMetaObject::invokeMethod(QDBusConnectionManager::instance(), "quit");

[Differential] [Commented On] D2545: Cleanup KSharedUiServerProxy before qApp exists

kfunk added a comment. In https://phabricator.kde.org/D2545#69091, @thiago wrote: > There doesn't seem to be a way of doing some clean up before the threads are forcibly killed. > > Maybe if I abuse qtmain(). This would only fix it for non-console GUI applications if I underst

[Differential] [Updated] D3702: kconfig_compiler: Use nullptr in generated code

kfunk added a reviewer: Frameworks. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D3702 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks

[Differential] [Closed] D3702: kconfig_compiler: Use nullptr in generated code

This revision was automatically updated to reflect the committed changes. Closed by commit R237:e6c88f67e2cb: kconfig_compiler: Use nullptr in generated code (authored by kfunk). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3702?vs=9072&id=9075 REVISION DET

[Differential] [Commented On] D2075: Fix bug in kfiledialog.cpp that causes crashing when native widgets are used.

kfunk added a comment. In https://phabricator.kde.org/D2075#66751, @jonathans wrote: > Agreed that would be more robust. In writing the patch I was seeking consistency with those functions that already did the test, so those would also need to be updated. Are there any situations where t

[Differential] [Commented On] D3691: Update QMake syntax highlighting file

kfunk added a comment. Bump REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D3691 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks

[Differential] [Closed] D3691: Update QMake syntax highlighting file

This revision was automatically updated to reflect the committed changes. Closed by commit R216:c3fc1271d6ad: Update QMake syntax highlighting file (authored by kfunk). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3691?vs=9048&id=9163#toc REPOSITORY R216 Syntax Highlighting CHANGES

[Differential] [Commented On] D2545: Cleanup KSharedUiServerProxy before qApp exists

kfunk added a comment. In https://phabricator.kde.org/D2545#69298, @thiago wrote: > In https://phabricator.kde.org/D2545#69187, @kfunk wrote: > > > In https://phabricator.kde.org/D2545#69091, @thiago wrote: > > > > > There doesn't seem to be a way of doing some clean up before the

[Differential] [Commented On] D3830: Add a new FindGperf module

kfunk added a comment. Windows: We have working gperf recipe in Craft => we're fine. QtWebKit already had an (optional) dependency on gperf. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3830 EMAIL PREFERENCES https://phabricator.kde.org/settings

[Differential] [Changed Subscribers] D3548: Add begin/end insert/remove columns to RearrangeColumns

kfunk added inline comments. INLINE COMMENTS > krearrangecolumnsproxymodel.cpp:44 > + > +const int cc = d_ptr->m_sourceColumns.size(); > + Please no short hand variable names. `cc` -> `sourceColCount`? REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D3548 EMAI

[Differential] [Updated] D3548: Add begin/end insert/remove columns to RearrangeColumns

kfunk added a reviewer: dfaure. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D3548 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: lepagevalleeemmanuel, #frameworks, dfaure Cc: kfunk, ltoscano

[Differential] [Requested Changes To] D3733: Force colored warnings in ninja's output

kfunk requested changes to this revision. kfunk added a reviewer: kfunk. kfunk added a comment. This revision now requires changes to proceed. This flag is only needed for Ninja, correct? Thus please check for Ninja in `CMAKE_GENERATOR ` before adding the compiler flag. REPOSITORY R240 Extr

[Differential] [Accepted] D3733: Force colored warnings in ninja's output

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R240 Extra CMake Modules BRANCH ninja-colors REVISION DETAIL https://phabricator.kde.org/D3733 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpref

[Differential] [Updated] D3850: Pass -fno-operator-names when supported

kfunk added a reviewer: Frameworks. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3850 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks

[Differential] [Updated] D3850: Pass -fno-operator-names when supported

kfunk added a reviewer: ivan. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3850 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks, ivan

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

kfunk added a comment. Note: Just refreshing my complete KF5 build to test the change. kactivities fails: /home/kfunk/devel/src/kf5/kactivities/autotests/common/test.h:143:25: error: token is not a valid binary operator in a preprocessor subexpression #if defined(Q_NO_DEBUG) or

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

kfunk added a comment. In https://phabricator.kde.org/D3850#72077, @elvisangelaccio wrote: > What about adding a way (cmake variable?) to opt-in if one wants to use the alternative operators? Personally I like and use them whenever I start something from scratch... Hmm... You cou

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

kfunk added a comment. In https://phabricator.kde.org/D3850#72308, @rakuco wrote: > Isn't it better to use `check_cxx_compiler_flag` to see if the flag is supported and enable it in case it is? -fno-operator-names is an ancient compiler flag, supported by GCC since at least 2000

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

kfunk added a comment. Note: I'll push this after the imminent KF5 release if no-one objects. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D3850 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfun

[Differential] [Accepted] D3977: Fix memleak in KDynamicJobTracker, KWidgetJobTracker needs QApplication

kfunk accepted this revision. kfunk added a reviewer: kfunk. kfunk added a comment. This revision is now accepted and ready to land. Rest LGTM, but let's wait for another review INLINE COMMENTS > kdynamicjobtrackernowidgetstest.cpp:34 > +public: > +virtual void start() { QTimer::singleSho

[Differential] [Updated] D3987: Use nullptr in all Frameworks (just diff in KIO shown here)

kfunk updated the summary for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D3987 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks

[Differential] [Request, 2,027 lines] D3987: Use nullptr in all Frameworks (just diff in KIO shown here)

kfunk created this revision. kfunk added a reviewer: Frameworks. kfunk set the repository for this revision to R241 KIO. Restricted Application added a project: Frameworks. REVISION SUMMARY The full patch (all Frameworks ported to using nullptr instead of null literals) changes around 9000 line

[Differential] [Updated] D3987: Use nullptr in all Frameworks (just diff in KIO shown here)

kfunk updated the summary for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D3987 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks

[Differential] [Commented On] D3987: Use nullptr in all Frameworks (just diff in KIO shown here)

kfunk added inline comments. INLINE COMMENTS > graesslin wrote in job.h:50 > Question: is this change API and ABI stable? Definitely ABI stable, since default arguments are not part of the function signature. I'm not aware this could break API compat either (well, only in case the compiler co

<    1   2   3   4   5   6