D8810: Do not look for kioslave binary in applicationDirPath on *nix (#386859)

2019-08-24 Thread Kevin Kofler
kkofler added a comment. If you ask me (there are 2 Kevins on this bug), I think this will work. I think it's kinda overkill (it pretty much defeats the point of having version-specific libexecdirs if we end up renaming the binaries anyway), but if it works (which should be the case), I'm OK

D8810: Do not look for kioslave binary in applicationDirPath on *nix (#386859)

2019-01-03 Thread Kevin Kofler
kkofler added a comment. Herald added a subscriber: kde-frameworks-devel. Ping? This has been stuck for over a year now. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8810 To: kkofler, #frameworks, kfunk, cullmann Cc: kde-frameworks-devel, dfaure, ngraham, broulik, kfu

D8810: Do not look for kioslave binary in applicationDirPath on *nix (#386859)

2017-11-14 Thread Kevin Kofler
kkofler added a comment. And the historical reason the name was not suffixed is because the binary was moved to a private libexec subdirectory to prevent conflicts. This worked fine as long as `/usr/bin` did not end up in the search path (in particular, for the whole 4.x series). REPOSITORY

D8810: Do not look for kioslave binary in applicationDirPath on *nix (#386859)

2017-11-14 Thread Kevin Kofler
kkofler added a comment. In https://phabricator.kde.org/D8810#167568, @cullmann wrote: > Yeah, that was done to be able to provide win/linux install bundles. A GNU/Linux install bundle should have a reparented FHS-like tree, possibly wrapped in an image file (Flatpak/Snap/AppImage

D8810: Do not look for kioslave binary in applicationDirPath on *nix (#386859)

2017-11-14 Thread Kevin Kofler
kkofler updated this revision to Diff 22338. kkofler retitled this revision from "Do not look for kioslave binary in applicationDirPath (#386859)" to "Do not look for kioslave binary in applicationDirPath on *nix (#386859)". kkofler edited the summary of this revision. kkofler added a comment.

D8810: Do not look for kioslave binary in applicationDirPath (#386859)

2017-11-13 Thread Kevin Kofler
kkofler created this revision. kkofler added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY src/core/slave.cpp (Slave::createSlave): Do not look for the kioslave binary in QCoreApplication::applicationDirPath(). In distribution packages, this end

Re: Review Request 128437: raise to core dump handlers when drkonqi is done

2016-07-14 Thread Kevin Kofler
retain whoopsie (crash report sending to > errors.ubuntu.com). As I mentioned, this needs dealing with in ubuntu since > they essentially attach a UI to coredumps, so either that or drkonqi need > disabling on their platform. > > Kevin Kofler wrote: > The problem with the du

Re: Review Request 128437: raise to core dump handlers when drkonqi is done

2016-07-14 Thread Kevin Kofler
> On Juli 13, 2016, 12:43 nachm., Kai Uwe Broulik wrote: > > +1 to the idea > > > > However, will this mean we get this awful apport "something crashed, now or > > in the past" tray icon in addition to Drkonqi? > > Harald Sitter wrote: > yes. its upon ubuntu to make that go away though as

Re: Review Request 128437: raise to core dump handlers when drkonqi is done

2016-07-14 Thread Kevin Kofler
> On Juli 13, 2016, 10:15 nachm., Kevin Kofler wrote: > > I am opposed to this change, because it spams downstream packagers with > > crash bugs they are usually not qualified to fix. Those few distributions > > that really do want to get the reports downstrea

Re: Review Request 128437: raise to core dump handlers when drkonqi is done

2016-07-13 Thread Kevin Kofler
packagers with crash bugs they are usually not qualified to fix. Those few distributions that really do want to get the reports downstream (e.g. RHEL) already explicitly disable DrKonqi. - Kevin Kofler On Juli 13, 2016, 12:40 nachm., Harald Sitter wrote

Caveat about QFileDialog

2011-11-17 Thread Kevin Kofler
construct a QFileDialog OBJECT as the above commit does, you always get the ugly Qt-only dialog! So it's a very bad idea to do that. Kevin Kofler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listi