D23736: Add a Term::Type::files() to filter excluding directories

meven updated this revision to Diff 65446. meven added a comment. Exclude files whose mimetype is not known from the files filter REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23736?vs=65433&id=65446 BRANCH master REVISION DETAIL https

D23420: Use solid to check if a KFileItem is located on a network mount

meven added a comment. I didn't know about `KMount` Gwenview uses it as we are trying here : bool urlIsFastLocalFile(const QUrl &url) { if (!url.isLocalFile()) { return false; } KMountPoint::List list = KMountPoint::currentMountPoints();

D23736: Add a Term::Type::files() to filter excluding directories

meven created this revision. meven added a reviewer: ivan. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL https://phabricator.kde.org/D23736

D7446: [Places panel] Revamp the Recently Saved section

meven added a comment. In D7446#526032 , @ngraham wrote: > This works great. > > one minor concern I have with the new IOSlave in general is how it shows both files and folders. For me, the folders are a distraction from the file listing. But

D23730: Add new protocol for 7z archives

meven requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D23730 To: nhiga, meven Cc: ltoscano, meven, ngraham, kfm-devel, kde-frameworks-devel, iasensio, fprice, LeGast00n, MrPepe, fbampal

D23730: Add new protocol for 7z archives

meven added a comment. In D23730#526024 , @ltoscano wrote: > Does it work when the older KIO is installed? Yes, I have tested it. INLINE COMMENTS > sevenz.protocol:3 > +exec=kf5/kio/archive > +protocol=sevenz > +archiveMimetype=applicati

D7446: [Places panel] Revamp the Recently Saved section

meven added a comment. ping @ngraham any luck testing this ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoor

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > jgrulich wrote in wirelessdevice.h:143 > Please do, you can push it directly, it's just a function rename. https://cgit.kde.org/networkmanager-qt.git/commit/?id=af98fdba63e32c38008592774436ae6c9b61cd90 REPOSI

D23730: Add new protocol for 7z archives

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. In D23730#526010 , @ngraham wrote: > Probably best to submit the KIO patch first. D23490 has been ac

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

meven updated this revision to Diff 65374. meven marked 5 inline comments as done. meven added a comment. Review feedback, add @since, review mapConfig signature, reset config and configGroup to nullptr after deletion REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

meven added inline comments. INLINE COMMENTS > jgrulich wrote in wirelessdevice.h:143 > Thinking about it now, wouldn't be this wording better? > > QDateTime lastScanRequestTime() const; > > Maybe even without the "Time" at the end so it's consistent with "lastScan". I chose lastRequestScanTim

D23667: Add == and != operators to KIO::UDSEntry

meven updated this revision to Diff 65298. meven added a comment. fix since mention REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23667?vs=65297&id=65298 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23667 AFFECTED FILES autotests/udsentr

D23667: Add == and != operators to KIO::UDSEntry

meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23667 To: meven, #frameworks Cc: pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23667: Add == and != operators to KIO::UDSEntry

meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23667 To: meven, #frameworks Cc: pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23667: Add == and != operators to KIO::UDSEntry

meven updated this revision to Diff 65297. meven added a comment. Fix test udsentrybenchmark REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23667?vs=65296&id=65297 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23667 AFFECTED FILES autotest

D23667: Add == and != operators to KIO::UDSEntry

meven updated this revision to Diff 65296. meven added a comment. Clean spaces changes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23667?vs=65295&id=65296 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23667 AFFECTED FILES autotests/udse

D23667: Add == and != operators to KIO::UDSEntry

meven updated this revision to Diff 65295. meven added a comment. Move impl to cpp file, fix comment, add unit test REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23667?vs=65218&id=65295 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23667 AF

D23667: Add == and != operators to KIO::UDSEntry

meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY I felt it was missing. TEST PLAN Compiles REPOSITORY R241 KIO BRANCH master RE

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

meven added a comment. D23578 is the next step, but it is not in great shape. To do things properly, it will require quite some changes I fear. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D23576 To: meven, jgrulich

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

This revision was automatically updated to reflect the committed changes. Closed by commit R282:d9cb570cbef4: Add property lastScanTime and lastRequestTime to WirelessDevice (authored by meven). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23576?vs=

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

meven edited the summary of this revision. REPOSITORY R282 NetworkManagerQt BRANCH master REVISION DETAIL https://phabricator.kde.org/D23576 To: meven, jgrulich Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

meven updated this revision to Diff 65208. meven added a comment. Add a ref to the returned date REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23576?vs=65204&id=65208 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23576 AFFECTED

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

meven updated this revision to Diff 65204. meven marked an inline comment as done. meven added a comment. Review, remove incorrect doc REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23576?vs=65002&id=65204 BRANCH master REVISION DETAIL https:

D23650: Add an icon for the trash root and a proper label

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a9f8aeb11776: Add an icon for the trash root and a proper label (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23650?vs=65144&id=65205 REVISION DE

D23650: Add an icon for the trash root and a proper label

meven added a comment. In D23650#524092 , @Codezela wrote: > Why trash icon don't look like trash > Like any other os This is not related to this patch. Open a design bug if you'd like. REPOSITORY R241 KIO BRANCH master REVISION

D23650: Add an icon for the trash root and a proper label

meven added a reviewer: broulik. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D23650 To: meven, ngraham, #frameworks, broulik Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

meven marked 3 inline comments as done. meven added inline comments. INLINE COMMENTS > broulik wrote in slavebase.cpp:281 > This is initialized automatically like this That's on purpose, the first use of mapConfig is in rebuildConfig and is a clear() call. REPOSITORY R241 KIO REVISION DETAI

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

meven updated this revision to Diff 65200. meven marked an inline comment as done. meven added a comment. Review feedback REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23523?vs=65006&id=65200 BRANCH arcpatch-D23523_1 REVISION DETAIL https://phabricator.k

D7446: [Places panel] Revamp the Recently Saved section

meven updated this revision to Diff 65199. meven added a comment. arc amend REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=65198&id=65199 BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kde.org/D7446 AFFECTED FILES autotests/kfileplac

D7446: [Places panel] Revamp the Recently Saved section

meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni,

D7446: [Places panel] Revamp the Recently Saved section

meven updated this revision to Diff 65198. meven added a comment. Better variable naming REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=65197&id=65198 BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kde.org/D7446 AFFECTED FILES autote

D7446: [Places panel] Revamp the Recently Saved section

meven updated this revision to Diff 65197. meven added a comment. Add recentlyused:/ entry to Recent group to existing users REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=65191&id=65197 BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kd

D7446: [Places panel] Revamp the Recently Saved section

meven updated this revision to Diff 65191. meven added a comment. Rebase REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=64927&id=65191 BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kde.org/D7446 AFFECTED FILES autotests/kfileplacesm

D23650: Add an icon for the trash root and a proper label

meven added a comment. I need a fix in dolphin so that the icon in dolphin information panel is updated after the trash is emptied. Will come soon. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23650 To: meven, ngraham, #frameworks Cc: broulik, kde-frameworks-devel,

D23650: Add an icon for the trash root and a proper label

meven marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23650 To: meven, ngraham, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23650: Add an icon for the trash root and a proper label

meven updated this revision to Diff 65144. meven added a comment. Notify that trash:/ has changed when emptied, add Display Name REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23650?vs=65140&id=65144 BRANCH master REVISION DETAIL https://phabricator.kde.o

D23650: Add an icon for the trash root and a proper label

meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23650 To: meven, ngraham, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23650: Add an icon for the trash root and a proper label

meven created this revision. meven added reviewers: ngraham, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY BUG: 392882 REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://p

D7446: [Places panel] Revamp the Recently Saved section

meven added a comment. Should we add this to existing users places settings ? Like we do with `withBaloo` for instance, adding it if it was not added before. INLINE COMMENTS > kfileplacesmodel.cpp:315 > +// Add a Recently Used entry if available (it comes from kio-extras) > +

D23598: Make battery serial property constant

This revision was automatically updated to reflect the committed changes. Closed by commit R245:76710483c865: Make battery serial property constant (authored by meven). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23598?vs=65033&id=65041 REVISION DETAIL htt

D23598: Make battery serial property constant

meven edited the summary of this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23598 To: meven, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23598: Make battery serial property constant

meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Since serial property cannot change and has no NOTIFY function, mark it as constant, to

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

meven updated this revision to Diff 65006. meven added a comment. Lazily construct the KConfig but keep the instance as long as no config changes has occured REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23523?vs=64816&id=65006 BRANCH arcpatch-D23523_1 RE

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

meven marked 4 inline comments as done. meven added a comment. I have implemented the CLOCK_BOOTTIME conversion to QDateTime in `QDateTime NetworkManager::clockBootTimeToQDateTime` REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D23576 To: meven, jgrulich Cc

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

meven updated this revision to Diff 65002. meven added a comment. Convert the LastScan value to a QDateTime, update function and doc in consequence REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23576?vs=64987&id=65002 BRANCH master REVISION D

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

meven added inline comments. INLINE COMMENTS > jgrulich wrote in wirelessdevice.cpp:250 > Then cannot you work with it as with qlonglong? It shouldn't matter then if > it's in CLOCK_BOOTIME . I need to be able to know the elapsed time since LastScan. So it doesn't matter as long as I manage to

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

meven marked 2 inline comments as done. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D23576 To: meven, jgrulich Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

meven updated this revision to Diff 64987. meven added a comment. Mention nm version limitation REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23576?vs=64983&id=64987 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23576 AFFECTED

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

meven added a comment. In D23576#522341 , @jgrulich wrote: > In D23576#522340 , @meven wrote: > > > I am hesitant to add a second field "previousScan" that would store the previous lastScan timeStamp

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

meven added a dependent revision: D23578: Before requesting a scan, check the time threshold. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D23576 To: meven, jgrulich Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

meven retitled this revision from "Add property lastScan to WirelessDevice and associated change signal" to "Add property lastScanTime and lastRequestTime to WirelessDevice". meven edited the summary of this revision. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

meven edited the summary of this revision. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D23576 To: meven, jgrulich Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23576: Add property lastScan to WirelessDevice and associated change signal

meven updated this revision to Diff 64983. meven added a comment. Change parameters REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23576?vs=64981&id=64983 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23576 AFFECTED FILES src/

D23576: Add property lastScan to WirelessDevice and associated change signal

meven added a comment. I am hesitant to add a second field "previousScan" that would store the previous lastScan timeStamp when a new one arrives. This would be used to compute the time elapsed between the scans which is necessary to do since Network manager requires scans to be at least 10

D23576: Add property lastScan to WirelessDevice and associated change signal

meven created this revision. meven added a reviewer: jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. Herald added 1 blocking reviewer(s): jgrulich. meven requested review of this revision. REVISION SUMMARY To properly use the WirelessDevice::Request

D23555: Add @since 5.62 for newly added setters

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > kossebau wrote in query.h:101 > One issue here: for doxygen to pick this up and thus add to generated docs, > the comment has to start with `/**`. Fixing myself this time, as I have the > code in front of me

D7446: [Places panel] Revamp the Recently Saved section

meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, anthonyf

D7446: [Places panel] Revamp the Recently Saved section

meven updated this revision to Diff 64927. meven added a comment. Adapt kio tests to changes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=64880&id=64927 BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kde.org/D7446 AFFECTED FILES au

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

meven edited the summary of this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D21760 To: hallas, davidedmundson, broulik, #frameworks, dfaure, bruns, #plasma Cc: meven, cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23556: Add version requirement to dependency KActivitiesStats

This revision was automatically updated to reflect the committed changes. Closed by commit R320:bca85c1c50c1: Add version requirement to dependency KActivitiesStats (authored by meven). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23556?vs=64918&id=64923

D23555: Add @since 5.62 for newly added setters

This revision was automatically updated to reflect the committed changes. Closed by commit R159:91f28c34cf74: Add @since 5.62 for newly added setters (authored by meven). REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23555?vs=64917&id=64924 RE

D23399: Add setter to Type, Activity, Agent and UrlFilter query fields

meven marked 2 inline comments as done. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D23399 To: meven, ivan Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22144: Add kio recentlyused:/ to access KActivityStats data

meven marked 2 inline comments as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham, dfaure Cc: kossebau, broulik, dhaumann, elvisangelaccio, kde-frameworks-devel, kfm-devel, vmarinescu, fprice, LeGast00n, MrPepe, fbamp

D22144: Add kio recentlyused:/ to access KActivityStats data

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > kossebau wrote in CMakeLists.txt:68 > Please add a min version, as the code seems to rely on new API only added > recently: > > find_package(KF5ActivitiesStats 5.62.0 QUIET) See D23556

D23556: Add version requirement to dependency KActivitiesStats

meven created this revision. meven added reviewers: Frameworks, kossebau. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. meven requested review of this revision. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabric

D23399: Add setter to Type, Activity, Agent and UrlFilter query fields

meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > kossebau wrote in query.h:101 > "5.62" of course :) Thanks D23555 REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D23399 To: meven

D23555: Add @since 5.62 for newly added setters

meven created this revision. meven added reviewers: ivan, kossebau. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL https://phabricator.kde.org

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

meven added a comment. This could be an alternative to D17595 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14631 To: emateli, #frameworks, dfaure, mlaurent Cc: meven, anthonyfieroni, chinmoyr, mlaurent, asensi, rkflx, dfaure, aacid

D7446: [Places panel] Revamp the Recently Saved section

meven updated this revision to Diff 64880. meven added a comment. Rebase REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=62380&id=64880 BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kde.org/D7446 AFFECTED FILES src/filewidgets/kfilep

D7446: [Places panel] Revamp the Recently Saved section

meven added a comment. With D22144 landing this is now ready for prime time ! And thanks to D23112 , this will support history from application using gtk as well (firefox, inkscape...) REPOSITORY R241 KIO REVISI

D7446: [Places panel] Revamp the Recently Saved section

meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, anthonyfier

D22144: Add kio recentlyused:/ to access KActivityStats data

This revision was automatically updated to reflect the committed changes. Closed by commit R320:ae44042e541c: Add kio recentlyused:/ to access KActivityStats data (authored by meven). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=64845&id=64879 R

D22144: Add kio recentlyused:/ to access KActivityStats data

meven updated this revision to Diff 64845. meven added a comment. Fix path example REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=64736&id=64845 BRANCH arcpatch-D22144_1 REVISION DETAIL https://phabricator.kde.org/D22144 AFFECTED FILES

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

meven updated this revision to Diff 64816. meven added a comment. Make mapConfig return a const ref REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23523?vs=64815&id=64816 BRANCH arcpatch-D23523 REVISION DETAIL https://phabricator.kde.org/D23523 AFFECTED

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

meven marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23523 To: meven, davidedmundson, dfaure, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

meven created this revision. meven added reviewers: davidedmundson, dfaure, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Inspired by https://github.com/blue-systems/plasma-5.16/issues/1

D22143: Add proper logging using ECMQtDeclareLoggingCategory

This revision was automatically updated to reflect the committed changes. Closed by commit R159:2bb035ff67fd: Add proper logging using ECMQtDeclareLoggingCategory (authored by meven). REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22143?vs=64789

D22144: Add kio recentlyused:/ to access KActivityStats data

meven added a comment. In D22144#520684 , @dfaure wrote: > Yep. Either query argument, or KIO metaData(). Both require explicit action from the application, there's no magic currently to know which app is making the request. We could add that, b

D22143: Add proper logging using ECMQtDeclareLoggingCategory

meven updated this revision to Diff 64789. meven added a comment. Fix plural REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22143?vs=64787&id=64789 BRANCH arcpatch-D22143 REVISION DETAIL https://phabricator.kde.org/D22143 AFFECTED FILE

D22143: Add proper logging using ECMQtDeclareLoggingCategory

meven updated this revision to Diff 64787. meven added a comment. Rebase on master REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22143?vs=64784&id=64787 BRANCH arcpatch-D22143 REVISION DETAIL https://phabricator.kde.org/D22143 AFFECTE

D22144: Add kio recentlyused:/ to access KActivityStats data

meven added a comment. @dfaure A missing piece for this kio slave is to be able to filter to the current app, meaning the app using the slave. I am not sure there is a way to achieve this yet, please correct me if I am wrong, I've looked around but I could have missed something. REPOSITORY

D22144: Add kio recentlyused:/ to access KActivityStats data

meven marked 7 inline comments as done. meven added inline comments. INLINE COMMENTS > dfaure wrote in recentlyused.cpp:91 > I'm confused. Which code from ForwardingSlaveBase is this class benefiting > from? > With internalRewriteUrl returning false all SlaveBase reimplementations in > that cla

D22144: Add kio recentlyused:/ to access KActivityStats data

meven marked 2 inline comments as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham, dfaure Cc: dhaumann, elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, a

D22143: Add proper logging using ECMQtDeclareLoggingCategory

meven updated this revision to Diff 64784. meven added a comment. kactivities-stat-logsettings.h -> kactivities-stats-logsettings.h, KACTIVITY_STAT_LOG -> KACTIVITIE_STATS_LOG REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22143?vs=62695&id=

D22143: Add proper logging using ECMQtDeclareLoggingCategory

meven added a comment. @kossebau what about my last changes ? @ivan I feel this is ok to have `${CMAKE_BINARY_DIR}/src/kactivities-stat-logsettings.cpp` in the test CMakeLists.txt file with the documentation associated with ECMQtDeclareLoggingCategory and my comment, no-one can miss whe

D22144: Add kio recentlyused:/ to access KActivityStats data

meven edited the test plan for this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham, dfaure Cc: dhaumann, elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, MrPepe, fbampalou

D22144: Add kio recentlyused:/ to access KActivityStats data

meven updated this revision to Diff 64736. meven added a comment. Inherit from SlaveBase instead of ForwardingSlaveBase, rename url parameter to path parameter REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=64504&id=64736 BRANCH arcpatch-D22

D23420: Use solid to check if a KFileItem is located on a network mount

meven marked an inline comment as done. meven added a comment. In D23420#519949 , @broulik wrote: > Now we still need the `linkDest` check :) isSlow() didn't check linkDest before. REPOSITORY R241 KIO BRANCH arcpatch-D23420 REVISION

D23420: Use solid to check if a KFileItem is located on a network mount

meven updated this revision to Diff 64716. meven added a comment. Add a const& clean unused variable REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23420?vs=64715&id=64716 BRANCH arcpatch-D23420 REVISION DETAIL https://phabricator.kde.org/D23420 AFFECTED

D23420: Use solid to check if a KFileItem is located on a network mount

meven updated this revision to Diff 64715. meven added a comment. better check file path REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23420?vs=64645&id=64715 BRANCH arcpatch-D23420 REVISION DETAIL https://phabricator.kde.org/D23420 AFFECTED FILES src

D23420: Use solid to check if a KFileItem is located on a network mount

meven marked an inline comment as done. REPOSITORY R241 KIO BRANCH arcpatch-D23420 REVISION DETAIL https://phabricator.kde.org/D23420 To: meven, dfaure, #frameworks Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23420: Use solid to check if a a KFileItem is located on a network mount

meven marked 2 inline comments as done. REPOSITORY R241 KIO BRANCH solid-network-fs-check REVISION DETAIL https://phabricator.kde.org/D23420 To: meven, dfaure, #frameworks Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23420: Use solid to check if a a KFileItem is located on a network mount

meven updated this revision to Diff 64645. meven marked an inline comment as done. meven added a comment. Add a const REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23420?vs=64538&id=64645 BRANCH solid-network-fs-check REVISION DETAIL https://phabricator.

D23420: Use solid to check if a a KFileItem is located on a network mount

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > dfaure wrote in kfileitem.cpp:764 > const & Can't because of Solid::StorageAccess *storageAccess = device.as(); REPOSITORY R241 KIO BRANCH solid-network-fs-check REVISION DETAIL https://phabricator

D23372: Add operator |= for Query Terms

meven abandoned this revision. meven added a comment. Abandoned in favor of D23399 REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D23372 To: meven, ivan Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D23420: Use solid to check if a a KFileItem is located on a network mount

meven marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23420 To: meven, dfaure, #frameworks Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23420: Use solid to check if a a KFileItem is located on a network mount

meven updated this revision to Diff 64538. meven added a comment. Fix logic REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23420?vs=64537&id=64538 BRANCH solid-network-fs-check REVISION DETAIL https://phabricator.kde.org/D23420 AFFECTED FILES src/core/

D23420: Use solid to check if a a KFileItem is located on a network mount

meven created this revision. meven added reviewers: dfaure, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY KFileSystemType uses statvfs syscall that blocks when a network fs mount becomes

D22144: Add kio recentlyused:/ to access KActivityStats data

meven planned changes to this revision. meven added a comment. inherit from SlaveBase instead of ForwardingSlaveBase REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham, dfaure Cc: dhaumann, elvisangelaccio, kde-frameworks-d

D22144: Add kio recentlyused:/ to access KActivityStats data

meven updated this revision to Diff 64504. meven added a comment. Use set*(Term) REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=64454&id=64504 BRANCH arcpatch-D22144_1 REVISION DETAIL https://phabricator.kde.org/D22144 AFFECTED FILES CM

<    7   8   9   10   11   12   13   14   15   16   >