D23399: Add setter to Type, Activity, Agent and UrlFilter query fields

This revision was automatically updated to reflect the committed changes. Closed by commit R159:e67c20ab0f69: Add setter to Type, Activity, Agent and UrlFilter query fields (authored by meven). REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE

D23399: Add setter to Type, Activity, Agent and UrlFilter query fields

meven updated this revision to Diff 64501. meven added a comment. Only have set*(Term), add setter for date REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23399?vs=64475=64501 BRANCH master REVISION DETAIL

D22144: Add kio recentlyused:/ to access KActivityStats data

meven planned changes to this revision. meven added a comment. inherit from SlaveBase instead of ForwardingSlaveBase REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham, dfaure Cc: dhaumann, elvisangelaccio,

D23399: Add setter to Type, Activity, Agent and UrlFilter query fields

meven updated this revision to Diff 64475. meven added a comment. Add QStringList setters REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23399?vs=64474=64475 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23399 AFFECTED

D23399: Add setter to Type, Activity, Agent and UrlFilter query fields

meven created this revision. meven added a reviewer: ivan. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL https://phabricator.kde.org/D23399

D23393: Use special values constants in terms.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit R159:703b81da467c: Use special values constants in terms.cpp (authored by meven). REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23393?vs=64462=64473

D22144: Add kio recentlyused:/ to access KActivityStats data

meven added inline comments. INLINE COMMENTS > ivan wrote in recentlyused.cpp:109 > Also, there are `set*` and `add*` member functions which can be used for > non-chained changes. We don't have yet set function for Activity, Type, Agent, and Url only add. Which means we would need to use

D23393: Use special values constants in terms.cpp

meven created this revision. meven added a reviewer: ivan. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. TEST PLAN Compiles REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL

D23157: Expose technology property in battery interface

meven added a dependent revision: D23392: [energy KCM] Add battery Technology. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23157 To: meven, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22144: Add kio recentlyused:/ to access KActivityStats data

meven marked an inline comment as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham, dfaure Cc: dhaumann, elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas,

D22144: Add kio recentlyused:/ to access KActivityStats data

meven updated this revision to Diff 64454. meven added a comment. Fix ISDATE description REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=64406=64454 BRANCH arcpatch-D22144_1 REVISION DETAIL https://phabricator.kde.org/D22144 AFFECTED

D22144: Add kio recentlyused:/ to access KActivityStats data

meven marked 5 inline comments as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham, dfaure Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, alexde,

D22144: Add kio recentlyused:/ to access KActivityStats data

meven updated this revision to Diff 64406. meven added a comment. Fix date parameter passing REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=64403=64406 BRANCH arcpatch-D22144_1 REVISION DETAIL https://phabricator.kde.org/D22144 AFFECTED

D22144: Add kio recentlyused:/ to access KActivityStats data

meven added inline comments. INLINE COMMENTS > dfaure wrote in CMakeLists.txt:29 > You should also set LIBRARY_OUTPUT_DIRECTORY, see > https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled This will be the first ioslave in kio-extras using it... Some of the ioslave even

D22144: Add kio recentlyused:/ to access KActivityStats data

meven updated this revision to Diff 64403. meven marked 15 inline comments as done. meven added a comment. Fix documentation, CMakeLists.txt, a couple of code fix REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=64347=64403 BRANCH

D23372: Add operator |= for Query Terms

meven added a comment. In D23372#517378 , @ivan wrote: > This is something I did have initally in kastats, it was killed because while this is tempting > > query |= Type(types); > > > it ruins the idea of the chaning API because it

D23372: Add operator |= for Query Terms

meven created this revision. meven added a reviewer: ivan. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY With it, we can now write : query |= Type(types); instead of : query = query |

D22775: Allow date range filtering of resource events using Date Term

This revision was automatically updated to reflect the committed changes. Closed by commit R159:b64cfb3952ee: Allow date range filtering of resource events using Date Term (authored by meven). REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE

D22144: Add kio recentlyused:/ to access KActivityStats data

meven updated this revision to Diff 64347. meven added a comment. Add date and date range filtering after D22775 REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=63829=64347 BRANCH arcpatch-D22144

D23266: Export Plasma core lib log category, add a category to a qWarning

meven added a reviewer: broulik. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23266 To: meven, #frameworks, broulik Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23333: KDirOperator: Only enable "Create New" menu if the selected item is a directory

meven added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D2 To: daandemeyer, #frameworks Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23333: KDirOperator: Only enable "Create New" menu if the selected item is a directory

meven added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D2 To: daandemeyer Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22775: Allow date range filtering of resource events using Date Term

meven added a comment. ping @ivan I guess you are not much available in August. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D22775 To: meven, ivan, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D11554: Add warnings to why some actions might be invalid

meven added inline comments. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. INLINE COMMENTS > kauthaction.cpp:126 > +if (!d->valid) > +qCWarning(KAUTH) << "Backend does not recognize action: " << > name; > } else { Code style, use {} even

D11554: Add warnings to why some actions might be invalid

meven added a reviewer: Frameworks. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D11554 To: carewolf, vkrause, #frameworks Cc: kde-frameworks-devel, meven, LeGast00n, michaelh, ngraham, bruns

D22144: Add kio recentlyused:/ to access KActivityStats data

meven added a comment. I'v added @dfaure as reviewer. David feel free to not review this if you think somebody else would be better suited. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham, dfaure Cc:

D22144: Add kio recentlyused:/ to access KActivityStats data

meven added a reviewer: dfaure. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham, dfaure Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, Codezela,

D5856: Use KDirWatch removeDir/addDir instead of stopDirScan/restartDirScan

meven added a comment. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. ping @dfaure Is it still valid ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5856 To: dfaure, aacid Cc: kde-frameworks-devel, meven, LeGast00n, michaelh,

D22775: Allow date range filtering of resource events using Date Term

meven added a comment. gentle ping @ivan REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D22775 To: meven, ivan, #frameworks Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22144: Add kio recentlyused:/ to access KActivityStats data

meven added a comment. In D22144#514633 , @ivan wrote: > Looks OK to me, I guess some of our resident KIO experts should review it. What do you think? Definitely. Do you have an idea who ? BTW, I have one change planned for this

D23266: Export Plasma core lib log category, add a category to a qWarning

meven added a comment. In D23266#514605 , @apol wrote: > How about porting it to use ecm_qt_declare_logging_category? I don't see what you mean, there are already two build target that uses ecm_qt_declare_logging_category in this repo.

D23266: Export Plasma core lib log category, add a category to a qWarning

meven updated this revision to Diff 64060. meven added a comment. Add Plasma quick lib category, avoid ECM_VERSION check REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23266?vs=64045=64060 BRANCH arcpatch-D23266 REVISION DETAIL

D23267: Fix log categories file

This revision was automatically updated to reflect the committed changes. Closed by commit R120:98d3b607ee35: Fix log categories file (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23267?vs=64049=64050 REVISION DETAIL

D23267: Fix log categories file

meven updated this revision to Diff 64049. meven added a comment. Fix typo REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23267?vs=64047=64049 BRANCH arcpatch-D23267 REVISION DETAIL https://phabricator.kde.org/D23267 AFFECTED FILES

D23267: Fix log categories file

meven updated this revision to Diff 64047. meven added a comment. Do not touch ksmserver line REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23267?vs=64046=64047 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23267 AFFECTED

D23267: Fix log categories file

meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D23267 AFFECTED

D23266: Export Plasma core lib log category, add a category to a qWarning

meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. TEST PLAN Builds, new context for warning is visible REPOSITORY R242 Plasma Framework (Library)

D7446: [Places panel] Revamp the Recently Saved section

meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun,

D7446: [Places panel] Revamp the Recently Saved section

meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun,

D23112: Add a event Spy for GtkFileChooser recent files

meven edited the summary of this revision. REPOSITORY R161 KActivity Manager Service REVISION DETAIL https://phabricator.kde.org/D23112 To: meven, #frameworks, ivan Cc: bruns, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel,

D23112: Add a event Spy for GtkFileChooser recent files

meven edited the summary of this revision. REPOSITORY R161 KActivity Manager Service REVISION DETAIL https://phabricator.kde.org/D23112 To: meven, #frameworks, ivan Cc: bruns, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel,

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

meven added inline comments. INLINE COMMENTS > dfaure wrote in klistopenfiles.cpp:39 > Not possible, due to the removeDuplicates() line. The qAsConst wrapping is missing it seems. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D21760 To: hallas, davidedmundson,

D23214: Add a BlockinApp util class to find process blockng access

meven abandoned this revision. meven added a comment. In D23214#513396 , @hallas wrote: > Hey @meven I have been working on the same thing D21760 - maybe we should consolidate our efforts? The code you have

D23112: Add a event Spy for GtkFileChooser recent files

This revision was automatically updated to reflect the committed changes. Closed by commit R161:acbc21c15622: Add a event Spy for GtkFileChooser recent files (authored by meven). REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE

D23112: Add a event Spy for GtkFileChooser recent files

meven updated this revision to Diff 63913. meven added a comment. Reduce the amount of included code and linked libraries REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63890=63913 BRANCH arcpatch-D23112 REVISION DETAIL

D23214: Add a BlockinApp util class to find process blockng access

meven updated this revision to Diff 63911. meven added a comment. Add copyright REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23214?vs=63910=63911 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23214 AFFECTED FILES

D23214: Add a BlockinApp util class to find process blockng access

meven created this revision. meven added reviewers: davidedmundson, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Uses lsof and kprocesslist to extract names of process blocking on the

D17595: Upstream Dolphin's file rename dialog

meven marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17595 To: meven, #frameworks, #dolphin, broulik, ngraham, dfaure Cc: dfaure, sitter, mitchell, emmanuelp, ltoscano, bruns, meven, dhaumann, pino, kde-frameworks-devel, LeGast00n,

D17595: Upstream Dolphin's file rename dialog

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > dfaure wrote in renamefiledialog.cpp:246 > I see you used the more complicated solution of keeping showEvent and testing > for spontaneous. Any reason? It didn't work from the constructor? After some testing

D17595: Upstream Dolphin's file rename dialog

meven updated this revision to Diff 63895. meven added a comment. Call setFocus() in dialog constructor REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17595?vs=63892=63895 BRANCH arcpatch-D17595 REVISION DETAIL https://phabricator.kde.org/D17595

D17595: Upstream Dolphin's file rename dialog

meven updated this revision to Diff 63892. meven added a comment. Fix dialog where the private class was missing the renamed files items REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17595?vs=63891=63892 BRANCH arcpatch-D17595 REVISION DETAIL

D17595: Upstream Dolphin's file rename dialog

meven marked 6 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17595 To: meven, #frameworks, #dolphin, broulik, ngraham, dfaure Cc: dfaure, sitter, mitchell, emmanuelp, ltoscano, bruns, meven, dhaumann, pino, kde-frameworks-devel, LeGast00n,

D17595: Upstream Dolphin's file rename dialog

meven updated this revision to Diff 63891. meven added a comment. Emit error correctly use name() function of KFileItem REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17595?vs=63854=63891 BRANCH arcpatch-D17595 REVISION DETAIL

D23112: Add a event Spy for GtkFileChooser recent files

meven marked 3 inline comments as done. REPOSITORY R161 KActivity Manager Service REVISION DETAIL https://phabricator.kde.org/D23112 To: meven, #frameworks, ivan Cc: bruns, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D23112: Add a event Spy for GtkFileChooser recent files

meven updated this revision to Diff 63890. meven added a comment. Ensure the log category is exported, compare only chars, variable naming fix REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63830=63890 BRANCH arcpatch-D23112

D17595: Upstream Dolphin's file rename dialog

meven marked 4 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17595 To: meven, #frameworks, #dolphin, broulik, ngraham, dfaure Cc: dfaure, sitter, mitchell, emmanuelp, ltoscano, bruns, meven, dhaumann, pino, kde-frameworks-devel, LeGast00n,

D17595: Upstream Dolphin's file rename dialog

meven marked 4 inline comments as done. meven added a comment. Btw the licensing issue is not resolved yet. I will update the license once this has cleared. INLINE COMMENTS > dfaure wrote in renamefiledialog.cpp:119 > items.first().path() would be simpler and faster. > (that doesn't give

D17595: Upstream Dolphin's file rename dialog

meven updated this revision to Diff 63854. meven marked 14 inline comments as done. meven added a comment. uncrustify file, typo fixes, add error slot REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17595?vs=63796=63854 BRANCH arcpatch-D17595 REVISION

D23112: Add a event Spy for GtkFileChooser recent files

meven updated this revision to Diff 63830. meven added a comment. run uncrustify-kf5 REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63786=63830 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23112 AFFECTED

D22144: Add kio recentlyused:/ to access KActivityStats data

meven updated this revision to Diff 63829. meven added a comment. run uncrustify-kf5 REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=62464=63829 BRANCH arcpatch-D22144 REVISION DETAIL https://phabricator.kde.org/D22144 AFFECTED FILES

D22775: Allow date range filtering of resource events using Date Term

meven added a comment. gentle ping @ivan Waiting for this to move on on D22144 and then D7446 REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D22775 To: meven, ivan,

D17595: Upstream Dolphin's file rename dialog

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > dfaure wrote in renamefiledialog.cpp:60 > Just run `uncrustify-kf5` from the repo kde-dev-scripts. I am very happy to learn about this one. This script cannot work with a single file it seems and most of the

D17595: Upstream Dolphin's file rename dialog

meven updated this revision to Diff 63796. meven added a comment. Group boolean fields together REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17595?vs=62026=63796 BRANCH arcpatch-D17595 REVISION DETAIL https://phabricator.kde.org/D17595 AFFECTED FILES

D23112: Add a event Spy for GtkFileChooser recent files

meven updated this revision to Diff 63786. meven marked 9 inline comments as done. meven added a comment. Remove unnecessary pointer use, code formatting REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63724=63786 BRANCH master

D23157: Expose technology property in battery interface

This revision was automatically updated to reflect the committed changes. Closed by commit R245:eb82729b438f: Expose technology property in battery interface (authored by meven). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23157?vs=63745=63784 REVISION

D23157: Expose technology property in battery interface

meven retitled this revision from "Add technology property to battery interface" to "Expose technology property in battery interface". REPOSITORY R245 Solid BRANCH master REVISION DETAIL https://phabricator.kde.org/D23157 To: meven, #frameworks, broulik Cc: kde-frameworks-devel,

D23157: Add technology property to battery interface

meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REPOSITORY R245 Solid BRANCH master REVISION DETAIL https://phabricator.kde.org/D23157 AFFECTED

D22061: Add a logging category for logs warnings

This revision was automatically updated to reflect the committed changes. Closed by commit R237:403c617eea56: Add a logging category for logs warnings (authored by meven). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22061?vs=63729=63735 REVISION DETAIL

D22061: Add a logging category for logs warnings

meven added a comment. In D22061#511799 , @cgiboudeaux wrote: > ok, please change the remaining kconf/KCONF to kconfig/KCONFIG and it should be fine. Should be good now. Thank you for your feedback. REPOSITORY R237 KConfig

D22061: Add a logging category for logs warnings

meven updated this revision to Diff 63729. meven added a comment. Renamed kconf to kconfig, KCONF to KCONFIG, re-add the mistakenly removed categories file REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22061?vs=62903=63729 BRANCH arcpatch-D22061

D23112: Add a event Spy for GtkFileChooser recent files

meven marked an inline comment as done. REPOSITORY R161 KActivity Manager Service REVISION DETAIL https://phabricator.kde.org/D23112 To: meven, #frameworks, ivan Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D23112: Add a event Spy for GtkFileChooser recent files

meven marked an inline comment as done. meven added a comment. In D23112#511779 , @ngraham wrote: > Cool stuff. Does it handle duplicates when a file is present in both GTKFileChooserRecent and KActivitiesStats? Yes, the file url is a

D23112: Add a event Spy for GtkFileChooser recent files

meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > ngraham wrote in kactivitymanagerd-plugin-gtk-eventspy.json:41 > Not sure you need to add translations of your own name here This was done for Ivan so I guess the translation team fills this. REPOSITORY

D23112: Add a event Spy for GtkFileChooser recent files

meven updated this revision to Diff 63724. meven added a comment. grammar REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63713=63724 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23112 AFFECTED FILES

D23112: Add a event Spy for GtkFileChooser recent files

meven marked 2 inline comments as done. REPOSITORY R161 KActivity Manager Service REVISION DETAIL https://phabricator.kde.org/D23112 To: meven, #frameworks, ivan Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf,

D23112: Add a event Spy for GtkFileChooser recent files

meven marked 5 inline comments as done. meven added inline comments. INLINE COMMENTS > ivan wrote in GtkEventSpy.cpp:143 > Let's hope commands will never have spaces in them :) It is to just extract the executable name, we don't want to have an exploding number of initiatingAgent for every

D23112: Add a event Spy for GtkFileChooser recent files

meven updated this revision to Diff 63713. meven added a comment. Add const where need be, simplify KTrader query REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63669=63713 BRANCH master REVISION DETAIL

D23112: Add a event Spy for GtkFileChooser recent files

meven added a comment. In D23112#511354 , @ivan wrote: > Thanks for geting involved this much! :D REPOSITORY R161 KActivity Manager Service REVISION DETAIL https://phabricator.kde.org/D23112 To: meven, #frameworks, ivan Cc:

D23112: Add a event Spy for GtkFileChooser recent files

meven updated this revision to Diff 63669. meven added a comment. Add a logging category REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63654=63669 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23112 AFFECTED

D23112: Add a event Spy for GtkFileChooser recent files

meven updated this revision to Diff 63654. meven added a comment. Readd include QDebug used by qWarning REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63647=63654 BRANCH master REVISION DETAIL

D23112: Add a event Spy for GtkFileChooser recent files

meven updated this revision to Diff 63647. meven marked an inline comment as done. meven added a comment. Remove unused include REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63641=63647 BRANCH master REVISION DETAIL

D23112: Add a event Spy for GtkFileChooser recent files

meven updated this revision to Diff 63641. meven added a comment. Use KServiceTypeTrader to look for apps being used REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63603=63641 BRANCH master REVISION DETAIL

D23112: Add a event Spy for GtkFileChooser recent files

meven added a comment. In D23112#510798 , @broulik wrote: > Can you check out the `KBookmarks` framework which has classes for processing xbel files Thanks for pointing it out. I just did, and It does not seem to cover my use case here

D23112: Add a event Spy for GtkFileChooser recent files

meven created this revision. meven added reviewers: Frameworks, ivan. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY GtkFileChooser/GtkRecentManager follows

D7446: [Places panel] Revamp the Recently Saved section

meven added a comment. In D7446#505870 , @ngraham wrote:ut I am all ears for inputs. > Right now by default we only show two: "today" and "last month". We should probably keep it at that, at most; my sense is that even these are very

D22775: Allow date range filtering of resource events using Date Term

meven added a comment. gentle ping @ivan REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D22775 To: meven, ivan, #frameworks Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22143: Add proper logging using ECMQtDeclareLoggingCategory

meven added a comment. In D22143#502476 , @meven wrote: > In D22143#502336 , @kossebau wrote: > > > In D22143#502314 , @meven wrote: > > > > > >

D22763: [KDirOperator] Use more human-readable sort order descriptions

This revision was automatically updated to reflect the committed changes. Closed by commit R241:10b6d83bbc4c: [KDirOperator] Use more human-readable sort order descriptions (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22763?vs=62711=63122

D22763: [KDirOperator] Use more human-readable sort order descriptions

meven added a comment. I will merge this beginning of next week, if no one objects. REPOSITORY R241 KIO BRANCH arcpatch-D22763 REVISION DETAIL https://phabricator.kde.org/D22763 To: meven, ngraham, #frameworks, nicolasfella Cc: churaev, kde-frameworks-devel, LeGast00n, sbergeron,

D22061: Add a logging category for logs warnings

meven marked 2 inline comments as done. meven added a comment. I have opted for the file name kconfig_core_log_settings.h for the log settings header file. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D22061 To: meven, #frameworks, apol Cc: cgiboudeaux,

D22061: Add a logging category for logs warnings

meven updated this revision to Diff 62903. meven added a comment. Rename kconf_desktop_debug.h to more appropriate kconfig_core_log_settings.h, do not run an unnecessary install REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22061?vs=61897=62903 BRANCH

D22061: Add a logging category for logs warnings

meven added a reviewer: apol. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D22061 To: meven, #frameworks, apol Cc: mikeroyal, apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D7446: [Places panel] Revamp the Recently Saved section

meven added a comment. I am working on allow to filter by resource activity date D22717 and D22775 (I will add this soonish into recentlyused:/ ioslave D22144 ) This will

D22763: [KDirOperator] Use more human-readable sort order descriptions

meven updated this revision to Diff 62711. meven added a comment. Capitalize as by https://hig.kde.org/style/writing/capitalization.html REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22763?vs=62628=62711 BRANCH arcpatch-D22763 REVISION DETAIL

D22763: [KDirOperator] Use more human-readable sort order descriptions

meven added a comment. In D22763#503074 , @churaev wrote: > Shouldn't it be "Newest First" instead of "Newest first", to be consistent with other menu items (i.e. "Folders First", etc.)? Now that you mention it, I think so. I took the

D22143: Add proper logging using ECMQtDeclareLoggingCategory

meven updated this revision to Diff 62695. meven added a comment. Add comment regarding the origin of a generated cpp file REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22143?vs=62526=62695 BRANCH arcpatch-D22143 REVISION DETAIL

D19784: Avoid calling QT_LSTAT and accessing recent documents

meven added a comment. In D19784#503066 , @dfaure wrote: > See KFileItem::isSlow() Interesting but the initial issue happened when a drive is not mounted and isSlow implementation uses statfs that gives information about ... mounted

D22763: [KDirOperator] Use more human-readable sort order descriptions

meven marked 2 inline comments as done. REPOSITORY R241 KIO BRANCH arcpatch-D22763 REVISION DETAIL https://phabricator.kde.org/D22763 To: meven, ngraham, #frameworks, nicolasfella Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22763: [KDirOperator] Use more human-readable sort order descriptions

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > ngraham wrote in kdiroperator.cpp:1992 > Why change this? kdiroperator should definitely be ported to use the new > connect syntax, but it should be done all at once in its own patch, not one > at a time.

D22775: Allow date range filtering of resource events using Date Term

meven created this revision. meven added reviewers: ivan, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Followup after D22717 To be used in D22144

<    8   9   10   11   12   13   14   15   16   17   >