maltek added a reviewer: adridg.
maltek added a comment.
I have no idea who to specify as reviewer, so I'm picking the maintainer from
`src/README`, Adriaan de Groot.
REPOSITORY
R299 KDESu
REVISION DETAIL
https://phabricator.kde.org/D23692
To: maltek, adridg
Cc: kde-frameworks-devel, Le
maltek created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
maltek requested review of this revision.
REVISION SUMMARY
So I noticed that kdesu is setgid 'nogroup'. That group is the fallback for
groups from a remote NFS share that do not ex
maltek accepted this revision.
maltek added a comment.
This revision is now accepted and ready to land.
Looks good to me now!
REPOSITORY
R241 KIO
BRANCH
arcpatch-D14467
REVISION DETAIL
https://phabricator.kde.org/D14467
To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dol
maltek added inline comments.
INLINE COMMENTS
> chinmoyr wrote in filehelper.cpp:133
> Ah! Since I was testing inside /opt I didn't notice. I think the order here
> should be: drop privilege -> change grp -> gain privilege -> change user.
IMO, it's fine (and less complicated) to just do both in
maltek requested changes to this revision.
maltek added a comment.
This revision now requires changes to proceed.
I noticed a few more things on the second read.
INLINE COMMENTS
> filehelper.cpp:123
> +const QByteArray baseName = basename(tempPath2.data());
> +int parent_fd = open(par
maltek requested changes to this revision.
maltek added a comment.
This revision now requires changes to proceed.
I've gone over the code and found some issues. I haven't fully thought
through the design on a conceptual level, because I assume Matthias already did.
INLINE COMMENTS
> filehelp
