mthw added a comment.
@davidedmundson I hoped this could make it into 5.71 or is it too late now?
REPOSITORY
R297 KDED
REVISION DETAIL
https://phabricator.kde.org/D29815
To: mthw, #frameworks, davidedmundson
Cc: anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh,
mthw added a comment.
Do I need to change anything or is this acceptable?
REPOSITORY
R297 KDED
REVISION DETAIL
https://phabricator.kde.org/D29815
To: mthw, #frameworks, davidedmundson
Cc: anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh,
ngraham, bruns
mthw added a comment.
@davidedmundson What do you think about this patch?
REPOSITORY
R297 KDED
REVISION DETAIL
https://phabricator.kde.org/D29815
To: mthw, #frameworks, davidedmundson
Cc: anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh,
ngraham, bruns
mthw added a comment.
This patch also fixes buttons in kded dialogs like the wifi password dialog.
REPOSITORY
R297 KDED
REVISION DETAIL
https://phabricator.kde.org/D29815
To: mthw, #frameworks, zzag
Cc: anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh,
ngraham,
mthw added a comment.
I don't know enough about kded to answer your question. I just know this
fixes the issue and it works fine with other apps, which may or may not be
relevant.
REPOSITORY
R297 KDED
REVISION DETAIL
https://phabricator.kde.org/D29815
To: mthw, #frameworks
Cc: broulik,
mthw added a reviewer: Frameworks.
REPOSITORY
R297 KDED
REVISION DETAIL
https://phabricator.kde.org/D29815
To: mthw, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
mthw created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mthw requested review of this revision.
REVISION SUMMARY
When using fractional scaling, icons in titlebar appmenu are blurred in all
apps. This patch fixes the issue.
TEST PLAN
No
mthw abandoned this revision.
mthw added a comment.
I don't have the time (nor skill really) to work on this. Feel free to take
over if you want to.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D23926
To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino
Cc: mev
mthw updated this revision to Diff 77450.
mthw added a comment.
Sorry about that, I should have checked waht I am sending.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23926?vs=77445&id=77450
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D23
mthw updated this revision to Diff 77445.
mthw added a comment.
I don't really know how to do a rebase propertly so I hope I managed to do
the same manually.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23926?vs=77388&id=77445
BRANCH
master
REVISION DETA
mthw updated this revision to Diff 77388.
mthw added a comment.
- Made recomemded changes
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23926?vs=66003&id=77388
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D23926
AFFECTED FILES
src/widgets
mthw added a comment.
@meven So, the first version of this diff is good enough?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D23926
To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino
Cc: meven, ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel,
mthw updated this revision to Diff 75443.
mthw added a comment.
Name should be correct now.
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27247?vs=75434&id=75443
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D27247
AFFECTED FILES
mthw updated this revision to Diff 75434.
mthw added a comment.
Changed git name, nothing else
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27247?vs=75406&id=75434
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D27247
AFFECTED FILES
mthw added a comment.
@ndavis I've set my name, do I need to "arc diff" again or something else?
REPOSITORY
R266 Breeze Icons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D27247
To: mthw, #vdg, #plasma, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n,
mthw added a comment.
Since you accepted, can you also commit this, please?
REPOSITORY
R266 Breeze Icons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D27247
To: mthw, #vdg, #plasma, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michae
mthw updated this revision to Diff 75406.
mthw added a comment.
Fixed
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27247?vs=75389&id=75406
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D27247
AFFECTED FILES
icons-dark/actions/16/
mthw updated this revision to Diff 75389.
mthw added a comment.
Changes to "font-disable" and "mail-mark-junk" are now included too.
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27247?vs=75334&id=75389
BRANCH
master
REVISION DETAIL
https://phab
mthw added a comment.
I also made adjustments to "font-disable" and "mail-mark-junk", do you want
me to include them? After that all icons containing 🚫 will be the same.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D27247
To: mthw, #vdg, #plasma, ngraham
Cc:
mthw retitled this revision from "Rotate the "no symbol" for "mic muted" so it
looks the same as "speakers muted"" to "Unify the look of all icons containing
🚫 (no sign)".
mthw edited the summary of this revision.
mthw edited the test plan for this revision.
REPOSITORY
R266 Breeze Icons
REVI
mthw updated this revision to Diff 75334.
mthw added a comment.
Also made changes to "audio-volume-muted"
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27247?vs=75302&id=75334
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D27247
AFF
mthw updated this revision to Diff 75302.
mthw added a comment.
color="" removed, also version removed as it wasn't there before. Anything
else?
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27247?vs=75294&id=75302
BRANCH
master
REVISION DETAIL
mthw updated this revision to Diff 75294.
mthw edited the summary of this revision.
mthw added a comment.
Work in progress, making recomended changes
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27247?vs=75251&id=75294
BRANCH
master
REVISION DETA
mthw edited the summary of this revision.
mthw edited the test plan for this revision.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D27247
To: mthw, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
mthw edited the summary of this revision.
mthw edited the test plan for this revision.
mthw added reviewers: VDG, Plasma.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D27247
To: mthw, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngrah
mthw updated this revision to Diff 75251.
mthw added a comment.
Also change Dark icons
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27247?vs=75250&id=75251
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D27247
AFFECTED FILES
icons
mthw created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mthw requested review of this revision.
REPOSITORY
R266 Breeze Icons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D27247
AFFECTED FILES
icons/status/16/microphon
mthw added a comment.
Any progress on this?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D23926
To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino
Cc: ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio,
fprice, LeGast00n, cblack, konki
mthw added a comment.
> 3. Instead of unconditionally doing `q->insertPluginAt(plugin, 1);`, you'd
want to do something more like this:
>
>
>
> if (plugin == "details" /* this is pseudocode */) {
> q->insertPluginAt(plugin, 1);
> } else {
> q->insertPlugin(plu
mthw updated this revision to Diff 66003.
mthw added a comment.
Don't move the commented-out code, better description in header, formatting.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23926?vs=65988&id=66003
BRANCH
master
REVISION DETAIL
https://phabr
mthw updated this revision to Diff 65988.
mthw added a comment.
Changes made, if clause still not there
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23926?vs=65986&id=65988
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D23926
AFFECTED FILES
mthw added a comment.
I didn't know what to do with this
> ...check to see if the plugin we've just created is the Details plugin,...
Also the "Generator" should probably go back where it was right?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D23926
To: mthw
mthw updated this revision to Diff 65986.
mthw added a comment.
Do you mean something like this? Only a wild guess, C lang is not my strength.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23926?vs=65977&id=65986
BRANCH
master
REVISION DETAIL
https://pha
mthw edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D23926
To: mthw, #dolphin
Cc: kde-frameworks-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas,
alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales,
firef
mthw edited the summary of this revision.
mthw added a reviewer: Dolphin.
mthw added a project: Dolphin.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D23926
To: mthw, #dolphin
Cc: kde-frameworks-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas,
alexde, GB_2, Codez
mthw created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mthw requested review of this revision.
REVISION SUMMARY
This change moves the "Details" tab to second place because it makes more
sense. //more later
REPOSITORY
R241 KIO
BRANCH
36 matches
Mail list logo