and it solves the issue, keyboard shortcuts
work just fine and annoying error message is no more.
Thanks,
Mladen Milinkovic
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/kactioncollection.cpp 9c45725
src/kxmlguifactory.cpp a4305a4
Diff: https://git.reviewboard.kde.org/r/123601/diff/
Testing
---
Tested most of KDE applications and it solves the issue, keyboard shortcuts
work just fine and annoying error message is no more.
Thanks,
Mladen Milinkovic
maxrd2 created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
maxrd2 requested review of this revision.
REVISION SUMMARY
BUG: 395988
In certain cases KMainWindow::saveMainWindowSettings() could have been
cal
maxrd2 updated this revision to Diff 36938.
maxrd2 added a comment.
Cleaned up indentation.
REPOSITORY
R263 KXmlGui
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13808?vs=36937&id=36938
BRANCH
fix-window-state-save
REVISION DETAIL
https://phabricator.kde.org/D13808
AFFECTE
maxrd2 added a comment.
Relative bug is here https://bugs.kde.org/show_bug.cgi?id=395988
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D13808
To: maxrd2
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
maxrd2 added a comment.
The change in qt affects when the window close event is handled in queue, it
didn't change when it is fired. With qt 5.11.1 child widgets get destroyed a
bit sooner, but it's still gets triggered by same close event - i think that
stayed like it always was.
Also KMa
maxrd2 updated this revision to Diff 36973.
maxrd2 added a comment.
Added unit test
REPOSITORY
R263 KXmlGui
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13808?vs=36938&id=36973
BRANCH
fix-window-state-save
REVISION DETAIL
https://phabricator.kde.org/D13808
AFFECTED FILES
maxrd2 added a comment.
Unit test is there... and it passes... always... with or without the
kmainwindow.cpp patch :-/
Is there some simpler way to initialize/kill QApplication for each mainwindow
creation/deletion, other than adding new test that uses QTEST_APPLESS_MAIN
instead of QTEST_M
maxrd2 added a comment.
QTEST_MAIN already provides Application and event loop
REPOSITORY
R263 KXmlGui
BRANCH
fix-window-state-save
REVISION DETAIL
https://phabricator.kde.org/D13808
To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck
Cc: wbauer, aacid, ngraham, kde
maxrd2 added a comment.
Have tried doing QApplication::processEvents() and
QApplication::sendPostedEvents(), between main window instances... didnt change
Have removed mw.close() and clicked close buttons manually... didnt change
Then have started all three in separate process using QProce
maxrd2 updated this revision to Diff 37131.
maxrd2 added a comment.
Added event loop to test and replicated wanted KMainWindow behavior.
REPOSITORY
R263 KXmlGui
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13808?vs=36973&id=37131
BRANCH
fix-window-state-save
REVISION DETAIL
maxrd2 added a comment.
Thank you! QEventLoop and creating window with new operator did it. Now the
only problem is that no matter how i close the window from code it's not
reproducing behavior. Only closing the window manually through window manager
works.
Have tried:
QApplication::post
maxrd2 added a comment.
Relative Qt Bug is here: https://bugreports.qt.io/browse/QTBUG-69277
Seems it's not their bug. And Qt guy commented there with:
> ... You should, however, not save the window layout anymore then, because
after closeEvent() any other widgets or child windows could
maxrd2 added inline comments.
INLINE COMMENTS
> broulik wrote in kmainwindow_unittest.cpp:267
> `mw->deleteLater()`?
tried it too... will retry all of them again with isHidden()
> broulik wrote in kmainwindow_unittest.cpp:278
> `QCOMPARE(mw->m-dock->isVisible(), true)`
mmm.. sorry i was suppos
maxrd2 updated this revision to Diff 37211.
maxrd2 added a comment.
Clened up test code. Replaced isVisible() with isHidden() test to match
KMainWindow's condition.
REPOSITORY
R263 KXmlGui
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13808?vs=37131&id=37211
BRANCH
fix-window
maxrd2 added inline comments.
INLINE COMMENTS
> broulik wrote in kmainwindow_unittest.cpp:267
> `mw->deleteLater()`?
Retried with all of these... none of them causes the failure, only closing the
window manually cause it
QApplication::postEvent(mw, new QDeferredDeleteEvent); // qpa/window ma
maxrd2 added a comment.
@ngraham Don't think I can. I have no commit rights.
Should i revert/remove test part, as currently it doesn't test anything i
believe.. it always passes.
REPOSITORY
R263 KXmlGui
BRANCH
fix-window-state-save
REVISION DETAIL
https://phabricator.kde.org/D13808
maxrd2 updated this revision to Diff 37950.
maxrd2 added a comment.
Rebased to master
REPOSITORY
R263 KXmlGui
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13808?vs=37211&id=37950
BRANCH
fix-window-state-save
REVISION DETAIL
https://phabricator.kde.org/D13808
AFFECTED FILE
maxrd2 added a comment.
@dfaure great.. thanks
INLINE COMMENTS
> anthonyfieroni wrote in kmainwindow_unittest.cpp:267
> mw->setAttribute(Qt::WA_DeleteOnClose);
> Then post event close or deleteLater should work
KMainWindowPrivate::init() which is called from constructor already does
setAttr
maxrd2 added a comment.
Events from the window system seem to be handled after normal events.
http://code.qt.io/cgit/qt/qtbase.git/tree/src/platformsupport/eventdispatchers/qeventdispatcher_glib.cpp#n70
Is there a way to send the event so qt processes it as window system event?
Have tried
maxrd2 updated this revision to Diff 19134.
maxrd2 edited the summary of this revision.
maxrd2 added a comment.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
Added KRun::openService() method
REPOSITORY
R296 KDeclarative
CHANGES SI
maxrd2 updated this revision to Diff 19136.
maxrd2 added a comment.
Plasmoid uses KRun::openService() to launch ksysguard
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7648?vs=19134&id=19136
BRANCH
launch-change
REVISION DETAIL
https://phabrica
maxrd2 created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Added openService() method to KRunProxy so plasmoids can start applications
without needing to use openUrl() and "apps" data source.
REPOSIT
maxrd2 added a reviewer: davidedmundson.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D7676
To: maxrd2, davidedmundson
Cc: #frameworks
maxrd2 added a comment.
There it goes... updated the qml and added KRunProxy changes here:
https://phabricator.kde.org/D7676
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D7648
To: maxrd2, #plasma
Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, progwo
maxrd2 updated this revision to Diff 19138.
maxrd2 added a comment.
Replaced runService() call with runApplication()
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7676?vs=19137&id=19138
BRANCH
runproxy_openservice
REVISION DETAIL
https://phabric
maxrd2 added a comment.
Am not sure whether if( && service->isApplication()) is needed.
While I'm at it should i replace runService() with runApplication() inside
inside openUrl() method?
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D7676
To: maxrd2,
maxrd2 added a dependent revision: D7648: Fix ksysguard not starting on
plasmoid click.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D7676
To: maxrd2, davidedmundson
Cc: broulik, #frameworks
maxrd2 added a dependency: D7676: Added openService() method to KRunProxy.
REPOSITORY
R114 Plasma Addons
BRANCH
launch-change
REVISION DETAIL
https://phabricator.kde.org/D7648
To: maxrd2, #plasma, davidedmundson
Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai
maxrd2 added inline comments.
INLINE COMMENTS
> krunproxy.cpp:48
> KService::Ptr service = KService::serviceByDesktopPath(filePath);
> return KRun::runService(*service, QList(), nullptr) != 0;
> } else {
While I'm at it should i also change to runApplication() here?
> kru
maxrd2 added a comment.
I don't have full developer account so i can't land this one. It also needs
https://phabricator.kde.org/D7676 for this to work.
REPOSITORY
R114 Plasma Addons
BRANCH
launch-change
REVISION DETAIL
https://phabricator.kde.org/D7648
To: maxrd2, #plasma, davidedmun
maxrd2 updated this revision to Diff 19173.
maxrd2 marked an inline comment as done.
maxrd2 added a comment.
Removed service->isApplication() check, improved method description.
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7676?vs=19138&id=19173
BRA
maxrd2 added a comment.
In https://phabricator.kde.org/D7676#143033, @broulik wrote:
> Well it is now "openService" calling "runApplication", that's inconsistent
isn't it
Yes, but it will start services that have Exec line though.
Should i just rename the method to "openApplicat
maxrd2 added a comment.
In https://phabricator.kde.org/D7648#142638, @davidedmundson wrote:
> Thanks, but do you know why the apps datasource doesn't have that entry
after a while?
I've managed to get some more insight into original problem.
It seems that after some system updat
34 matches
Mail list logo
