D27705: Use QStringLiteral

nicolasfella updated this revision to Diff 76565. nicolasfella added a comment. Remove unintended changes REPOSITORY R155 KAccounts Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27705?vs=76563=76565 BRANCH arcpatch-D27705 REVISION DETAIL

D27705: Use QStringLiteral

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, bshah, leinir. nicolasfella requested review of this revision. REVISION SUMMARY Don't use naked strings TEST PLAN builds REPOSITORY R155 KAccounts Integration BRANCH qsl REVISION DETAIL

D27704: Drop FindAccountsFileDir.cmake

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, bshah, leinir. nicolasfella requested review of this revision. REVISION SUMMARY no one is using it REPOSITORY R155 KAccounts Integration BRANCH cma REVISION DETAIL https://phabricator.kde.org/D27704 AFFECTED

D27635: Restore kio-webdav plugin

nicolasfella edited the summary of this revision. REPOSITORY R155 KAccounts Integration REVISION DETAIL https://phabricator.kde.org/D27635 To: nicolasfella, bshah, leinir, #frameworks

D23339: Fix memory leak in ConfigView and Dialog

nicolasfella added a comment. This makes plasmashell crash for me as soon as a notification appears. https://invent.kde.org/snippets/730 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23339 To: dvratil, #plasma, #frameworks, apol,

D27662: Rewrite nextcloud plugin

nicolasfella updated this revision to Diff 76421. nicolasfella added a comment. - Remove debug REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27662?vs=76420=76421 BRANCH nextcloud REVISION DETAIL https://phabricator.kde.org/D27662 AFFECTED

D27662: Rewrite nextcloud plugin

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, apol, bshah. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Let CopyJob and the webdav KIO slave do the hard work.

D27635: Restore kio-webdav plugin

nicolasfella updated this revision to Diff 76416. nicolasfella added a comment. - Simplify REPOSITORY R155 KAccounts Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27635?vs=76413=76416 BRANCH restore REVISION DETAIL https://phabricator.kde.org/D27635 AFFECTED

D27635: Restore kio-webdav plugin

nicolasfella updated this revision to Diff 76413. nicolasfella added a comment. - Adapt path REPOSITORY R155 KAccounts Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27635?vs=76328=76413 BRANCH restore REVISION DETAIL https://phabricator.kde.org/D27635 AFFECTED

D27637: kill twitter support

This revision was automatically updated to reflect the committed changes. Closed by commit R495:13f9f45f2cce: kill twitter support (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27637?vs=76334=76399 REVISION DETAIL

D27633: Port to KPluginLoader

This revision was automatically updated to reflect the committed changes. Closed by commit R155:27487ab9276c: Port to KPluginLoader (authored by nicolasfella). REPOSITORY R155 KAccounts Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27633?vs=76326=76335 REVISION DETAIL

D27637: kill twitter support

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, apol, bshah. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Twitter support in KAccounts has been reportedly

D27633: Port to KPluginLoader

nicolasfella added reviewers: leinir, Frameworks. REPOSITORY R155 KAccounts Integration REVISION DETAIL https://phabricator.kde.org/D27633 To: nicolasfella, bshah, leinir, #frameworks

D27635: Restore kio-webdav plugin

nicolasfella added a reviewer: Frameworks. REPOSITORY R155 KAccounts Integration REVISION DETAIL https://phabricator.kde.org/D27635 To: nicolasfella, bshah, leinir, #frameworks

D27573: Fix issue finding the Boost include directories

This revision was automatically updated to reflect the committed changes. Closed by commit R6:53d8ae317c6c: Fix issue finding the Boost include directories (authored by dalbers, committed by nicolasfella). REPOSITORY R6 KActivities CHANGES SINCE LAST UPDATE

D27573: Fix issue finding the Boost include directories

nicolasfella accepted this revision. nicolasfella added a comment. This revision is now accepted and ready to land. Thanks! Can you please give me your email address so I can merge this with the correct authorship information? REPOSITORY R6 KActivities REVISION DETAIL

D27562: [kcmcontrols] Respect header/footer visibility

nicolasfella edited the summary of this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27562 To: nicolasfella, #plasma, mart Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27562: [kcmcontrols] Respect header/footer visibility

nicolasfella retitled this revision from "[scrollviewkcm] Respect header/footer visibility" to "[kcmcontrols] Respect header/footer visibility". REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27562 To: nicolasfella, #plasma, mart Cc: kde-frameworks-devel,

D27562: [kcmcontrols] Respect header/footer visibility

nicolasfella edited the summary of this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27562 To: nicolasfella, #plasma, mart Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27562: [scrollviewkcm] Respect header/footer visibility

nicolasfella updated this revision to Diff 76136. nicolasfella added a comment. - Do same for GridViewKCM REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27562?vs=76135=76136 BRANCH rhv REVISION DETAIL https://phabricator.kde.org/D27562 AFFECTED

D27562: [scrollviewkcm] Respect header/footer visibility

nicolasfella created this revision. nicolasfella added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Same as 1270e357a96f1e78281c0335b1bd05e5c9c3e3c6

D27528: Adapt action numbering in Android to work like in KNotifications

nicolasfella added a comment. To apply the changes made in the web interface to your local commit you use `arc amend` I think. To upload new changes you do `arc diff --update D27528` > Once the diff is landed, it will be commited with the email address you set up in your KDE

D27552: Have kai the knotifications maintainer

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D27552 To: apol, #frameworks, broulik, nicolasfella Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27528: Adapt action numbering in Android to work like in KNotifications

nicolasfella added a comment. Thanks for the patch, makes sense. Please make the commit message a bit more elaborate REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D27528 To: cacahueto, #frameworks, nicolasfella, vkrause Cc: kde-frameworks-devel,

D26769: Always strip html if server does not support it

This revision was automatically updated to reflect the committed changes. Closed by commit R289:994f88929a83: Always strip html if server does not support it (authored by nicolasfella). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE

D26918: Improve KNotification API docs

nicolasfella added a task: T12709: Improvements for KNotifications documentation/guidelines. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26918 To: nicolasfella, #frameworks, broulik, jucato Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D26918: Improve KNotification API docs

nicolasfella updated this revision to Diff 75799. nicolasfella added a comment. - Move most content to main page REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26918?vs=75795=75799 BRANCH docs REVISION DETAIL https://phabricator.kde.org/D26918

D26918: Improve KNotification API docs

nicolasfella added inline comments. INLINE COMMENTS > apol wrote in knotification.h:58 > It could make sense to specify the cmake syntax to do that? > > `install(FILES appname.notifyrc DESTINATION ${KNOTIFYRC_INSTALL_DIR})` Don't we have that already below? REPOSITORY R289 KNotifications

D26918: Improve KNotification API docs

nicolasfella updated this revision to Diff 75795. nicolasfella added a comment. O - Add a dedicated main page and link to the HIG from there REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26918?vs=74362=75795 BRANCH docs REVISION DETAIL

D26918: Improve KNotification API docs

nicolasfella added inline comments. INLINE COMMENTS > apol wrote in knotification.h:44 > This entirely changes the semantics. Might still be correct but it could make > sense to make sure that's the case? > At least, for an action the user triggers should still be a feedback event, > right? I

D27434: Improve readme

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Add a basic description including the supported platforms,

D26918: Improve KNotification API docs

nicolasfella added a comment. Ping? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26918 To: nicolasfella, #frameworks, broulik, jucato Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27385: [RFC] Return error instead of aborting when receiving an unexpected answer

nicolasfella edited reviewers, added: Frameworks, dfaure, meven; removed: kiokiio. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27385 To: fifr, #frameworks, dfaure, meven, kiokiio Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27239: [android] Emit defaultActivated when tapping the notification

This revision was automatically updated to reflect the committed changes. Closed by commit R289:0a0efe39f898: [android] Emit defaultActivated when tapping the notification (authored by nicolasfella). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE

D27239: [android] Emit defaultActivated when tapping the notification

nicolasfella updated this revision to Diff 75264. nicolasfella added a comment. - set correct flags REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27239?vs=75242=75264 BRANCH defa REVISION DETAIL https://phabricator.kde.org/D27239 AFFECTED

D27239: [android] Emit defaultActivated when tapping the notification

nicolasfella updated this revision to Diff 75242. nicolasfella added a comment. - broadcast correctly REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27239?vs=75234=75242 BRANCH defa REVISION DETAIL https://phabricator.kde.org/D27239 AFFECTED

D27239: [android] Emit defaultActivated when tapping the notification

nicolasfella edited the test plan for this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D27239 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27239: [android] Emit defaultActivated when tapping the notification

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY When the user taps a notification the corresponding activity is

D27210: add KDEconnect Icons

nicolasfella added a comment. Screenshot please REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27210 To: mbruchert Cc: nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27200: Make the attached property a simple QObject

nicolasfella retitled this revision from "Make the attached proeprty a simple QObject" to "Make the attached property a simple QObject". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27200 To: mart, bshah, #plasma Cc: kde-frameworks-devel,

D27187: update travel-family icons

nicolasfella edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27187 To: mbruchert, #vdg, ndavis Cc: ngraham, nicolasfella, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D27187: update travel-family icons

nicolasfella added a comment. Please add some screenshots REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27187 To: mbruchert, #vdg, ndavis Cc: nicolasfella, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26855: Add icon for KTrip

nicolasfella abandoned this revision. nicolasfella added a subscriber: jriddell. nicolasfella added a comment. @jriddell added the icon already REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26855 To: nicolasfella, #breeze, ndavis Cc: jriddell,

D26918: Improve KNotification API docs

nicolasfella added a reviewer: jucato. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26918 To: nicolasfella, #frameworks, broulik, jucato Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26918: Improve KNotification API docs

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Various improvements. Better examples, updated coding

D25798: Deprecated allowAsDefault

This revision was automatically updated to reflect the committed changes. Closed by commit R309:f45bfd1c9fc0: Deprecated allowAsDefault (authored by nicolasfella). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25798?vs=73672=74282 REVISION DETAIL

D26771: Add new signal for default action activation

This revision was automatically updated to reflect the committed changes. Closed by commit R289:a2c88d21d9b7: Add new signal for default action activation (authored by nicolasfella). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26771?vs=73893=74281

D26855: Add icon for KTrip

nicolasfella added reviewers: Breeze, ndavis. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26855 To: nicolasfella, #breeze, ndavis Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26855: Add icon for KTrip

nicolasfella created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY The icon itself is not new, it has been shipped in the ktrip repo already. To include KTrip in

D26815: Fix python bindings build after ebd14f29f8052ff5119bf97b42e61f404f223615

nicolasfella accepted this revision. nicolasfella added a comment. This revision is now accepted and ready to land. looks sensible, but I haven't tried it myself REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26815 To: arojas, nicolasfella, dfaure Cc:

D26677: Port away from KLineEdit and KComboBox to Q equivalent

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R305 KNotifyConfig BRANCH port_to_q_ui (branched from master) REVISION DETAIL https://phabricator.kde.org/D26677 To: gassaf, #frameworks, nicolasfella Cc: kde-frameworks-devel, LeGast00n,

D25798: Deprecated allowAsDefault

nicolasfella added a reviewer: dfaure. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D25798 To: nicolasfella, #frameworks, dfaure Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26771: Add new signal for default action activation

nicolasfella updated this revision to Diff 73893. nicolasfella added a comment. - Actually emit it REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26771?vs=73891=73893 BRANCH default REVISION DETAIL https://phabricator.kde.org/D26771 AFFECTED

D26771: Add new signal for default action activation

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY activated is an overloaded signal. Add a new signal to

D26769: Always strip html if server does not support it

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY The spec does not say that text containing markup has to

D26756: Strip richtext on Windows, simplify how rich teyt is stripped in KPassivePopup

nicolasfella accepted this revision. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D26756 To: vonreth, broulik, brute4s99, nicolasfella Cc: nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26756: Strip richtext on Windows, simplify how rich teyt is stripped in KPassivePopup

nicolasfella accepted this revision. nicolasfella added a comment. This revision is now accepted and ready to land. you can push the two commits directly INLINE COMMENTS > knotificationplugin.h:104 > + > + > Q_SIGNALS: remove one empty line > notifybysnore.cpp:62 > > + >

D26757: Reduce dependencies on Windows

nicolasfella accepted this revision. nicolasfella added a comment. This revision is now accepted and ready to land. Other than that looks good to me REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D26757 To: vonreth, broulik, brute4s99,

D26757: Reduce dependencies on Windows

nicolasfella added inline comments. INLINE COMMENTS > CMakeLists.txt:42 > > -if (NOT ANDROID) > +if (NOT ANDROID AND NOT WIN32) > find_package(Qt5 ${REQUIRED_QT_VERSION} CONFIG REQUIRED DBus) This results in KStatusNotifierItem not being built on Windows. Is KSNI any useful on Windows

D26756: Strip richtext on Windows, as Windows does not support it

nicolasfella added a comment. We have the same problem on Linux (if the server doesn't support rich text) and probably Android too. In notifybypopup we do this with QXmlStreamReader + some API from KCodecs, but your solution is much simpler and nicer. Ideally this should be done in

D25798: Deprecated allowAsDefault

nicolasfella updated this revision to Diff 73672. nicolasfella added a comment. - Fix and update REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25798?vs=71036=73672 BRANCH allo REVISION DETAIL https://phabricator.kde.org/D25798 AFFECTED FILES

D25660: Decouple KBookmarksMenu from KActionCollection

nicolasfella updated this revision to Diff 73666. nicolasfella marked 11 inline comments as done. nicolasfella added a comment. - Decouple from KActionCollection - Set action name - Restore root check - Use constructor delegation - Update since - fix docs - Docs fixes - Use

D26616: Adjust metainfo.yaml to new tier

This revision was automatically updated to reflect the committed changes. Closed by commit R307:0422b0f449c1: Adjust metainfo.yaml to new tier (authored by nicolasfella). REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26616?vs=73374=73442 REVISION DETAIL

D26616: Adjust metainfo.yaml to new tier

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY With the KService dependency gone it is Tier 2 now REPOSITORY

D25490: Remove legacy plugin loading code

This revision was automatically updated to reflect the committed changes. Closed by commit R307:fac77e1796e3: Remove legacy plugin loading code (authored by nicolasfella). REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25490?vs=70219=73373 REVISION DETAIL

D26604: Check if there is an activatable service when notification service owner changes

nicolasfella added a comment. In D26604#592808 , @broulik wrote: > What again was the reason for not just sending a notification where DBus activation will do its thing? Saving us a futile DBus calls, but I don't know if that matters in

D26532: Don't use KWindowSystem on Android

This revision was automatically updated to reflect the committed changes. Closed by commit R289:33742dde2f73: Dont use KWindowSystem on Android (authored by nicolasfella). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26532?vs=73095=73343 REVISION

D26604: Check if there is an activatable service when notification service owner changes

nicolasfella added a dependent revision: D26605: Remove fallback to KPassivePopup. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26604 To: nicolasfella, #plasma, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26605: Remove fallback to KPassivePopup

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY KNotifications has proper support for all major platforms

D26604: Check if there is an activatable service when notification service owner changes

nicolasfella updated this revision to Diff 73340. nicolasfella added a comment. - Move code REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26604?vs=73338=73340 BRANCH checkactivatable REVISION DETAIL https://phabricator.kde.org/D26604

D26604: Check if there is an activatable service when notification service owner changes

nicolasfella created this revision. nicolasfella added reviewers: Plasma, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY At notification backend initialization we don't just check

D26594: Deprecate raiseWidget

This revision was automatically updated to reflect the committed changes. Closed by commit R289:b5ba64a0545d: Deprecate raiseWidget (authored by nicolasfella). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26594?vs=73314=73317 REVISION DETAIL

D26594: Deprecate raiseWidget

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY It is unused. Furthermore, it relies on QtWidgets API

D26448: Add KRecentFilesMenu to replace KRecentFileAction

nicolasfella marked an inline comment as not done. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D26448 To: nicolasfella, #frameworks, dfaure Cc: broulik, elvisangelaccio, cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26448: Add KRecentFilesMenu to replace KRecentFileAction

nicolasfella updated this revision to Diff 73172. nicolasfella marked 6 inline comments as done. nicolasfella added a comment. - More comments REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26448?vs=73170=73172 BRANCH recentfilemenu REVISION

D26448: Add KRecentFilesMenu to replace KRecentFileAction

nicolasfella updated this revision to Diff 73170. nicolasfella marked 4 inline comments as done. nicolasfella added a comment. - Address comments REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26448?vs=72928=73170 BRANCH recentfilemenu REVISION

D25653: [bookmarksmenu] Improve variable name

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R294:78cbabc2d675: [bookmarksmenu] Improve variable name (authored by nicolasfella). CHANGED PRIOR TO COMMIT

D25490: Remove legacy plugin loading code

nicolasfella added a comment. Ping? REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D25490 To: nicolasfella, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25655: Remove outdated comments

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R294:b8c2e78e371c: Remove outdated comments (authored by nicolasfella). REPOSITORY R294 KBookmarks CHANGES SINCE LAST

D26532: Don't use KWindowSystem on Android

nicolasfella added a subscriber: dfaure. nicolasfella added a comment. Pragmatically speaking I want to say 'No'. @dfaure Do you have an opinion on this? REPOSITORY R289 KNotifications BRANCH nokwindowsystem REVISION DETAIL https://phabricator.kde.org/D26532 To: nicolasfella,

D26532: Don't use KWindowSystem on Android

nicolasfella added a comment. In D26532#590598 , @vkrause wrote: > We are already not building a few things here on Android (including public API on other platforms), so excluding more is fine IMHO, especially if it's stuff where you can't

D26513: Port KNotification from KWindowSystem

nicolasfella added a dependent revision: D26532: Don't use KWindowSystem on Android. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D26513 To: davidedmundson, nicolasfella Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26532: Don't use KWindowSystem on Android

nicolasfella edited the summary of this revision. nicolasfella added a dependency: D26513: Port KNotification from KWindowSystem. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26532 To: nicolasfella, #frameworks, vkrause Cc: kde-frameworks-devel, LeGast00n,

D26532: Don't use KWindowSystem on Android

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, vkrause. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY The usage of KWindowSystem is not relevant on Android.

D26513: Port KNotification from KWindowSystem

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D26513 To: davidedmundson, nicolasfella Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26448: Add KRecentFilesMenu to replace KRecentFileAction

nicolasfella added inline comments. INLINE COMMENTS > dfaure wrote in krecentfilesmenu.cpp:85 > Why not std::vector? > > std::list is a linked list, so this smells like pointers to nodes containing > pointers, lots of indirection. New entries are pushed to the front, which works in constant

D26159: Drop KWindowSystem dependency

nicolasfella added a comment. Please also remove from kde-build-metadata REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D26159 To: davidedmundson, apol Cc: nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26448: Add KRecentFilesMenu to replace KRecentFileAction

nicolasfella added inline comments. INLINE COMMENTS > cfeck wrote in krecentfilesmenu.h:104 > Weren't there ABI issues with std::list? > > Also, missing reference on url. We use std::list in other frameworks and IIRC no one complained REPOSITORY R236 KWidgetsAddons REVISION DETAIL

D26448: Add KRecentFilesMenu to replace KRecentFileAction

nicolasfella marked 8 inline comments as done. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D26448 To: nicolasfella, #frameworks, dfaure Cc: elvisangelaccio, cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26448: Add KRecentFilesMenu to replace KRecentFileAction

nicolasfella marked 8 inline comments as not done. nicolasfella added inline comments. INLINE COMMENTS > elvisangelaccio wrote in krecentfilesmenu.cpp:31 > Why not `int` since it's what we expose in the API anyway? I'm getting a warning about signed/unsigned compare otherwise REPOSITORY R236

D26448: Add KRecentFilesMenu to replace KRecentFileAction

nicolasfella updated this revision to Diff 72928. nicolasfella marked 8 inline comments as done. nicolasfella added a comment. - Rework internals to do fewer allocations and file IO REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26448?vs=72844=72928

D26448: Add KRecentFilesMenu to replace KRecentFileAction

nicolasfella updated this revision to Diff 72844. nicolasfella added a comment. - Docs REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26448?vs=72842=72844 BRANCH recentfilemenu REVISION DETAIL https://phabricator.kde.org/D26448 AFFECTED FILES

D26448: Add KRecentFilesMenu to replace KRecentFileAction

nicolasfella edited the test plan for this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D26448 To: nicolasfella, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26449: [PoC] Port to KRecentFileMenu

nicolasfella created this revision. nicolasfella added reviewers: Ark, Frameworks. Herald added a subscriber: kde-utils-devel. Herald added a project: Ark. nicolasfella requested review of this revision. REVISION SUMMARY PoC for using KRecentFileMenu. See D26448

D26448: Add KRecentFilesMenu to replace KRecentFileAction

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY The way KRecentFilesAction is used has a number of

D26440: Add KSharedConfig::openStateConfig for storing state information

This revision was automatically updated to reflect the committed changes. Closed by commit R237:ebd14f29f805: Add KSharedConfig::openStateConfig for storing state information (authored by nicolasfella). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D26440: Add KSharedConfig::openStateConfig for storing state information

nicolasfella updated this revision to Diff 72826. nicolasfella added a comment. - Change to staterc REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26440?vs=72820=72826 BRANCH state REVISION DETAIL https://phabricator.kde.org/D26440 AFFECTED FILES

D26440: Add KSharedConfig::openStateConfig for storing state information

nicolasfella edited the summary of this revision. REPOSITORY R237 KConfig BRANCH state REVISION DETAIL https://phabricator.kde.org/D26440 To: nicolasfella, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26440: Add KSharedConfig::openStateConfig for storing state information

nicolasfella retitled this revision from "Add utility method for opening a KSharedConfig suitable to store state information" to "Add KSharedConfig::openStateConfig for storing state information". REPOSITORY R237 KConfig BRANCH state REVISION DETAIL https://phabricator.kde.org/D26440

D26440: Add utility method for opening a KSharedConfig suitable to store state information

nicolasfella added inline comments. INLINE COMMENTS > dfaure wrote in ksharedconfig.cpp:124 > My idea was to add `const QString = QString()` to this method so > that complex apps can use multiple state files. Or for parts and plugins to > use a fixed name whatever app they're in. > (one

<    1   2   3   4   5   6   7   8   9   >