D18662: Add and rename some YaST icon symlinks because of Qt bugs

2019-02-01 Thread Noah Davis
ndavis added a subscriber: fvogt. ndavis added a comment. @fvogt LCP said a Qt bug was the reason that the icons weren't working correctly and that you would know more about it. I never got around to asking you though. Do you know which bug it is? REPOSITORY R266 Breeze Icons REVISION DET

D18662: Add and rename some YaST icon symlinks because of Qt bugs

2019-02-01 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18662 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18662: Add and rename some YaST icon symlinks because of Qt bugs

2019-02-01 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY The icons should have worked as they were because they have the correct fallback names. How

D18660: Add yast-upgrade

2019-02-01 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:9555110c23c5: Add yast-upgrade (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18660?vs=50691&id=50692 REVISION DETAIL https://phabricat

D18660: Add yast-upgrade

2019-02-01 Thread Noah Davis
ndavis added a comment. It's just this with the arrow flipped upside down to indicate that it's for upgrading from installation media instead of installing F6582392: Screenshot_20190201_231228.png REPOSITORY R266 Breeze Icons REVISION DETAIL https:

D18660: Add yast-upgrade

2019-02-01 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18660 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18660: Add yast-upgrade

2019-02-01 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY An icon for doing an upgrade with the openSUSE YaST installer. Appears in the application m

D18652: Improve weather-storm-* icons

2019-02-01 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH improve-storm-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D18652 To: ngraham, #vdg, kossebau, ndavis Cc: ndavis, kde-frameworks-devel, michaelh,

D18652: Improve weather-storm-* icons

2019-02-01 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Certainly an improvement, you just need to strip out all of the unnecessary Inkscape metadata. You can do that with, SVG Cleaner, SVGO, or go to "File->Save As" and save as a "Pla

D18533: Improve the Notfication Bell Icon by using the KAlarm design

2019-02-01 Thread Noah Davis
ndavis added a comment. In D18533#403354 , @ngraham wrote: > In D18533#403351 , @ndavis wrote: > > > The ringer inside the bell has contrast issues with the standard Breeze Dark background color: F65

D18533: Improve the Notfication Bell Icon by using the KAlarm design

2019-02-01 Thread Noah Davis
ndavis added a comment. The ringer inside the bell has contrast issues with the standard Breeze Dark background color: F6581679: Screenshot_20190201_131929.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18533 To: tri

D18533: Improve the Notfication Bell Icon by using the KAlarm design

2019-02-01 Thread Noah Davis
ndavis added a comment. F6581666: Screenshot_20190201_131014.png The colors are no so good, but this is what I was talking about. It looks more 3D. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18533 To: trickyrick

D18622: Remove monochrome preferences-system symlinks

2019-01-30 Thread Noah Davis
ndavis abandoned this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18622 To: ndavis, #vdg, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18622: Remove monochrome preferences-system symlinks

2019-01-30 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18622 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18622: Remove monochrome preferences-system symlinks

2019-01-30 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Remove some monochrome preferences-system symlinks that were added for compatibility with 3

D18563: Don't create directory tree when a new folder has a '/' in the name

2019-01-29 Thread Noah Davis
ndavis added a comment. In D18563#402216 , @ngraham wrote: > It's rather ironic that in D18571 , I endorse a hidden productivity booster feature, but here, I reject one. :) > > I think I'm reconsidering. It

D18563: Don't create directory tree when a new folder has a '/' in the name

2019-01-29 Thread Noah Davis
ndavis added a comment. So if I want to make 2 folders at once, `~/a` and `~/a/b`, this patch removes that ability? If so, I don't like this change. REPOSITORY R241 KIO BRANCH dir REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin, dfaure,

D18439: Add proper edit-delete-shred icons

2019-01-26 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:a8d82b00afdb: Add proper edit-delete-shred icons (authored by trickyricky26, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18439?vs=5034

D18533: Improve the Notfication Bell Icon by using the KAlarm design

2019-01-26 Thread Noah Davis
ndavis added a comment. In D18533#400011 , @trickyricky26 wrote: > I have made some slight adjustments from the original KAlarm design, such as a shadow line at the bottom instead of orange, to better fir our style. > Should I make those chan

D18552: Add trim margins and trim to selection icons

2019-01-26 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. I really like this and I'm going to accept it as is, but what do other #vdg people think about the difference between the 32px and smaller versions of trim to margins? I know it's hard to fit in det

D18529: Rename Activities KCM icon

2019-01-25 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:31e1b9977a47: Rename Activities KCM icon (authored by ndavis). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18529?vs=50273&id=50282#toc REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPD

D18529: Rename Activities KCM icon

2019-01-25 Thread Noah Davis
ndavis added a dependent revision: D18532: Change icons for Activities dataengine and runner. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18529 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18529: Rename Activities KCM icon

2019-01-25 Thread Noah Davis
ndavis added a dependent revision: D18531: Change icon for Activities config. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18529 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18529: Rename Activities KCM icon

2019-01-25 Thread Noah Davis
ndavis added a dependent revision: D18530: Change Activities KCM icon. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18529 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18529: Rename Activities KCM icon

2019-01-25 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY KCMs should have color icons while widgets should have monochrome icons, so I have changed

D18507: Add Activities KCM icon

2019-01-25 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:c3981728515f: Add Activities KCM icon (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18507?vs=50208&id=50268 REVISION DETAIL https://p

D18507: Add Activities KCM icon

2019-01-24 Thread Noah Davis
ndavis added a comment. The icon the KCM currently uses is `preferences-activities`. It's kind of odd that it isn't `preferences-desktop-activities`. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18507 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngra

D18507: Add Activities KCM icon

2019-01-24 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18507 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18507: Add Activities KCM icon

2019-01-24 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH preferences-desktop (branched from master) REVISION DETAIL https://

D18490: Add Virtual Desktops KCM icon

2019-01-23 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:8fd382fc414e: Add Virtual Desktops KCM icon (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18490?vs=50159&id=50161 REVISION DETAIL htt

D18490: Add Virtual Desktops KCM icon

2019-01-23 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18490 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18490: Add Virtual Desktops KCM icon

2019-01-23 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18490 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18490: Add Virtual Desktops KCM icon

2019-01-23 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH preferences-virtual-desktop (branched from master) REVISION DETAIL

D18483: Add icons for Touch Screen and Screen Edge KCMs

2019-01-23 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:9aec0d9cc43f: Add icons for Touch Screen and Screen Edge KCMs (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18483?vs=50156&id=50157 REV

D18483: Add icons for Touch Screen and Screen Edge KCMs

2019-01-23 Thread Noah Davis
ndavis updated this revision to Diff 50156. ndavis added a comment. Add change to breeze dark REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18483?vs=50154&id=50156 BRANCH preferences-gestures (branched from master) REVISION DETAIL https://phabri

D18483: Add icons for Touch Screen and Screen Edge KCMs

2019-01-23 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18483 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18483: Add icons for Touch Screen and Screen Edge KCMs

2019-01-23 Thread Noah Davis
ndavis updated this revision to Diff 50154. ndavis added a comment. Change style of screen edges icon REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18483?vs=50139&id=50154 BRANCH preferences-gestures (branched from master) REVISION DETAIL https:

D18474: Fix file sharing preference related icon names

2019-01-23 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:39926c33c188: Fix file sharing preference related icon names (authored by ndavis). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18474?vs=50115&id=50149#toc REPOSITORY R266 Breeze Icons CH

D18483: Add icons for Touch Screen and Screen Edge KCMs

2019-01-23 Thread Noah Davis
ndavis added a comment. In D18483#398753 , @ngraham wrote: > Maybe `preferences-desktop-gestures-screenedges` should have the cursor near to the hot corner to reinforce the concept? Otherwise it kind of feels like an icon for the cursors KCM.

D18483: Add icons for Touch Screen and Screen Edge KCMs

2019-01-23 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18483 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18483: Add icons for Touch Screen and Screen Edge KCMs

2019-01-23 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH preferences-gestures (branched from master) REVISION DETAIL https:/

D18473: Add monochrome symlinks for preferences-system

2019-01-23 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:14bbb8f64ba2: Add monochrome symlinks for preferences-system (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18473?vs=50114&id=50127 REVI

D18474: Fix file sharing preference related icon names

2019-01-23 Thread Noah Davis
ndavis added a comment. In D18474#398581 , @ngraham wrote: > Screenshots would be appreciated. :) Sorry, I had to deal with something. The only visual difference is with the samba share KCM. I also added `preferences-system-network-share`

D18474: Fix file sharing preference related icon names

2019-01-23 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18474 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18439: Add proper edit-delete-shred icons

2019-01-23 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I've checked the files and they all look good to me. REPOSITORY R266 Breeze Icons BRANCH proper-shred-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D18439

D18473: Add monochrome symlinks for preferences-system

2019-01-23 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18473 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18474: Fix file sharing preference related icon names

2019-01-23 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Fixes the names of file sharing preference related icons so that they show up in system set

D18473: Add monochrome symlinks for preferences-system

2019-01-23 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY This will improve visual compatibility with some 3rd party applications that use preference

D18433: Add a Plasma Theme Preferences Icon

2019-01-21 Thread Noah Davis
ndavis added a comment. In D18433#397602 , @ngraham wrote: > We have `preferences-desktop-theme-global`; shouldn't this be `preferences-desktop-theme-plasma`? Good point REPOSITORY R266 Breeze Icons BRANCH add-plasma-theme-icon (bra

D18432: Improve contrast of preferences-system-time

2019-01-21 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH fix-clock-icon-contrast (branched from master) REVISION DETAIL https://phabricator.kde.org/D18432 To: trickyricky26, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-framework

D18433: Add a Plasma Theme Preferences Icon

2019-01-21 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Looks good to me! REPOSITORY R266 Breeze Icons BRANCH add-plasma-theme-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D18433 To: trickyricky26, #vdg, ndavis

D18432: Improve contrast of preferences-system-time

2019-01-21 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Make the outline a solid circle behind the clock part instead of just an outline. The reason for this is that the edges between the outline and the clock look worse if the outline

D18379: Add tools icon

2019-01-19 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:1000c8b4884e: Add tools icon (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18379?vs=49862&id=49884 REVISION DETAIL https://phabricator

D18379: Add tools icon

2019-01-19 Thread Noah Davis
ndavis added a comment. In D18379#396432 , @ngraham wrote: > Very nice! Just what I had in mind. Do we really need a 32px version though? A number of icons start with `tools-`, which means that this icon is the last fallback option. It co

D18379: Add tools icon

2019-01-19 Thread Noah Davis
ndavis updated this revision to Diff 49862. ndavis added a comment. Fix messed up breeze-dark 32px version REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18379?vs=49861&id=49862 BRANCH tools-icon (branched from master) REVISION DETAIL https://pha

D18379: Add tools icon

2019-01-19 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18379 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18379: Add tools icon

2019-01-19 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18379 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18379: Add tools icon

2019-01-19 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18379 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18379: Add tools icon

2019-01-19 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Adds a `tools` icon for menus that show a list of tools/programs (e.g., the "Tools" menus i

D17977: Improve reliability and semantic correctless of dupe test

2019-01-18 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. I found an issue. With the patch, the dupe test does not detect 2 identical files with the same name in different categories. It is able to detect that issue from How to

D17797: Include applets/22

2019-01-14 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:d5a2b47c2d37: Include applets/22 (authored by nicolasfella, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17797?vs=49294&id=49495 REVIS

D18199: Add Kotlin (.kt) mimetype icons

2019-01-13 Thread Noah Davis
ndavis accepted this revision. REPOSITORY R266 Breeze Icons BRANCH add-kotlin-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D18199 To: trickyricky26, #vdg, ngraham, ndavis Cc: alex-l, ngraham, kde-frameworks-devel, michaelh, bruns

D17797: Include applets/22

2019-01-12 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH fix REVISION DETAIL https://phabricator.kde.org/D17797 To: nicolasfella, #breeze, ndavis Cc: ndavis, kde-frameworks-devel, trickyricky26, michaelh, ngraham, bruns

D17496: Change network/web color icons to consistent style

2019-01-04 Thread Noah Davis
ndavis added a comment. According In D17496#376605 , @ngraham wrote: > Now that this is landed, feel free to change the symlinks by hand. In D17496#386549 , @dfaure wrote: > The un

D17969: Use a Kolf icon with nice background and shadows

2019-01-04 Thread Noah Davis
ndavis added a comment. In D17969#386590 , @aacid wrote: > In D17969#386575 , @ndavis wrote: > > > It seems there are not actually any members in the #kde_games

D17972: Change preferences-system-network to symlink

2019-01-04 Thread Noah Davis
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R266:9fc9e28c19d8: Change preferences-system-network to symlink (authored by ndavis). REPOSITORY R266 Breeze Icons CHANG

D17972: Change preferences-system-network to symlink

2019-01-04 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17972 To: ndavis Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17972: Change preferences-system-network to symlink

2019-01-04 Thread Noah Davis
ndavis created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY preferences-system-network -> ../../categories/32/applications-internet.svg With this change, breeze-icons now passes th

D17969: Use a Kolf icon with nice background and shadows

2019-01-04 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:d2c76841fbd8: Use a Kolf icon with nice background and shadows (authored by trickyricky26, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D17969: Use a Kolf icon with nice background and shadows

2019-01-04 Thread Noah Davis
ndavis added a comment. It seems there are not actually any members in the #kde_games group. I think I'll land this now so that it can be included with KF5.54. REPOSITORY R266 Breeze Icons BRANCH better-kolf-icon (branched from master) REVIS

D17969: Use a Kolf icon with nice background and shadows

2019-01-04 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Yes, this is much better. I think I'll accept it as it is. This is how it looks at 100% size. F6525459: Screenshot_20190104_153802.png REPOSITO

D17927: Fix gradient positions (Breeze Dark)

2019-01-02 Thread Noah Davis
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R266:742801be4a7a: Fix gradient positions (Breeze Dark) (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE

D17927: Fix gradient positions (Breeze Dark)

2019-01-02 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Forgot to do Breeze Dark when I fixed them in my previous diff REPOSITORY R266 Breeze Ico

D17912: Fix shadow gradients

2019-01-02 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:9a4e5d509535: Fix shadow gradients (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17912?vs=48509&id=48561 REVISION DETAIL https://phabr

D17912: Fix shadow gradients

2019-01-01 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17912 To: ndavis, #vdg, #breeze Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17912: Fix shadow gradients

2019-01-01 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17912 To: ndavis, #vdg, #breeze Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17912: Fix shadow gradients

2019-01-01 Thread Noah Davis
ndavis created this revision. ndavis added reviewers: VDG, Breeze. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY A few icons had messed up shadows. They are now fixed. REPOSITORY R266 Breeze Icon

D17623: Add YaST and new preference icons

2019-01-01 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:9de855e093c8: Add YaST and new preference icons (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17623?vs=48418&id=48505 REVISION DETAIL

D17623: Add YaST and new preference icons

2018-12-30 Thread Noah Davis
ndavis added a comment. The patch now passes the scalable test, but I don't think it's organized in a great way. I supposed I can always reorganize things if I make 48px versions of each YaST icon later. I can't do that now because it would take way too much time and I'm starting to get sick

D17623: Add YaST and new preference icons

2018-12-30 Thread Noah Davis
ndavis updated this revision to Diff 48418. ndavis added a comment. Move all YaST icons that don't have a 48px version to `preferences/32/`, undo all changes to `index.theme`, remove the new `preferences-system` icon, change `yast-system` to a symlink to `systemsettings` REPOSITORY R266 Br

D17623: Add YaST and new preference icons

2018-12-28 Thread Noah Davis
ndavis added a comment. > (again, not taking size constraints into consideration) This is what is wrong with the test. I've set the size constraints for apps/32 to not overlap with apps/48, so there should be no problem. apps/48 does overlap with apps/64, but apps/64 isn't that important

D17623: Add YaST and new preference icons

2018-12-28 Thread Noah Davis
ndavis added a comment. OK, so it seems I can't have multiple scalable directories with different versions of the same icon when the directories have the Application context. This test is such a pain in the ass. I know most tests are there for a good reason, but this one has only ever gotten

D17623: Add YaST and new preference icons

2018-12-28 Thread Noah Davis
ndavis added a comment. In D17623#383392 , @ngraham wrote: > With the latest change, this now fails the `scalable` test. How do I see what tests a patch will pass or fail? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabrica

D17623: Add YaST and new preference icons

2018-12-28 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons BRANCH yast-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D17623 To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST and new preference icons

2018-12-28 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons BRANCH yast-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D17623 To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST and new preference icons

2018-12-28 Thread Noah Davis
ndavis updated this revision to Diff 48332. ndavis added a comment. Add most recent changes to breeze dark REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17623?vs=48331&id=48332 BRANCH yast-icons (branched from master) REVISION DETAIL https://pha

D17623: Add YaST and new preference icons

2018-12-28 Thread Noah Davis
ndavis updated this revision to Diff 48331. ndavis added a comment. fix yast-installation REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17623?vs=48329&id=48331 BRANCH yast-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/

D17623: Add YaST and new preference icons

2018-12-28 Thread Noah Davis
ndavis added a comment. F6513963: Screenshot_20181228_223854.png I'm guessing I'll need to either do manual edits in the XML or recreate them from scratch. REPOSITORY R266 Breeze Icons BRANCH yast-icons (branched from master) REVISION DETAIL

D17623: Add YaST and new preference icons

2018-12-28 Thread Noah Davis
ndavis added a comment. In D17623#383376 , @ngraham wrote: > Outstanding. Only one final issue that I can see: the long shadow cast by the arrow in `yast-installation` doesn't fade out; it just continues off the rest of the icon: > > F651396

D17623: Add YaST and new preference icons

2018-12-28 Thread Noah Davis
ndavis updated this revision to Diff 48329. ndavis added a comment. Shift servers in dhcp and dns server icons to the right a bit and fix the shadow of the services icon REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17623?vs=48297&id=48329 BRANCH

D17623: Add YaST and new preference icons

2018-12-28 Thread Noah Davis
ndavis added a comment. Here's the same icon in cuttlefish, except the line you saw on the bottom doesn't show up for me: F6513637: Screenshot_20181228_180802.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17623 To

D17623: Add YaST and new preference icons

2018-12-28 Thread Noah Davis
ndavis added a comment. In D17623#383325 , @ngraham wrote: > A few more little nitpicks: > > - `preferences-system-services` still has a shadow over the background rather than another part of itself: F6513586: shadow.png

D17845: Add device icons for RJ11 and RJ45 ports

2018-12-28 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:abed651411b9: Add device icons for RJ11 and RJ45 ports (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17845?vs=48321&id=48322 REVISION D

D17845: Add device icons for RJ11 and RJ45 ports

2018-12-28 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17845 To: ndavis, #vdg, #breeze Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17845: Add device icons for RJ11 and RJ45 ports

2018-12-28 Thread Noah Davis
ndavis updated this revision to Diff 48321. ndavis added a comment. Update style REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17845?vs=48316&id=48321 BRANCH network-jacks (branched from master) REVISION DETAIL https://phabricator.kde.org/D17845

D17623: Add YaST and new preference icons

2018-12-28 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17623 To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17845: Add device icons for RJ11 and RJ45 ports

2018-12-28 Thread Noah Davis
ndavis added a comment. In D17845#383266 , @ngraham wrote: > I love the full-color versions! For the monochrome ones, what do you think about putting them within a rounded rectangular frame like the full-color versions do? Right now the "femalen

D17845: Add device icons for RJ11 and RJ45 ports

2018-12-28 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17845 To: ndavis, #vdg, #breeze Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17845: Add device icons for RJ11 and RJ45 ports

2018-12-28 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17845 To: ndavis, #vdg, #breeze Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17845: Add device icons for RJ11 and RJ45 ports

2018-12-28 Thread Noah Davis
ndavis created this revision. ndavis added reviewers: VDG, Breeze. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH network-jacks (branched from master) REVISION DETAIL https:/

<    6   7   8   9   10   11   12   13   14   15   >