D16905: Add a generic sorting options icon

ndavis added a comment. In D16905#360055 , @trickyricky26 wrote: > I have adjusted the arrows to fit the `view-sort-ascending` style: > > F6425856: sorting-icon-22-alt.png 22px > F6425879: sorting-ic

D16905: Add a generic sorting options icon

ndavis added a comment. In D16905#360075 , @trickyricky26 wrote: > So should I include the renaming of the existing icons and adding of the ascending and descending versions of these new ones in this revision? That way applications that use `vi

D16905: Add a generic sorting options icon

ndavis added a comment. In D16905#360449 , @trickyricky26 wrote: > I wasn't quite sure if I should use 2px strokes in the `32px` versions, so I used 1px for now as that is more consistent with the rest. > If there are no more suggestions, I w

D16951: Add mouse button icons

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Add left, middle and right click icons for KDE Connect FEATURE: 399295 FIXED-IN: 5.53

D16951: Add mouse button icons

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16951: Add mouse button icons

ndavis added a subscriber: nicolasfella. ndavis added a comment. @nicolasfella Will these work for you? Let me know if you need thumb buttons as well. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg Cc: nicolasfella, kde-frameworks-devel,

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

ndavis added a comment. In D16905#360586 , @trickyricky26 wrote: > - Fix naming of ascending and descending versions; make ascending versions less confusing; fix symlink sort-name > > I have flipped the naming of the ascending and descendi

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

ndavis added a comment. In D16905#360938 , @trickyricky26 wrote: > I am sure that in ascending, the lines get longer further down (representing larger file sizes etc.). The thing I am not quite sure about is the direction of the arrows.

D16951: Add mouse button icons

ndavis added a comment. In D16951#360965 , @rizzitello wrote: > I think the Mouse itself needs a bit more curve with less box. I kind of agree. I was just copying the existing `dialog-input-devices` icon, but I suppose I could change tha

Re: firewall-applet icons break breeze auto tests

On Saturday, November 17, 2018 5:37:36 AM EST Albert Astals Cid wrote: > Hi Noah, > > At the moment breeze-icons auto tests are failing with this error (both for > icons and icons-dark) > > The following icons are not available in a scalable directory: > firewall-applet-shields_up > firewall-

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

ndavis accepted this revision. ndavis added a comment. Unless someone has a final request, I think this is ready to land. REPOSITORY R266 Breeze Icons BRANCH add-sort-options-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg, #breez

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

ndavis added a comment. See if yo can shorten the title down to 50 characters and if not that, see if you can get it down to below 80. REPOSITORY R266 Breeze Icons BRANCH add-sort-options-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26

D16905: Add new generic sorting icons; rename existing sorting icons

ndavis added a comment. Great! That will work. REPOSITORY R266 Breeze Icons BRANCH add-sort-options-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg, #breeze, ndavis Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, michae

D16905: Add new generic sorting icons; rename existing sorting icons

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. `sort.svg` uses the older version of your style. Make it a relative symlink to `view-sort.svg`. F6429080: Screenshot_20181117_130528.png

D16905: Add new generic sorting icons; rename existing sorting icons

ndavis added a comment. The margins on the 32px icons are different from other 32px icons. The existing ones use a 4px margin on each side. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg, #breeze, ndavis Cc: cfeck, emateli, ndavis

D16905: Add new generic sorting icons; rename existing sorting icons

ndavis added a comment. In D16905#361148 , @trickyricky26 wrote: > Ok I will change that, however the graphic on the Icons HIG Page (https://hig.kde.org/_images/Breeze-icon-design-5.png) says a inner size of 28px which means 2px margins on each

D16905: Add new generic sorting icons; rename existing sorting icons

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I will land this now. There's nothing left that needs to be done. REPOSITORY R266 Breeze Icons BRANCH add-sort-options-icon (branched from master) REVISION DETAIL https://phabricator

D16905: Add new generic sorting icons; rename existing sorting icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:64b3a8fa6ff7: Add new generic sorting icons; rename existing sorting icons (authored by trickyricky26, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabrica

D16934: Add help-browser symlink to 16px and 22px directories

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. This is a very simple change that doesn't need much reviewing. I see no reason not to land this now. REPOSITORY R266 Breeze Icons BRANCH fix-help-browser-symlink (branched from master)

D16934: Add help-browser symlink to 16px and 22px directories

This revision was automatically updated to reflect the committed changes. Closed by commit R266:ae50e26abbad: Add help-browser symlink to 16px and 22px directories (authored by trickyricky26, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde

Re: firewall-applet icons break breeze auto tests

On Saturday, November 17, 2018 11:17:15 AM EST Albert Astals Cid wrote: > El dissabte, 17 de novembre de 2018, a les 14:03:45 CET, Noah Davis va escriure: > > On Saturday, November 17, 2018 5:37:36 AM EST Albert Astals Cid wrote: > > > Hi Noah, > > > > > > A

D16964: Change archive-* action icons to represent archives

ndavis accepted this revision. ndavis added a comment. In D16964#361229 , @ngraham wrote: > Beautiful, just what I had in mind! Amazing what a little zipper will do. @ndavis, does this look good to you too? It's consistent with other icon

D16964: Change archive-* action icons to represent archives

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Sorry, jumped the gun a bit. The orientation of the zypper needs to be horizontally reversed on the 16 and 22 px icons, then it will be perfectly consistent REPOSITORY R266 Bre

D16964: Change archive-* action icons to represent archives

ndavis added a comment. In D16964#361253 , @ngraham wrote: > In D16964#361250 , @ndavis wrote: > > > zypper > > > Found the openSUSE user. :) LOL, I've gotten too used to openSUSE to spe

D16951: Add mouse button icons

ndavis planned changes to this revision. ndavis added a comment. Alright, that's 2 people in favor of a curved mouse. After all, we're not using Apple Macintoshes from the 80s. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg Cc: ngraham,

D16951: Add mouse button icons

ndavis updated this revision to Diff 45703. ndavis added a comment. Change mouse to rounded style REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16951?vs=45639&id=45703 BRANCH mouse-buttons (branched from master) REVISION DETAIL https://phabricat

D16951: Add mouse button icons

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg Cc: ngraham, rizzitello, nicolasfella, kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

ndavis added a comment. In D16951#361294 , @ngraham wrote: > Much better shape! > > What do you think about making the mouse wheel detached from the top of the mouse so it looks more like a wheel and less like a notch? Then also you might no

D16951: Add mouse button icons

ndavis added a comment. In D16951#361317 , @ngraham wrote: > What about making the MMB turn white when it has the blue highlight? white MMB F642: Screenshot_20181118_005525.png white MMB wit

D16964: Change archive-* action icons to represent archives

ndavis added a comment. In D16964#361357 , @trickyricky26 wrote: > Do you think this is more consistent: > F6430252: archive-extract-22-new.svg.png > F6430251: archive-extract-16-new.svg.png

D16964: Change archive-* action icons to represent archives

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I've had a good look at your patch now and everything is ok. Unless @ngraham has anything else to say, I think it's time to land this. REPOSITORY R266 Breeze Icons BRANCH change-archiv

Re: firewall-applet icons break breeze auto tests

On Sunday, November 18, 2018 5:34:02 AM EST Albert Astals Cid wrote: > El dissabte, 17 de novembre de 2018, a les 20:43:04 CET, Noah Davis va escriure: > > On Saturday, November 17, 2018 11:17:15 AM EST Albert Astals Cid wrote: > > > El dissabte, 17 de novembre de 2018, a les

D16951: Add mouse button icons

ndavis added a comment. F6430803: Screenshot_20181118_123558.png Is this too small or not legible enough? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg Cc: trickyricky26, abetts, ngraham, rizz

D16964: Change archive-* action icons to represent archives

This revision was automatically updated to reflect the committed changes. Closed by commit R266:aace21a15667: Change archive-* action icons to represent archives (authored by trickyricky26, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D16983: Add 48px firewall-applet icon

ndavis created this revision. ndavis added reviewers: VDG, Breeze. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Added a symlink from `firewall-config.svg` to `firewall-applet.svg` breeze-icons

D16983: Add 48px firewall-applet icon

ndavis added a comment. @ngraham Realistically, users will never need the 48px versions of each icon. Can I just make more symlinks of `firewall-config` or should I make icons that actually represent the other icons? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.o

D16983: Add 48px firewall-applet icon

ndavis updated this revision to Diff 45746. ndavis added a comment. Add more symlinks REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16983?vs=45739&id=45746 BRANCH add-firewall-applet-48px (branched from master) REVISION DETAIL https://phabricato

D16983: Add 48px firewall-applet* icons

ndavis retitled this revision from "Add 48px firewall-applet icon" to "Add 48px firewall-applet* icons". ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16983 To: ndavis, #vdg, #breeze, ngraham Cc: ngraham, kde-frameworks

D16951: Add mouse button icons

ndavis updated this revision to Diff 45755. ndavis added a comment. Detach MMB, increase highlight length, make colors match new HIG, turn MMB click highligh into outline REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16951?vs=45703&id=45755 BRANCH

D16951: Add mouse button icons

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg Cc: trickyricky26, abetts, ngraham, rizzitello, nicolasfella, kde-frameworks-devel, michaelh, bruns

D16983: Add 48px firewall-applet* icons

ndavis added a comment. In D16983#361758 , @aacid wrote: > I'm sorry but this makes no sense at all, why is firewall-applet-error now suddenly firewall-config? > > And why do you say users will never need a 48px verison of it? firewal

Re: firewall-applet icons break breeze auto tests

On Monday, November 19, 2018 6:53:28 AM EST Harald Sitter wrote: > I am CCing Andreas Kainz on this as he may have input on where the > firewall-* icons should go. > From a quick look though I am convinced the majority/all of these > icons should be in status/ not apps/. They are used in the system

D16983: Add 48px firewall-applet* icons

ndavis added a subscriber: sitter. ndavis added a comment. @sitter sent me an email saying that it would be better to put the firewall-applet icons into `status/`. He's probably right and it would mean I don't need to make a bunch of pointless symlinks. REPOSITORY R266 Breeze Icons BRANCH

D17033: Change primary monochrome icon colors to match new HIG colors

ndavis created this revision. ndavis added reviewers: VDG, Breeze. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY The old colors were Icon Grey (#4d4d4d) and an undocument white color (#f2f2f2). The

D17033: Change primary monochrome icon colors to match new HIG colors

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17033 To: ndavis, #vdg, #breeze Cc: kde-frameworks-devel, #breeze, #vdg, michaelh, ngraham, bruns

D17033: Change primary monochrome icon colors to match new HIG colors

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17033 To: ndavis, #vdg, #breeze Cc: andreask, kde-frameworks-devel, #breeze, #vdg, michaelh, ngraham, bruns

D16983: Add 48px firewall-applet* icons

ndavis added a comment. In D16983#362552 , @aacid wrote: > These symlinks as they stand are not poinless, they are wrong. > > Icon sets are not "targeting a particular piece of software", icon sets are system wide and any software can ask for

D17062: Fix wrong angle and margin of 32px dialog-ok-apply; new symlinks

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Looks good! D17033 needs to land before this or the two will conflict, but there's nothing you need to do. REPOSITORY R266 Breeze Icons BRANCH fix-

D17033: Change primary monochrome icon colors to match new HIG colors

This revision was automatically updated to reflect the committed changes. Closed by commit R266:53cd19094c8e: Change primary monochrome icon colors to match new HIG colors (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17033?vs=45851

D16983: Add 48px firewall-applet* icons

ndavis updated this revision to Diff 45929. ndavis added a comment. Remove 48px symlinks and move firewall-applet icons to status category REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16983?vs=45746&id=45929 BRANCH firewall-applet-fix-tests (branc

D16983: Add 48px firewall-applet* icons

ndavis added a comment. Anyone opposed to moving the firewall-applet icons into the status category? `status/22` is a scalable directory. If no-one speaks by tomorrow, I'm going to land the patch. REPOSITORY R266 Breeze Icons BRANCH firewall-applet-fix-tests (branched from master) REVI

D16983: Move firewall-applet icons to status category

ndavis retitled this revision from "Add 48px firewall-applet* icons" to "Move firewall-applet icons to status category". ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons BRANCH firewall-applet-fix-tests (branched from master) REVISION DETAIL https://phabricator.kde

D16951: Add mouse button icons

ndavis added a comment. It's been 3 days and no response. It has already been approved by another reviewer, so I'm going to land this now. REPOSITORY R266 Breeze Icons BRANCH mouse-buttons (branched from master) REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg, ngr

D16951: Add mouse button icons

ndavis updated this revision to Diff 45978. ndavis added a comment. Rebase onto master REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16951?vs=45755&id=45978 BRANCH arcpatch-D16951 REVISION DETAIL https://phabricator.kde.org/D16951 AFFECTED FILE

D16951: Add mouse button icons

ndavis added a comment. In D16951#363861 , @nicolasfella wrote: > Looks great! Ah thanks! REPOSITORY R266 Breeze Icons BRANCH arcpatch-D16951 REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg, ngraham, nicolasf

D16951: Add mouse button icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:6976172920e2: Add mouse button icons (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16951?vs=45978&id=45979 REVISION DETAIL https://pha

D16951: Add mouse button icons

ndavis added a comment. I thought I did this already. I rebased onto master, then added the version of the file I wanted, then continued the rebase, then updated the diff. Is there something I missed? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: n

D16951: Add mouse button icons

ndavis added a comment. In D16951#363876 , @nicolasfella wrote: > In D16951#363875 , @ndavis wrote: > > > I thought I did this already. I rebased onto master, then added the version of the file I wa

D16951: Add mouse button icons

ndavis added a comment. In D16951#363879 , @nicolasfella wrote: > In D16951#363878 , @ndavis wrote: > > > Save what or how? Doesn't `arc diff --update D16951` save things? I know I added the right f

D16951: Add mouse button icons

ndavis updated this revision to Diff 45980. ndavis added a comment. Fix conflicts REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16951?vs=45979&id=45980 BRANCH arcpatch-D16951_1 REVISION DETAIL https://phabricator.kde.org/D16951 AFFECTED FILES

D16951: Add mouse button icons

ndavis added a comment. Ok, I see what the issue was. The conflicts are literally stored *in* the file that has the conflict as text, so `dialog-input-devices.svg` was turned into a diff of the old and new versions. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.or

D16951: Add mouse button icons

ndavis updated this revision to Diff 45981. ndavis marked an inline comment as done. ndavis added a comment. Rebase onto master again REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16951?vs=45980&id=45981 BRANCH arcpatch-D16951 REVISION DETAIL ht

D16951: Add mouse button icons

ndavis added a comment. So now I have 2 commits and one of them is already on master, but they're both called "Add mouse button icons" and use the same description. Should I update this diff to describe only the latest commit or make it apply to both? REPOSITORY R266 Breeze Icons BRANCH

D16951: Resolve merge conflict

ndavis retitled this revision from "Add mouse button icons" to "Resolve merge conflict". REPOSITORY R266 Breeze Icons BRANCH arcpatch-D16951 REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect Cc: cfeck, trickyricky26, abetts, ngraham,

D16951: Resolve merge conflict

This revision was automatically updated to reflect the committed changes. Closed by commit R266:2a85454d7a42: Resolve merge conflict (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16951?vs=45981&id=45982 REVISION DETAIL https://pha

D17062: Fix wrong angle and margin of 32px dialog-ok-apply; new symlinks

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Actually, I do need you to do something, but the icons themselves are fine. I need to to rebase this patch onto master. I can walk you through it here or in a chat room if you nee

D17062: Fix angle and margin of 32px dialog-ok-apply

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. All correct! REPOSITORY R266 Breeze Icons BRANCH arcpatch-D17062 REVISION DETAIL https://phabricator.kde.org/D17062 To: trickyricky26, #vdg, #breeze, ndavis Cc: ndavis, kde-framewor

D17062: Fix angle and margin of 32px dialog-ok-apply

This revision was automatically updated to reflect the committed changes. Closed by commit R266:e1375f0efcdf: Fix angle and margin of 32px dialog-ok-apply (authored by trickyricky26, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D170

D16983: Move firewall-applet icons to status category

This revision was automatically updated to reflect the committed changes. Closed by commit R266:7e27acf7e1a8: Move firewall-applet icons to status category (authored by ndavis). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16983?vs=45929&id=46038#toc REPOSITORY R266 Breeze Icons CHA

D11863: Add virt-manager icons

ndavis created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. ndavis requested review of this revision. REVISION SUMMARY 48px color and 22px, 16px monochrome icons for the system tray REPOSITORY R266 Breeze Icons BRAN

D11863: Add virt-manager icons

ndavis added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11863 To: ndavis, #vdg Cc: #frameworks, michaelh, ngraham

D11863: Add virt-manager icons

ndavis added a comment. Screenshot of how they look in use F5780916: Screenshot_20180401_120901.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11863 To: ndavis, #vdg Cc: #frameworks, michaelh, ngraham

D11880: Add firewalld icons

ndavis created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. ndavis requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH firewalld_icons (branched from master) REVISION DETAIL https://phabricator.

D11880: Add firewalld icons

ndavis added a comment. I did not mean to post this and I have no idea how to delete it REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis Cc: #frameworks, michaelh, ngraham

D11880: Add firewalld icons

ndavis edited the summary of this revision. ndavis added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg Cc: #frameworks, michaelh, ngraham

D11880: Add firewalld icons

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg Cc: #frameworks, michaelh, ngraham

D11880: Add firewalld icons

ndavis added a comment. Screenshot of the icons in use F5781576: Screenshot_20180402_035312.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg Cc: #frameworks, michaelh, ngraham

D11880: Add firewalld icons

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg Cc: #frameworks, michaelh, ngraham

D11880: Add firewalld icons

ndavis added a comment. firewall-applet-panic in use F5781583: Screenshot_20180402_041120.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg Cc: #frameworks, michaelh, ngraham

D11863: Add virt-manager icons

ndavis added a comment. In D11863#238210 , @ngraham wrote: > Looks good to me! Nice use of the Breeze icon style. @andreaska? Thank! If the other reviewer takes a long time to respond, do I still have to wait for their permission to land

D11863: Add virt-manager icons

ndavis added a comment. Since I don't have a developer account, can someone land this for me? REPOSITORY R266 Breeze Icons BRANCH virt-manager_icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D11863 To: ndavis, #vdg, ngraham, andreaska, andreask Cc: ngraham, an

D11863: Add virt-manager icons

ndavis added a reviewer: Breeze. REPOSITORY R266 Breeze Icons BRANCH virt-manager_icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D11863 To: ndavis, #vdg, ngraham, andreaska, andreask, #breeze Cc: ngraham, andreaska, #frameworks, michaelh, bruns

D11880: Add firewalld icons

ndavis added a reviewer: Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg, #breeze Cc: #frameworks, michaelh, bruns

D11880: Add firewalld icons

ndavis added a comment. Can someone review this? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg, #breeze Cc: #frameworks, michaelh, bruns

D17220: Use red X in disabled and muted status icons consistently

ndavis added a comment. Could a distinction between "off" and "muted" be useful? If that is true, then we should keep the red horizontal dash for muted and use a red slash through the whole icon for off/disabled. In general, I think a red X should mean "error", but we're not consistent about

D17220: Use red X in disabled and muted status icons consistently

ndavis added a comment. In D17220#367858 , @ngraham wrote: > In D17220#367849 , @ndavis wrote: > > > Here's what the Breeze Plasma desktop theme uses for the `network-wireless-off` icon: F6445522: Sc

D17220: Use red X in disabled and muted status icons consistently

ndavis added a reviewer: ndavis. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17220 To: trickyricky26, #vdg, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17220: Improve symbolism for off and muted status icon

ndavis added a comment. In D17220#368147 , @trickyricky26 wrote: > Should this style then also be applied to other "off" status icons like touchpad and camera? I think so. I'm somewhat concerned that on certain icon designs it could make

D17220: Improve symbolism for off and muted status icon

ndavis added a comment. I'm not sure about this, but I think increasing the size of the red no symbol from 6px to 8px on the 22px mute icon might be a good idea. At 6px, it just seems to lack visual weight. 6px no symbol F6447430: Screenshot_20181129_164625.png

D17220: Improve symbolism for off and muted status icon

ndavis added a comment. Also, the semi-transparent sound waves on the audio icons in the Breeze Plasma theme use 25% opacity, not 50% opacity. I think 25% looks better anyway. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17220 To: trickyricky26, #vdg, ndavis

D17220: Improve symbolism for off and muted status icon

ndavis added a comment. Also, here's the 16px muted icon with the "No" symbol moved out to the right by 1px and then 2px compared to the 16px full volume icon 1px to the right F6447454: Screenshot_20181129_171423.png 2px to the right F6447452:

D15999: Add icons with added background to system.svgz

ndavis added a comment. Could these icons be moved into the breeze-icons repo? That would make it simpler to edit and review these in the future. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15999 To: pstefan, ngraham, #vdg, ndavis Cc: ndavis,

D15999: Add icons with added background to system.svgz

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. It appears that the background colors are hardcoded. If they are meant to be dark with the Breeze Light Plasma theme and light with Breeze Dark, then they should use the `ColorSch

D17253: Fix inconsistent x-office-drawing icon color

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY The 22px `x-office-drawing` mimetype icon had a color that was inconsistent with the other

D17253: Fix inconsistent x-office-drawing icon color

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17253 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17253: Fix inconsistent x-office-drawing icon color

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17253 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17253: Fix inconsistent x-office-drawing icon color

ndavis added a comment. I just ran into 2 other issues. `libreoffice-drawing` has the same consistency problem with the same inconsistent color, but at 16px. I also noticed that the `libreoffice-drawing icons have a color that is the same as or almost the same as the `x-office-drawing`

D17253: Fix inconsistent x-office-drawing icon color

ndavis planned changes to this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17253 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17253: Fix colors for vector image mimetypes

ndavis retitled this revision from "Fix inconsistent x-office-drawing icon color" to "Fix colors for vector image mimetypes". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17253 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

ndavis added a comment. With colorschemes applied, these will be your colors: | Ring| Background | Symbol | | --- | -- | --- | Breeze | #fcfcfc | #eff0f1| #232627 | Breeze Dark | #232629 | #31363b| #eff0f1 | REPOSITOR

<    1   2   3   4   5   6   7   8   9   10   >