D6687: Adding support to ipv*.route-metric

2017-07-17 Thread Paulo Villani
pvillani added a comment. In https://phabricator.kde.org/D6687#125529, @lvsouza wrote: > The summary says this patch adds route metric support to IPv4 too, but no IPv4 file is touched by this patch. Have you missed the IPv4 changes? Added the missing files. Aboute your comment

D6687: Adding support to ipv*.route-metric

2017-07-17 Thread Paulo Villani
pvillani updated this revision to Diff 16836. pvillani added a comment. Adding missing files and making possible to set route-metric as 0, as described in NetworkManager documentation. REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE

D6687: Adding support to ipv*.route-metric

2017-07-14 Thread Paulo Villani
pvillani requested review of this revision. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D6687 To: pvillani, jgrulich, lvsouza Cc: #frameworks

D6687: Adding support to ipv*.route-metric

2017-07-14 Thread Paulo Villani
pvillani added a comment. Done REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D6687 To: pvillani, jgrulich, lvsouza Cc: #frameworks

D6687: Adding support to ipv*.route-metric

2017-07-14 Thread Paulo Villani
pvillani updated this revision to Diff 16697. pvillani retitled this revision from "Adding support to ipv4.route-metric" to "Adding support to ipv*.route-metric". pvillani edited the summary of this revision. pvillani edited the test plan for this revision. pvillani added a comment. Adding

D6687: Adding support to ipv4.route-metric

2017-07-13 Thread Paulo Villani
pvillani edited reviewers, added: lvsouza; removed: Frameworks. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D6687 To: pvillani, jgrulich, lvsouza Cc: #frameworks

D6687: Adding support to ipv4.route-metric

2017-07-13 Thread Paulo Villani
pvillani added a reviewer: Frameworks. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D6687 To: pvillani, jgrulich, #frameworks Cc: #frameworks

D6687: Adding support to ipv4.route-metric

2017-07-13 Thread Paulo Villani
pvillani added a comment. Sorry if something are missing, its my first pull request, let me know if any change are needed. I've tested and it's working fine. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D6687 To: pvillani, jgrulich Cc: #frameworks

D6687: Adding support to ipv4.route-metric

2017-07-13 Thread Paulo Villani
pvillani created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D6687 AFFECTED FILES autotests/settings/ipv4settingtest.cpp