KDE CI SignTool Error: No certificates were found that met all the given criteria.

2021-07-15 Thread Ralf Habacker
Hi building kmymoney releases on KDE CI are currently broken by an installation issue https://binary-factory.kde.org/view/Windows%2064-bit/job/KMyMoney_Release_win64/1081/console. Please fix. Regards Ralf

Re: Fwd: KDE CI: Administration » Dependency Build Applications stable-kf5-qt5 WindowsMSVCQt5.15 - Build # 52 - Still Failing!

2021-07-12 Thread Ralf Habacker
Am 12.07.21 um 09:35 schrieb Ralf Habacker: > >> The fact that you have to apply additional overrides here indicates to >> me that your changes to 'kdewin' are also incorrect. > > It may also be caused by the kdelibs4support package, as I initial > stated - I double ch

Re: Fwd: KDE CI: Administration » Dependency Build Applications stable-kf5-qt5 WindowsMSVCQt5.15 - Build # 52 - Still Failing!

2021-07-12 Thread Ralf Habacker
Am 10.07.21 um 21:00 schrieb Ben Cooksley: > On Sat, Jul 10, 2021 at 9:14 PM Ralf Habacker <mailto:ralf.habac...@freenet.de>> wrote: > > Am 09.07.21 um 21:26 schrieb Ben Cooksley: >> Hi Ralf, >> >> I'm afraid your previous fixes are insuff

Re: Fwd: KDE CI: Administration » Dependency Build Applications stable-kf5-qt5 WindowsMSVCQt5.15 - Build # 52 - Still Failing!

2021-07-10 Thread Ralf Habacker
Am 09.07.21 um 21:26 schrieb Ben Cooksley: Hi Ralf, I'm afraid your previous fixes are insufficient - we are still failing with a linking error. The following is notice that I intend to back all changes out in kdewin and restore the repository to 8503ac6e0e07099c4938cbfe60e3f5e25e2ec368 to

Re: KDE CI: Administration » Dependency Build Extragear stable-kf5-qt5 WindowsMSVCQt5.15 - Build # 53 - Still Failing!

2021-07-09 Thread Ralf Habacker
Am 08.07.21 um 20:17 schrieb Ben Cooksley: Hi Ben, On Fri, Jul 9, 2021 at 1:28 AM Harald Sitter > wrote: comparing the failing build to the last successful one it appears kdewin no longer installs arpa/inet.h which lead me to this commit

D5173: Fix 'Installation of ksendbugmail.exe conflicts with related KDE4 package'.

2020-04-16 Thread Ralf Habacker
habacker added a comment. Looking into the bug report gaves the answer: file /usr/i686-w64-mingw32/sys-root/mingw/bin/ksendbugmail.exe from install of mingw32-libKF5XmlGui5-5.26.0-3.1.noarch conflicts with file from package mingw32-kdelibs4-4.14.60-11.4.noarch For the recored:

D14598: Keep checking return value from calling browse_stat_path() in SMBSlave::stat() in sync with SMBSlave::listDir()

2020-04-05 Thread Ralf Habacker
habacker closed this revision. habacker added a comment. This review request was superseeded by D16272 . REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D14598 To: habacker, dfaure Cc: kde-frameworks-devel, kfm-devel, azyx,

D21660: remove dbus for windows build and change audio dep logic

2019-11-20 Thread Ralf Habacker
habacker added a comment. In D21660#565205 , @cullmann wrote: > That is bad, then this must be fixed. > That should happen on Windows, too. BTW: Does starting slaves on Linux kills started slave after slave timeout occurs, which is

D21660: remove dbus for windows build and change audio dep logic

2019-11-20 Thread Ralf Habacker
habacker added a comment. In D21660#565113 , @cullmann wrote: > No, not really, I fixed that long ago, we auto-detect this and use the KDE_FORK_SLAVES code paths for that > > static bool forkSlaves() but this function is only called

D21660: remove dbus for windows build and change audio dep logic

2019-11-20 Thread Ralf Habacker
habacker added a comment. In D21660#565110 , @cullmann wrote: > kio doesn't require dbus for the normal slave stuff. > It can be that it requires it for the kcookie or auth stuff. klauncher is used to launch kio slaves. In the main()

D21660: remove dbus for windows build and change audio dep logic

2019-11-20 Thread Ralf Habacker
habacker added a comment. In D21660#563560 , @bcooksley wrote: > Considering that D-Bus doesn't really belong on Windows, KDE uses dbus for many internal services. On a recent linux system I see the following KDE services in dbus

D21660: remove dbus for windows build and change audio dep logic

2019-11-16 Thread Ralf Habacker
habacker added a comment. In D21660#563425 , @bcooksley wrote: > If tests launch D-Bus Daemon, then they will cause the CI system to jam as CTest will wait indefinitely for dbus-daemon to exit. There is a fix for this issue, see

D21660: remove dbus for windows build and change audio dep logic

2019-11-16 Thread Ralf Habacker
habacker added a comment. In D21660#481421 , @bcooksley wrote: > With regards to Windows, please note that any unit test which depends on calls that involve D-Bus on the CI system will likely lead to that test hanging because dbus-daemon is

D12283: Allow to load dictionaries form a rcc

2019-10-29 Thread Ralf Habacker
habacker added a comment. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. In D12283#249520 , @vonreth wrote: > While the disk use of the installation goes down the ram usage explodes as QResource doesn't use mmap

D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

2019-10-21 Thread Ralf Habacker
This revision was automatically updated to reflect the committed changes. Closed by commit R313:2d8cba050729: Extend KHtmlView::print() to use a predefined QPrinter instance (authored by habacker). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19504?vs=67894=68479#toc REPOSITORY R313

D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

2019-10-14 Thread Ralf Habacker
habacker updated this revision to Diff 67894. habacker added a comment. - Another attempt after 9 minor releases have elapsed. REPOSITORY R313 KHtml CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19504?vs=53327=67894 BRANCH master REVISION DETAIL

D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

2019-10-14 Thread Ralf Habacker
habacker added a comment. ping ? REPOSITORY R313 KHtml REVISION DETAIL https://phabricator.kde.org/D19504 To: habacker Cc: aacid, tbaumgart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: CI system maintainability

2019-03-30 Thread Ralf Habacker
Am 29.03.19 um 21:01 schrieb Ben Cooksley: > With the shift to Gitlab we should be able to provide this hopefully. > > We're still figuring out how to be able to provide CI in an easy to > maintain manner (in terms of controlling platforms builds are done > for, which branches, etc). In case, an

D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

2019-03-06 Thread Ralf Habacker
habacker updated this revision to Diff 53327. habacker marked an inline comment as done. habacker added a comment. - added @since tag The patch was added to build the stable version of KMyMoney for Windows to fix an issue not been able to have common printer settings. Since KHTML is

D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

2019-03-06 Thread Ralf Habacker
habacker marked an inline comment as done. habacker added inline comments. INLINE COMMENTS > tbaumgart wrote in khtmlview.cpp:3134 > Why don't you pass a reference to the QPrinter object here? Because api dealing with QPrinter always use a pointer. void QWebView::print(QPrinter *) void

D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

2019-03-04 Thread Ralf Habacker
habacker created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. habacker requested review of this revision. REVISION SUMMARY This is required to share printer settings inside an application. BUG:405011 TEST PLAN compile on linux

D17650: Install kioslave.exe as kioslave5.exe under Windows

2018-12-21 Thread Ralf Habacker
habacker added a comment. In D17650#380309 , @habacker wrote: > See this https://bugs.kde.org/show_bug.cgi?id=380139 as example. The different Qt installation layout depending on the platform is a nightmare for cross-platform support and ties

D17650: Install kioslave.exe as kioslave5.exe under Windows

2018-12-21 Thread Ralf Habacker
habacker updated this revision to Diff 47944. habacker retitled this revision from "Install kioslave as kioslave5 on Windows" to "Install kioslave.exe as kioslave5.exe under Windows". habacker edited the summary of this revision. habacker removed subscribers: bcooksley, heikobecker, ngraham,

D17650: Install kioslave as kioslave5 on Windows

2018-12-21 Thread Ralf Habacker
habacker added a comment. In D17650#380277 , @habacker wrote: > and try to fix the related issue or check if some else has fixed it. See this https://bugs.kde.org/show_bug.cgi?id=380139 as example. The different Qt installation layout

D17719: Fix executable name for kioslave on Windows

2018-12-21 Thread Ralf Habacker
habacker created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. habacker requested review of this revision. REVISION SUMMARY FIXED-IN:5.54.0 BUG:377687 also see https://phabricator.kde.org/D17650 REPOSITORY R303 KInit BRANCH master

D17650: Install kioslave as kioslave5 on Windows

2018-12-21 Thread Ralf Habacker
habacker added a comment. In D17650#380272 , @vonreth wrote: > In kde4 we had 104 unmaintained untested applications. > The 6 now are much better supported, in general we only add applications to binary factory if a project asks for it and

D17650: Install kioslave as kioslave5 on Windows

2018-12-21 Thread Ralf Habacker
habacker added a comment. > Why not joining the effort of the people that are working to get those applications on Windows, You did not get the point. If there is anything left over besides the time I have to maintain the KDE applications and libraries, I go through this list

D17650: Install kioslave as kioslave5 on Windows

2018-12-21 Thread Ralf Habacker
habacker added a comment. Yes there are more 'nightly' releases, which is a good thing :-), but there are only about 6 'release' versions https://binary-factory.kde.org/view/Windows%2064-bit/ : 5 https://binary-factory.kde.org/view/Windows%2032-bit/ : 6 and KMyMoney

D17650: Install kioslave as kioslave5 on Windows

2018-12-21 Thread Ralf Habacker
habacker added a comment. > I'd argue that the problem is with your distribution. It is designed in ECM to install mentioned helpers on windows (which are cross compiled packages on obs) in main executable install dir. $ rpm -q -f

D17649: Let docbookl10nhelper executable name follow conventions of checkXML on Windows

2018-12-20 Thread Ralf Habacker
habacker added a comment. On opensuse there are the cross compile helper packages mingw32-cross-kde4-tools mingw32-cross-kf5-tools both containing docbookl10nhelper and nothing prevents them from been installed in parallel REPOSITORY R238 KDocTools REVISION DETAIL

D17650: Install kioslave as kioslave5 on Windows

2018-12-19 Thread Ralf Habacker
habacker added a comment. I think this is unrelated - this request is to fix an issue with an available package on a distribution, so can anyone accept this ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17650 To: habacker, #frameworks, lbeltrame, vonreth Cc:

D17650: Install kioslave as kioslave5 on Windows

2018-12-18 Thread Ralf Habacker
habacker added a comment. The conflict is still presence on opensuse and relates to the packages mingw32-cross-kde4-tools mingw32-cross-kf5-tools REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17650 To: habacker, #frameworks, lbeltrame, vonreth Cc: lbeltrame,

D17650: Install kioslave as kioslave5 on Windows

2018-12-18 Thread Ralf Habacker
habacker added a comment. On opensuse there are the cross compile helper packages mingw32-cross-kde4-tools mingw32-cross-kf5-tools both containing docbookl10nhelper and nothing prevents them from been installed in parallel REPOSITORY R241 KIO REVISION DETAIL

D17650: Install kioslave as kioslave5 on Windows

2018-12-18 Thread Ralf Habacker
habacker added a comment. On a recent opensuse Leap 42.3 or 15.x system there is > /usr/lib64/kde4/libexec/kioslave > /usr/lib64/libexec/kf5/kioslave because the distribution provides kdelibs4 and kio packages. it only does not conflict because the executables are located in

D17650: Install kioslave as kioslave5 on Windows

2018-12-18 Thread Ralf Habacker
habacker added a comment. In D17650#378747 , @lbeltrame wrote: > At this point, I'd rather give my -1 to this. The 4.x kdelibs stack is *long* unmaintained, as well as Qt. What are real, **compelling** reasons to do this? > > EDIT: I know

D17649: Let docbookl10nhelper executable name follow conventions of checkXML on Windows

2018-12-18 Thread Ralf Habacker
habacker added a comment. In D17649#378737 , @ltoscano wrote: > The file is not meant to be installed (unless INSTALL_INTERNAL_TOOLS is exported), and in general it should not exist in the same build root of its kdelibs 4.x counterpart.

D17650: Install kioslave as kioslave5 on Windows

2018-12-18 Thread Ralf Habacker
habacker created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. habacker requested review of this revision. REVISION SUMMARY FIXED-IN:5.54.0 BUG:377687 REPOSITORY R241 KIO BRANCH master REVISION DETAIL

D17649: Let docbookl10nhelper executable name follow conventions of checkXML on Windows

2018-12-18 Thread Ralf Habacker
habacker created this revision. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. habacker requested review of this revision. REVISION SUMMARY FIXED-IN:5.54 BUG:373928 REPOSITORY R238 KDocTools BRANCH master REVISION

D16963: Fix running kdoctools-install autotest without kdoctools installed

2018-11-18 Thread Ralf Habacker
This revision was automatically updated to reflect the committed changes. Closed by commit R238:0a714c220662: Fix running kdoctools-install autotest without kdoctools installed (authored by habacker). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE

D16963: Fix running kdoctools-install autotest without kdoctools installed

2018-11-17 Thread Ralf Habacker
habacker marked an inline comment as done. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D16963 To: habacker, aacid Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D16963: Fix running kdoctools-install autotest without kdoctools installed

2018-11-17 Thread Ralf Habacker
habacker updated this revision to Diff 45690. habacker added a comment. - fix parallel builds REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16963?vs=45685=45690 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16963 AFFECTED FILES

D16963: Fix running kdoctools-install autotest without kdoctools installed

2018-11-17 Thread Ralf Habacker
habacker added a reviewer: aacid. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D16963 To: habacker, aacid Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D16963: Fix running kdoctools-install autotest without kdoctools installed

2018-11-17 Thread Ralf Habacker
habacker created this revision. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. habacker requested review of this revision. REPOSITORY R238 KDocTools BRANCH master REVISION DETAIL https://phabricator.kde.org/D16963

D14785: Fix DialogNativeTest in multi screen configuration

2018-10-10 Thread Ralf Habacker
habacker added a comment. ping REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14785 To: habacker, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14787: Fix 'ThemeTest::testCompositingChange() fails if windows manager is running'

2018-10-10 Thread Ralf Habacker
habacker added a comment. ping REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14787 To: habacker, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15481: Fix 'Impossible to use knsrc file for uploads from non standard location'

2018-09-13 Thread Ralf Habacker
This revision was automatically updated to reflect the committed changes. Closed by commit R304:b6a52eef1ab6: Fix Impossible to use knsrc file for uploads from non standard location (authored by habacker). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D15481: Fix 'Impossible to use knsrc file for uploads from non standard location'

2018-09-13 Thread Ralf Habacker
habacker created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. habacker requested review of this revision. REVISION SUMMARY FIXED-IN:5.51 BUG:397958 TEST PLAN build and did run test case on linux REPOSITORY R304 KNewStuff BRANCH

D14940: kformattest: Use plural suffix (s) consequently

2018-08-25 Thread Ralf Habacker
habacker added a comment. https://forum.wordreference.com/threads/decimals-plural-singular.2054431/#post-10279600 listed many public organisations that are using signular for values between 1 and -1. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D14940 To:

D14940: kformattest: Use plural suffix (s) consequently

2018-08-23 Thread Ralf Habacker
habacker added a comment. I see - Qt lacks support for choosing the correct translation string for floating point values like this: qreal value = 1.0; tr("%n second(s)", nullptr, value). which should return **1.0 second** qreal value = 1.34; tr("%n second(s)",

D14940: kformattest: Use plural suffix (s) consequently

2018-08-22 Thread Ralf Habacker
habacker added a comment. According to the section'Handling of plurals' on http://doc.qt.io/qt-5/i18n-source-translation.html, for plurals an '(s)' is used instead of the 's' as suffx. You are refering to a different spec ? REPOSITORY R244 KCoreAddons REVISION DETAIL

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

2018-08-21 Thread Ralf Habacker
habacker abandoned this revision. habacker added a comment. superseeded by D14967 (tried to updated this review with arc diff, but forgot to add the annoying --verbatim argument to let phabricator know that I have a changed commit message :-/) REPOSITORY

D14967: Disable loading of translations for kformattest, which was not designed with translations

2018-08-21 Thread Ralf Habacker
habacker created this revision. habacker added reviewers: dfaure, aacid. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. habacker requested review of this revision. REVISION SUMMARY Required reviews: D14940 D14966

D14966: Added support for disabling the loading of translations

2018-08-21 Thread Ralf Habacker
habacker created this revision. habacker added reviewers: aacid, dfaure. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. habacker requested review of this revision. REVISION SUMMARY With this commit ecm_create_qm_loader() creates

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

2018-08-21 Thread Ralf Habacker
habacker added a comment. In D14779#311871 , @habacker wrote: > Thanks for this pointer - with this setting the german translation is not fetched anymore. A further look into the windows implementation of the qm loader part

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

2018-08-20 Thread Ralf Habacker
habacker added a comment. Thanks for this pointer - with this setting the german translation is not fetched anymore. But there is still the question open how to deal with plurals with and without installed kcoreaddons language package. I guess running tests without kcoreaddons-lang

D14940: kformattest: Use plural suffix (s) consequently

2018-08-20 Thread Ralf Habacker
habacker updated this revision to Diff 40038. habacker added a comment. - type fix in KFormatTest::formatDecimalDuration - missing plural fix in KFormatPrivate::formatDecimalDuration REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14940?vs=40027=40038

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

2018-08-20 Thread Ralf Habacker
habacker added a comment. In D14779#311511 , @aacid wrote: > Can you please replace your setLocale call in initTestCase for > > void initLocale() > { > setenv("LC_ALL", "en_US.utf-8", 1); Just to inform you: this will not

D14940: kformattest: Use plural suffix (s) consequently

2018-08-20 Thread Ralf Habacker
habacker created this revision. habacker added a reviewer: aacid. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. habacker requested review of this revision. REVISION SUMMARY Mixing plural '(s)' and translated 's' suffix could not be correct. REPOSITORY

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

2018-08-17 Thread Ralf Habacker
habacker added a comment. In D14779#310116 , @aacid wrote: > Did you have that problem when you made ecm not create a translator? no, therefore I created D14778 > > >> What is the drawback

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

2018-08-16 Thread Ralf Habacker
habacker added a comment. With the drawback that the qm file need to be generated on each build and the po file needs to be updated on any translations change in the test app BTW: I tried your approach by 1. downloaded po file from

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

2018-08-15 Thread Ralf Habacker
habacker added a comment. In D14779#308603 , @aacid wrote: > I think that in the test we just need to call > > bool QCoreApplication::installTranslator(QTranslator *translationFile) > > with the location of the fake translation

D14817: Convert manual install test to an autotest

2018-08-15 Thread Ralf Habacker
habacker added a comment. In D14817#309388 , @habacker wrote: > Agreed, as long as there is Qt on Windows not patched to also use unix style path layout, which is the case on OBS but this case should be covered by ECM module

D14817: Convert manual install test to an autotest

2018-08-15 Thread Ralf Habacker
habacker added a comment. In D14817#309370 , @bcooksley wrote: > On Windows the correct path to use is $prefix/bin/data/... as that is what QStandardPaths expects. > The location $prefix/share/ won't work on Windows, so the test will need

D14817: Convert manual install test to an autotest

2018-08-15 Thread Ralf Habacker
habacker added a comment. another option would be to force the install path in the cmake call add_test(kdoctools_install ${CMAKE_CTEST_COMMAND} --build-and-test "${CMAKE_CURRENT_SOURCE_DIR}/kdoctools-install" "${CMAKE_CURRENT_BINARY_DIR}/kdoctools-install"

D14817: Convert manual install test to an autotest

2018-08-15 Thread Ralf Habacker
habacker added a comment. Because test.qmake do not anything about KDE install path layout those pathes need to be specified in the ctest config in autotests/CMakeLists.txt I guess --test-command ${CMAKE_COMMAND} "-DKDE_INSTALL_MANDIR=${KDE_INSTALL_MANDIR}"

D14817: Convert manual install test to an autotest

2018-08-15 Thread Ralf Habacker
habacker added a comment. In D14817#309332 , @bcooksley wrote: > The Windows failure looks like a problem with handling of DESTDIR - probably due to reliance on it being handled by $DESTDIR instead of %DESTDIR% (which is the correct syntax for

D14817: Convert manual install test to an autotest

2018-08-15 Thread Ralf Habacker
habacker added a comment. In D14817#309303 , @bcooksley wrote: > Try removing that and the error it has should show up on your local system I see. Since this problem has been fixed in kdoctools git repo and kdoctools has been rebuilt

D14817: Convert manual install test to an autotest

2018-08-15 Thread Ralf Habacker
habacker added a comment. In D14817#309295 , @habacker wrote: > According to https://cgit.kde.org/kdoctools.git/tree/src/meinproc.cpp#n51 uses meinproc5 qCCritical(KDocToolsLog) - How can this be enabled on KDE CI ? Got it - see

D14817: Convert manual install test to an autotest

2018-08-15 Thread Ralf Habacker
habacker added a comment. In D14817#309281 , @bcooksley wrote: > Dependency Builds triggered to roll it out to all the non Frameworks jobs which have already picked this up. How to do this ? REPOSITORY R238 KDocTools REVISION DETAIL

D14817: Convert manual install test to an autotest

2018-08-15 Thread Ralf Habacker
habacker added a comment. According to https://cgit.kde.org/kdoctools.git/tree/src/meinproc.cpp#n51 uses meinproc5 qCCritical(KDocToolsLog) - How can this be enabled on KDE CI ? REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D14817 To: habacker, ltoscano Cc:

D14817: Convert manual install test to an autotest

2018-08-15 Thread Ralf Habacker
habacker added a comment. In D14817#309285 , @habacker wrote: > Funny, that this works with Qt 5.9 https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.9/ and Qt 5.11 (locally tested) - it only happens with Qt 5.10

D14817: Convert manual install test to an autotest

2018-08-15 Thread Ralf Habacker
habacker added a comment. In D14817#309283 , @habacker wrote: > This is the remaining issue on non Windows KDE CI Qt 5.10 > > https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.10/49/consoleFull > > 07:02:43 cd

D14817: Convert manual install test to an autotest

2018-08-15 Thread Ralf Habacker
habacker added a comment. In D14817#309281 , @bcooksley wrote: > This change has caused CI wide breakage and makes kdoctools unrelocatable. This has been fixed with commit

D14817: Convert manual install test to an autotest

2018-08-15 Thread Ralf Habacker
habacker added a comment. This is the remaining issue on non Windows KDE CI Qt 5.10 https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.10/49/consoleFull 07:02:43 cd "/home/jenkins/workspace/Frameworks kdoctools kf5-qt5 SUSEQt5.10/autotests/kdoctools-install" &&

D14817: Convert manual install test to an autotest

2018-08-14 Thread Ralf Habacker
habacker added a comment. I applied a fix to use absolute pathes. Unfortunally windows builds have an additional issue: > https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20WindowsMSVCQt5.10/36/console 21:26:34 -- Installing: C:/CI/workspace/Frameworks kdoctools kf5-qt5

D14817: Convert manual install test to an autotest

2018-08-14 Thread Ralf Habacker
habacker added a comment. In D14817#308903 , @ltoscano wrote: > This worked with Qt 5.9 on the CI and locally with 5.10 too, but the CI seems to be unhappy for openSUSE/Qt 5.10 and Windows/Qt 5.10 (it works on openSUSE/Qt 5.9 and FreeBSD/Qt

D14817: Convert manual install test to an autotest

2018-08-14 Thread Ralf Habacker
This revision was automatically updated to reflect the committed changes. Closed by commit R238:f0cc8b2ccb4a: Convert manual install test to an autotest (authored by habacker). Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. CHANGED PRIOR TO COMMIT

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

2018-08-14 Thread Ralf Habacker
habacker added a comment. You have remembered that in this case the loader created by ecm_create_qm_loader(kcoreaddons_QM_LOADER kcoreaddons5_qt) must be adjusted to find this - not installed - fake translation by default ? REPOSITORY R244 KCoreAddons REVISION DETAIL

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

2018-08-14 Thread Ralf Habacker
habacker updated this revision to Diff 39684. habacker edited the summary of this revision. habacker added a comment. - after feedback from ecm maintainers the fix could be refactored to not be depending on ecm patch REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D14778: Disable loading of translations when using 'C' locale

2018-08-14 Thread Ralf Habacker
habacker abandoned this revision. habacker added a comment. How to handle single/plural form then ? QString KFormatPrivate::formatDecimalDuration(quint64 msecs, int decimalPlaces) const { ... //: @item:intext %1 is a whole number //~ singular %n millisecond //~ plural

D14787: Fix 'ThemeTest::testCompositingChange() fails if windows manager is running'

2018-08-13 Thread Ralf Habacker
habacker created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. habacker requested review of this revision. REVISION SUMMARY Skip the test in that case and show the reason. BUG: 397418 FIXED-IN: 5.50.0

D14785: Fix DialogNativeTest in multi screen configuration

2018-08-13 Thread Ralf Habacker
habacker created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. habacker requested review of this revision. REVISION SUMMARY On multi screen configuration the x coordinate of the primary screen may not be

D14778: Disable loading of translations when using 'C' locale

2018-08-13 Thread Ralf Habacker
habacker added a comment. Just as info: kcoreaddons uses '(s)' suffix in its internal formating methods (https://cgit.kde.org/kcoreaddons.git/commit/src/lib/util/kformatprivate.cpp?id=ffcd094c1f4716a0d91650608e42017886a0a7e3) which is always translated with or without 's' 'not always

D14778: Disable loading of translations when using 'C' locale

2018-08-13 Thread Ralf Habacker
habacker added a comment. No, both LC_ALL=C and LC_ALL=en fetches the same english translation ~/src/kf5/kcoreaddons-build> LC_ALL=en strace -e trace=file bin/kformattest 2>&1 | grep \.qm | grep R_OK access("/usr/share/locale/en/LC_MESSAGES/kcoreaddons5_qt.qm", R_OK) = 0

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

2018-08-13 Thread Ralf Habacker
habacker created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. habacker requested review of this revision. REVISION SUMMARY See D14778 for the related extra-cmake-modules

D14778: Disable loading of translations when using 'C' locale

2018-08-13 Thread Ralf Habacker
habacker created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. habacker requested review of this revision. REVISION SUMMARY kcoreaddons test case 'kformattest' is designed not to

D9387: Add cross compile support for kconfig_compiler and kconf_update.

2018-08-11 Thread Ralf Habacker
habacker added a comment. Sorry for the two spam comments, I had a freeze at phabricator web site. > Here's the android scripts for reference. https://cgit.kde.org/sysadmin/ci-tooling.git/tree/system-images/android/sdk Ah I see, on Android the packages containing native tools are

D9387: Add cross compile support for kconfig_compiler and kconf_update.

2018-08-10 Thread Ralf Habacker
habacker added a comment. In D9387#180530 , @apol wrote: > Yes, defining KF5_HOST_TOOLING should be enough, kconf_update will need to be exported with kconfigcompiler though, at the moment it's not. that means host tooling support

D9387: Add cross compile support for kconfig_compiler and kconf_update.

2018-08-10 Thread Ralf Habacker
habacker added a comment. The KF5_HOST_TOOLING approach in kconfig does not work because it is not poss In D9387#180530 , @apol wrote: > Yes, defining KF5_HOST_TOOLING should be enough, kconf_update will need to be exported with

D9387: Add cross compile support for kconfig_compiler and kconf_update.

2018-08-10 Thread Ralf Habacker
habacker added a comment. The KF5_HOST_TOOLING approach in kconfig does not work because it is not poss In D9387#180530 , @apol wrote: > Yes, defining KF5_HOST_TOOLING should be enough, kconf_update will need to be exported with

D9387: Add cross compile support for kconfig_compiler and kconf_update.

2018-08-09 Thread Ralf Habacker
habacker added a comment. In D9387#305685 , @dfaure wrote: > > I don't know much about all this, but it sounds like Aleix is saying that an existing solution also works and is simpler. Please show me that solution with a

D9387: Add cross compile support for kconfig_compiler and kconf_update.

2018-08-09 Thread Ralf Habacker
habacker added a comment. This patch is used at https://build.opensuse.org/package/show/home:rhabacker:branches:windows:mingw:win32:KF547/mingw32-kconfig https://build.opensuse.org/package/show/home:rhabacker:branches:windows:mingw:win64:KF547/mingw64-kconfig for about a year

D13743: Migrate build system to use find_package in autotests/ki18n_install

2018-08-09 Thread Ralf Habacker
This revision was automatically updated to reflect the committed changes. Closed by commit R249:507415c54bd1: Migrate build system to use find_package in autotests/ki18n_install (authored by habacker). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13743?vs=38569=39339#toc REPOSITORY

D9387: Add cross compile support for kconfig_compiler and kconf_update.

2018-08-09 Thread Ralf Habacker
habacker added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. ping REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D9387 To: habacker, dfaure, ltoscano, bcooksley, apol Cc: kde-frameworks-devel, apol,

D13743: Migrate build system to use find_package in autotests/ki18n_install

2018-08-09 Thread Ralf Habacker
habacker added a comment. In D13743#304127 , @dfaure wrote: > I don't understand either, what does this fix? The macro file is intended to be used by client packages and is normally fetched by KI18nConfig.cmake, which is provided with

D13743: Migrate build system to use find_package in autotests/ki18n_install

2018-08-09 Thread Ralf Habacker
habacker added a comment. In D13743#298834 , @apol wrote: > Looks good to me, I don't really see why it's better though... This way you can find problems that are normally detected by client packages simply by running make test

D14550: Install kio related kdebugsettings category file

2018-08-04 Thread Ralf Habacker
This revision was automatically updated to reflect the committed changes. Closed by commit R241:64a775722689: Install kio related kdebugsettings category file (authored by habacker). Restricted Application added a project: Frameworks. Restricted Application added a subscriber:

D13743: Migrate build system to use find_package in autotests/ki18n_install

2018-07-27 Thread Ralf Habacker
habacker updated this revision to Diff 38569. habacker added a comment. - rebased REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13743?vs=36708=38569 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13743 AFFECTED FILES CMakeLists.txt

D13744: Let ki18n macro file name follow style of other find_package related files

2018-07-27 Thread Ralf Habacker
This revision was automatically updated to reflect the committed changes. Closed by commit R249:382cf9ca29ad: Let ki18n macro file name follow style of other find_package related files (authored by habacker). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13744?vs=38567=38568#toc

D13744: Let ki18n macro file name follow style of other find_package related files

2018-07-27 Thread Ralf Habacker
habacker updated this revision to Diff 38567. habacker added a comment. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. - rebased REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE

  1   2   3   4   >