Re: libkonq release? I'm missing the favicons interface

2016-02-16 Thread Robby Stephenson
On Tue, Feb 16, 2016 at 5:00 PM, David Faure wrote: > I'm curious though, what's the use case for a large favicon? In KDE4 the > only > time I see this is when using Alt+Tab and with konqueror windows open (and > that > looks a bit weird because other apps have a much bigger icon

Re: libkonq release? I'm missing the favicons interface

2016-02-15 Thread Robby Stephenson
On Sat, Feb 6, 2016 at 10:21 AM, David Faure wrote: > Unaware of this discussion (no time to read kde-devel), I have done exactly > this during January. KIO (starting from 5.19) now has a KIOGui library > with a > FavIconRequestJob, which removes the dependency on the kded module

Re: Review Request 125681: Correctly set the printSetting's parent

2015-10-20 Thread Robby Stephenson
marked as submitted. Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. Changes --- Submitted with commit ea06177577e0eb53d047e7249ae9e3a92c040e5b by Robby Stephenson to branch master. Repository: khtml Description --- Avoid setting printSettings as its own

Re: Review Request 125681: Correctly set the printSetting's parent

2015-10-18 Thread Robby Stephenson
in KDE4. Diffs (updated) - src/khtmlview.cpp d9bbc38b1677a3faf3be46ccc3a211c8d7289e45 Diff: https://git.reviewboard.kde.org/r/125681/diff/ Testing --- Tellico's printing (which uses KHTMLPart) no longer hangs, but works properly. Thanks, Robby Stephenson

Review Request 125681: Correctly set the printSetting's parent

2015-10-17 Thread Robby Stephenson
/125681/diff/ Testing --- Tellico's printing (which uses KHTMLPart) no longer hangs, but works properly. Thanks, Robby Stephenson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 125681: Correctly set the printSetting's parent

2015-10-17 Thread Robby Stephenson
------ On Oct. 18, 2015, 1:13 a.m., Robby Stephenson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125681/ > ---