Re: Breeze widget style for KF5

2014-08-18 Thread Sebastian Kügler
On Monday, August 11, 2014 12:29:05 Hugo Pereira Da Costa wrote: Comments, objections, blessings, are welcome After using it daily for about a week, I can say I'm really happy about it. It feels fast, well-done (even if some bits are missing, not complete yet), and gives me an impression of

Re: Kitemviews

2014-08-12 Thread Sebastian Kügler
On Tuesday, August 12, 2014 17:42:24 Albert Astals Cid wrote: El Dimarts, 12 d'agost de 2014, a les 08:18:40, Valorie Zimmerman va escriure: Martin Klapetek suggested that Kitemviews would be a useful framework to include in our book. However, I can find no documentation *anywhere.*

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

2014-07-31 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/#review63563 --- On July 29, 2014, 6:04 p.m., Sebastian Kügler wrote

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

2014-07-31 Thread Sebastian Kügler
/qmlcontrols/kcoreaddons/kuserproxy.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119535/diff/ Testing --- Ported an (unreleased) app using this class to the new location, works as expected, no regressions encountered. Thanks, Sebastian Kügler

Re: Review Request 119542: create qapplication before using dbus

2014-07-30 Thread Sebastian Kügler
://git.reviewboard.kde.org/r/119542/#comment44263 s/ahve/have - Sebastian Kügler On July 30, 2014, 12:43 a.m., Harald Sitter wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119542

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

2014-07-29 Thread Sebastian Kügler
: https://git.reviewboard.kde.org/r/119535/diff/ Testing --- Ported an (unreleased) app using this class to the new location, works as expected, no regressions encountered. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

2014-07-29 Thread Sebastian Kügler
--- On July 29, 2014, 2:31 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535

Re: Review Request 118889: Use new Konqui in the about Dialog

2014-06-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118889/#review60784 --- Ship it! Ship It! - Sebastian Kügler On June 22, 2014, 8

Re: Review Request 118366: Porting keyboard module to Framework5

2014-06-23 Thread Sebastian Kügler
uploaded contains intermediate changes, and makes it really hard to read. We're just interested in the difference between current version and your result. - Sebastian Kügler On June 20, 2014, 9:24 p.m., shivam makkar wrote

Re: Review Request 118716: New Translations KCM

2014-06-15 Thread Sebastian Kügler
applications. File Attachments KCM in systemsettings https://git.reviewboard.kde.org/media/uploaded/files/2014/06/13/28a00558-f671-4f39-bfe3-ca9dca8e98ce__tranlationskcm.png Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing

Re: Review Request 118716: New Translations KCM

2014-06-15 Thread Sebastian Kügler
and console applications. File Attachments KCM in systemsettings https://git.reviewboard.kde.org/media/uploaded/files/2014/06/13/28a00558-f671-4f39-bfe3-ca9dca8e98ce__tranlationskcm.png Thanks, Sebastian Kügler ___ Kde-frameworks

Re: Review Request 118716: New Translations KCM

2014-06-15 Thread Sebastian Kügler
://git.reviewboard.kde.org/media/uploaded/files/2014/06/13/28a00558-f671-4f39-bfe3-ca9dca8e98ce__tranlationskcm.png Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: Review Request 118716: New Translations KCM

2014-06-13 Thread Sebastian Kügler
? - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716/#review59954 --- On June 13, 2014, 2:31 a.m., Sebastian Kügler

Re: Review Request 118716: New Translations KCM

2014-06-13 Thread Sebastian Kügler
--- On June 13, 2014, 2:31 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716

Re: Review Request 118716: New Translations KCM

2014-06-13 Thread Sebastian Kügler
the translation of systemsettings, see http://api.kde.org/frameworks-api/frameworks5-apidocs/ki18n/html/classKLocalizedString.html#ad866b11bf396b9d93b7dc313a1930b7b Sebastian Kügler wrote: Hm, then we might need this one, after all: https://git.reviewboard.kde.org/r/118678

Re: Review Request 118716: New Translations KCM

2014-06-13 Thread Sebastian Kügler
the translation of systemsettings, see http://api.kde.org/frameworks-api/frameworks5-apidocs/ki18n/html/classKLocalizedString.html#ad866b11bf396b9d93b7dc313a1930b7b Sebastian Kügler wrote: Hm, then we might need this one, after all: https://git.reviewboard.kde.org/r/118678

Re: Review Request 118639: KCMultiDialog: Fix crash when clicking OK

2014-06-12 Thread Sebastian Kügler
the values in the formats KCM work. The virtual desktop config doesn't crash for me without this patch, so can't confirm that this condition is fixed as well. - Sebastian Kügler On June 10, 2014, 8:45 p.m., Aurélien Gâteau wrote

Review Request 118716: New Translations KCM

2014-06-12 Thread Sebastian Kügler
languages (x-test, others), re-logged in, languages correctly set up for KF5 and console applications. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118716: New Translations KCM

2014-06-12 Thread Sebastian Kügler
/2014/06/13/28a00558-f671-4f39-bfe3-ca9dca8e98ce__tranlationskcm.png Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Plasma 5 Beta 2 tars

2014-06-11 Thread Sebastian Kügler
[CC:ing frameworks-devel, hoping for additional input] On Friday, June 06, 2014 23:24:50 šumski wrote: On Friday 06 of June 2014 21:32:48 Eric Hameleers wrote: On Fri, 6 Jun 2014, ?umski wrote: On Thursday 05 of June 2014 16:47:59 Jonathan Riddell wrote: Tars are up for Plasma 5 Beta 2,

Re: Review Request 118630: [KQuickControls] Consider Super_L and Super_R as modifiers

2014-06-10 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118630/#review59659 --- On June 9, 2014, 10:04 p.m., Sebastian Kügler wrote

Re: Review Request 118630: [KQuickControls] Consider Super_L and Super_R as modifiers

2014-06-10 Thread Sebastian Kügler
--- Tested assigning Meta + L to digital clock plasmoid, works with the patch, doesn't work without (displays garbage like in the linked bugreport). Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Review Request 118630: [KQuickControls] Consider Super_L and Super_R as modifiers

2014-06-09 Thread Sebastian Kügler
work without (displays garbage like in the linked bugreport). Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118581: Consider Super_L and Super_R as modifiers

2014-06-09 Thread Sebastian Kügler
., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118581/ --- (Updated June 6, 2014, 12:39 a.m.) Review

Review Request 118581: Consider Super_L and Super_R as modifiers

2014-06-05 Thread Sebastian Kügler
b6fcd207a1d18466f4a747e1a0b4b58107c82871 Diff: https://git.reviewboard.kde.org/r/118581/diff/ Testing --- Tried to assign meta + something in global shortcuts KCM, fails without patch (see screenshot in the linked bugreport), works correctly with patch. Thanks, Sebastian Kügler

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-27 Thread Sebastian Kügler
/2014/05/26/93b91b9b-5c22-42d3-be03-6c30e5709ba3__titlewidget-ss-1.2.png Example at 1.4x https://git.reviewboard.kde.org/media/uploaded/files/2014/05/26/3b2b6c38-c431-4a01-be73-3cb4c3c9006e__titlewidget-ss-1.4.png Thanks, Sebastian Kügler

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-27 Thread Sebastian Kügler
/93b91b9b-5c22-42d3-be03-6c30e5709ba3__titlewidget-ss-1.2.png Example at 1.4x https://git.reviewboard.kde.org/media/uploaded/files/2014/05/26/3b2b6c38-c431-4a01-be73-3cb4c3c9006e__titlewidget-ss-1.4.png Thanks, Sebastian Kügler ___ Kde-frameworks-devel

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-26 Thread Sebastian Kügler
/2014/05/24/616bebac-2bed-4427-9190-02f22d798801__titlewidget-kate-after.png Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-26 Thread Sebastian Kügler
/media/uploaded/files/2014/05/24/616bebac-2bed-4427-9190-02f22d798801__titlewidget-kate-after.png Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-26 Thread Sebastian Kügler
--- On May 26, 2014, 10 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118289

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-26 Thread Sebastian Kügler
-before.png titlewidget in kate (after) https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/616bebac-2bed-4427-9190-02f22d798801__titlewidget-kate-after.png Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-26 Thread Sebastian Kügler
-c431-4a01-be73-3cb4c3c9006e__titlewidget-ss-1.4.png Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-26 Thread Sebastian Kügler
-5c22-42d3-be03-6c30e5709ba3__titlewidget-ss-1.2.png Example at 1.4x https://git.reviewboard.kde.org/media/uploaded/files/2014/05/26/3b2b6c38-c431-4a01-be73-3cb4c3c9006e__titlewidget-ss-1.4.png Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-25 Thread Sebastian Kügler
://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/616bebac-2bed-4427-9190-02f22d798801__titlewidget-kate-after.png Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Review Request 118289: Change titlewidget from bold to increased font size

2014-05-23 Thread Sebastian Kügler
/uploaded/files/2014/05/24/a3ce0956-4339-495e-9775-e9625b4e0311__titlewidget-kate-before.png titlewidget in kate (after) https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/616bebac-2bed-4427-9190-02f22d798801__titlewidget-kate-after.png Thanks, Sebastian Kügler

Re: Review Request 118019: Update X11 app timestamp before activating window

2014-05-07 Thread Sebastian Kügler
--- Implemented handler in systemsettings, verified that the window is raised on second start. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KDE Frameworks Release Cycle

2014-05-07 Thread Sebastian Kügler
On Monday, May 05, 2014 11:11:53 Martin Klapetek wrote: However this highly depends on the distro policies - if some of the big distros say we will not update KF5 every month because our policies, then the 6 months buffer is just moved elsewhere, at the distro level because they will update

Review Request 118019: Update X11 app timestamp before activating window

2014-05-06 Thread Sebastian Kügler
in systemsettings, verified that the window is raised on second start. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118019: Update X11 app timestamp before activating window

2014-05-06 Thread Sebastian Kügler
in systemsettings, verified that the window is raised on second start. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118019: Update X11 app timestamp before activating window

2014-05-06 Thread Sebastian Kügler
--- On May 6, 2014, 3:52 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118019/ --- (Updated May 6

Re: Review Request 118019: Update X11 app timestamp before activating window

2014-05-06 Thread Sebastian Kügler
/CMakeLists.txt 7c0c485 src/config-kdbusaddons.h.cmake PRE-CREATION src/kdbusservice.cpp 4239e85 Diff: https://git.reviewboard.kde.org/r/118019/diff/ Testing --- Implemented handler in systemsettings, verified that the window is raised on second start. Thanks, Sebastian Kügler

Re: Review Request 118019: Update X11 app timestamp before activating window

2014-05-06 Thread Sebastian Kügler
--- On May 6, 2014, 9:23 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118019

Re: Fwd: KDE Frameworks Release Cycle

2014-04-28 Thread Sebastian Kügler
On Sunday, April 27, 2014 15:55:07 Albert Astals Cid wrote: El Diumenge, 27 d'abril de 2014, a les 15:15:32, David Faure va escriure: FYI. Interesting fact here that original the mail was just sent to k-f-d and k-c-d. I am seeing similar patterns in the plasma land, where they went their

Re: Review Request 117161: Drop QApplication usages in units.cpp

2014-03-30 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117161/#review54589 --- Ship it! Ship It! - Sebastian Kügler On March 29, 2014, 7

Re: Review Request 116928: Default to not launching kded

2014-03-20 Thread Sebastian Kügler
? Just removing it and going it can be started is not good enough, we need it, we know that, and we don't want to introduce regressions in the workspace. - Sebastian Kügler On March 20, 2014, 3:04 p.m., Alex Merry wrote

Re: Plasma Next + Apps view on build.kde.org

2014-03-19 Thread Sebastian Kügler
On Wednesday, March 19, 2014 03:07:27 Aurélien Gâteau wrote: Just a quick note to let you know I created a new view on build.kde.org which groups the jobs from Plasma Next and the available KF5 applications. You can find it here: http://build.kde.org/view/Plasma%20Next%20+%20Apps/ I hope

kglobalaccel fixes

2014-03-11 Thread Sebastian Kügler
A quick heads-up: I'm looking into what's broken in our global shortcuts. Here's a quick run-down of my findings so far: kglobalaccel has some brokenness in it. It used to poke into the privates of KGlobalShortcutInfo in order to create its own object in a cast. This code is disabled right now

Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-10 Thread Sebastian Kügler
. With this patch, it works. Can we get this in, please? :) - Sebastian Kügler On March 10, 2014, 2 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116696

Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-10 Thread Sebastian Kügler
On March 10, 2014, 2:59 p.m., Aurélien Gâteau wrote: Strange, it works fine here. Which version of CMake are you using and which repository is failing? Aurélien Gâteau wrote: Oh, version is in the request title. /me tests with 2.8. Aurélien Gâteau wrote: Just tried with

Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-10 Thread Sebastian Kügler
: cmake version 2.8.12.2 Aurélien Gâteau wrote: You still haven't answered the second part: which repository? Sebastian Kügler wrote: In my case, cmake-git (built with kdesrc-build). Aurélien Gâteau wrote: I meant: which framework fails to build? Aleix Pol Gonzalez wrote

Re: c++ plugins with Frameworks 5

2014-03-04 Thread Sebastian Kügler
On Tuesday, March 04, 2014 09:22:11 David Faure wrote: What I don't know is how much do we need support for queries that filter this further, and whether just reading the json from all the plugins of type foo is good enough. In my tests it was expectedly slow: scaling linearly with number of

Re: Review Request 115840: Rename Platform to Frameworks in both about dialogs

2014-02-21 Thread Sebastian Kügler
-004ea7bdb654__aboutdialog.png Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115909: Remove unused dependency from krunner

2014-02-21 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115909/#review50475 --- Ship it! Ship It! - Sebastian Kügler On Feb. 20, 2014, 12

Re: Review Request 115840: Rename Platform to Frameworks in both about dialogs

2014-02-19 Thread Sebastian Kügler
to a user. Yes to us and the informed developers it's clear, but from a user perspective I think development platform might be the better term to use. In the same way we didn't call it kdelibs there before the switch to frameworks. Sebastian Kügler wrote: Ah, maybe a bit of rationale, I

Review Request 115840: Rename Platform to Frameworks in both about dialogs

2014-02-17 Thread Sebastian Kügler
kwrite, new names appear correctly. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115840: Rename Platform to Frameworks in both about dialogs

2014-02-17 Thread Sebastian Kügler
-004ea7bdb654__aboutdialog.png Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115840: Rename Platform to Frameworks in both about dialogs

2014-02-17 Thread Sebastian Kügler
://git.reviewboard.kde.org/r/115840/#review50091 --- On Feb. 17, 2014, 7:04 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: let's get ready for Google Summer of Code 2014

2014-02-11 Thread Sebastian Kügler
On Monday, February 10, 2014 16:21:34 Mark Gaiser wrote: On Mon, Feb 10, 2014 at 4:13 PM, Vishesh Handa m...@vhanda.in wrote: On Monday, February 10, 2014 01:54:36 PM Mark Gaiser wrote: Done: http://community.kde.org/GSoC/2014/Ideas#Revive_KioFuse.2C_fuse_support_f or _KIO Lets

Review Request 115650: Add networkmanagement and plasmate to workspace source build for KF5

2014-02-11 Thread Sebastian Kügler
-build Description --- Adds the repos for plasma-nm, libnm-qt and plasmate to kdesrc-build's KF5 workspace definitions. Diffs - kf5-workspace-build-include ca9ba0c Diff: https://git.reviewboard.kde.org/r/115650/diff/ Testing --- Built it, and it built. Thanks, Sebastian

Re: Review Request 115650: Add networkmanagement and plasmate to workspace source build for KF5

2014-02-11 Thread Sebastian Kügler
://git.reviewboard.kde.org/r/115650/diff/ Testing --- Built it, and it built. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: let's get ready for Google Summer of Code 2014

2014-02-11 Thread Sebastian Kügler
On Tuesday, February 11, 2014 11:03:39 Myriam Schweingruber wrote: On Tue, Feb 11, 2014 at 10:56 AM, Sebastian Kügler se...@kde.org wrote: On Monday, February 10, 2014 16:21:34 Mark Gaiser wrote: On Mon, Feb 10, 2014 at 4:13 PM, Vishesh Handa m...@vhanda.in wrote: No, certainly not. I

Review Request 115682: Add krunner to the workspace build

2014-02-11 Thread Sebastian Kügler
--- Built successfully using kdesrc-build krunner Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115682: Add krunner to the workspace build

2014-02-11 Thread Sebastian Kügler
6b0b638fe6f61e2589ea17c9a83d557efc7bb55d Diff: https://git.reviewboard.kde.org/r/115682/diff/ Testing --- Built successfully using kdesrc-build krunner Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 115605: Rename plasmapkg

2014-02-10 Thread Sebastian Kügler
weird in the Plasma context. (Most of the other visible Plasma bits carry version 2.0). - Sebastian Kügler On Feb. 9, 2014, 7:45 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 115605: Rename plasmapkg

2014-02-10 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115605/#review49433 --- Ship it! Ship It! - Sebastian Kügler On Feb. 10, 2014, 11

Re: Splitting kde-workspace and kde-runtime proposal

2014-01-21 Thread Sebastian Kügler
On Tuesday, January 21, 2014 11:03:57 Bhushan Shah wrote: On Tue, Jan 21, 2014 at 1:19 AM, Àlex Fiestas afies...@kde.org wrote: In the plasma sprint we have done a session to plan what we are going to do with kde-workspace/kde-runtime repositories, here is the proposal we came with.

Re: Review Request 115063: Created missing manpage for desktoptojson binary

2014-01-17 Thread Sebastian Kügler
hasn't really settled down yet, adding a sentence like this would probably be enough already: For further reference how to use this programme and its underlying mechanism, please refer to the documentation for the KPluginTrader class in KDE's KService framework. - Sebastian Kügler

Re: Frameworks Performance Question

2013-12-31 Thread Sebastian Kügler
On Monday, December 30, 2013 12:54:20 Christoph Cullmann wrote: On Sunday 29 December 2013 20:07:38 Christoph Cullmann wrote: #10 0x73fbeaa0 in KConfig::reparseConfiguration (this=0x688130) at /home/cullmann/local/kf5/src/frameworks/kconfig/src/core/kconfig.cpp:633 #11

Re: Fwd: Tracking bugs in Frameworks

2013-12-16 Thread Sebastian Kügler
On Monday, December 16, 2013 19:30:25 Martin Graesslin wrote: On Monday 16 December 2013 19:01:25 David Edmundson wrote: On Mon, Dec 16, 2013 at 6:08 PM, Martin Graesslin mgraess...@kde.org On Monday 16 December 2013 11:58:35 David Edmundson wrote: I think if we did that it would be a

Re: error: KF5::KDBusAddons-NOTFOUND

2013-11-19 Thread Sebastian Kügler
On Monday, November 18, 2013 19:00:33 Sebastian Kügler wrote: On Monday, November 18, 2013 17:53:07 Aleix Pol wrote: On Mon, Nov 18, 2013 at 5:43 PM, Sebastian Kügler se...@kde.org wrote: It seems subject broke over the weekend. kactivities fails to compile: c++: error: KF5

Re: error: KF5::KDBusAddons-NOTFOUND

2013-11-19 Thread Sebastian Kügler
On Tuesday, November 19, 2013 15:42:47 Sebastian Kügler wrote: On Tuesday, November 19, 2013 12:48:53 Stephen Kelly wrote: Try to construct a trivial testcase using one of the targets. If that fails, post it. If it passes, bisect the difference to kactivities. I've attached a bare example

Re: error: KF5::KDBusAddons-NOTFOUND

2013-11-19 Thread Sebastian Kügler
On Tuesday, November 19, 2013 17:01:32 Aleix Pol wrote: Maybe you have different CMAKE_BUILD_TYPE in kdelibs and other build directories? I'm using the same command for them all: cmake -DCMAKE_INSTALL_PREFIX=$KF5 -DCMAKE_PREFIX_PATH=$KF5 - DCMAKE_SYSTEM_PREFIX_PATH=/usr:/usr/local:${KF5} -

error: KF5::KDBusAddons-NOTFOUND

2013-11-18 Thread Sebastian Kügler
It seems subject broke over the weekend. kactivities fails to compile: c++: error: KF5::KDBusAddons-NOTFOUND: No such file or directory kactivities uses: find_package (KF5 CONFIG REQUIRED KDBusAddons) so it's pretty bare-bones. Could someone have a look or suggest a fix? Thanks, -- sebas

Re: KDE workspace users

2013-11-15 Thread Sebastian Kügler
Hey, On Thursday, November 14, 2013 18:50:35 Jonathan Riddell wrote: With KDE Frameworks taking shape and sceenshots of Plasma 2 starting to appear it's worth looking at what else will need to be done to allow distros to ship it all. kde-runtime needs ported and there's a desire to move its

Use kde-runtime[frameworks]!

2013-11-07 Thread Sebastian Kügler
Hey all, In order to achieve more consistency across repositories, we've renamed the branch frameworks-scratch to frameworks in kde-runtime. Please do not push to frameworks-scratch anymore. (Ben, could you block this branch, if it hasn't already happened?). So, all commits go into the

Re: KEmailSettings and ksendbugmail

2013-11-04 Thread Sebastian Kügler
On Monday, November 04, 2013 12:15:50 Kevin Ottens wrote: KEmailSettings definitely belongs to a core library, not to a gui one. OK then. I still think that semantically, it'd fit better in something more PIM or desktop consistency related... but since I can't find anything where it'd

Re: Getting ecm files from the ECM package

2013-11-01 Thread Sebastian Kügler
On Friday, November 01, 2013 11:57:35 Kevin Ottens wrote: Then it is time to think of a way to integrate cmake with the separate source of find_modules. Algorithmically, it would look like PROJECT(MyApplication) FIND_MODULES_REPOSITORY(http://ecm.kde.org;) FIND_PACKAGES(KF5

Re: Build failed in Jenkins: plasma-framework_master_qt5 #862

2013-10-28 Thread Sebastian Kügler
On Monday, October 28, 2013 17:27:14 Marco Martin wrote: On Monday 28 October 2013 17:12:20 Kevin Ottens wrote: On Monday 28 October 2013 16:07:08 KDE CI System wrote: See http://build.kde.org/job/plasma-framework_master_qt5/862/ If someone has an idea about that failure on build.kde.org

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

2013-10-24 Thread Sebastian Kügler
On Oct. 24, 2013, 4:17 p.m., Fredrik Höglund wrote: What's the cold startup time like for KSplashQML compared to KSplashX? Let's not forget that the reason KPlash was rewritten to only depend on X + libjpeg + libpng was so that the startup time would be limited by the time it takes

Re: Review Request 113377: Add KDeclarative to known KF5 tier3 modules

2013-10-23 Thread Sebastian Kügler
... KDeclarative) works with this patch, it doesn't work without. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

DBusMenuQt cmake *Config

2013-10-22 Thread Sebastian Kügler
Hi Aurelien, Let's try again to finally get this resolved. :) Attached, the necessary cmake foo to have find_package(DBusMenuQt NO_MODULE) work like other frameworks do. The .diff should work, but someone had problems applying it during testing, so I've attached the whole files as well.

Review Request 113377: Add KDeclarative to known KF5 tier3 modules

2013-10-21 Thread Sebastian Kügler
-cmake-modules Description --- Subject says it all. Diffs - find-modules/FindKF5.cmake 8f95469 Diff: http://git.reviewboard.kde.org/r/113377/diff/ Testing --- find_package(KF5 ... KDeclarative) works with this patch, it doesn't work without. Thanks, Sebastian Kügler

Re: Review Request 113300: Improve porting to Qt/KF5 scripts

2013-10-17 Thread Sebastian Kügler
-edit cycles. - Sebastian Kügler On Oct. 17, 2013, 5:01 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113300

Re: Review Request 113181: Add KDebug porting notes to KDE5PORTING.html

2013-10-17 Thread Sebastian Kügler
On Oct. 16, 2013, 9:02 p.m., Mark Gaiser wrote: KDE5PORTING.html, lines 290-295 http://git.reviewboard.kde.org/r/113181/diff/2/?file=201374#file201374line290 This is not valid anymore. It should now be qCdebug/warning/notice/... and with a category. I think it;s best to just

Re: Helping out with Frameworks 5

2013-10-16 Thread Sebastian Kügler
Hi Casian, On Wednesday, October 16, 2013 14:35:39 Casian Andrei wrote: I want to help out with Frameworks 5 and/or Plasma 2. Perhaps it is best to start writing some unit tests, since I am not too familiar with the code. My favorite activities include removing chunks of obsolete and ugly

Re: Review Request 113215: Fix casing in KPty cmake vars

2013-10-13 Thread Sebastian Kügler
., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113215/ --- (Updated Oct. 12, 2013, 6:55 p.m.) Review

Re: Review Request 113215: Fix casing in KPty cmake vars

2013-10-13 Thread Sebastian Kügler
--- Fixes a cmake error when trying to build konsole. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113215: Fix casing in KPty cmake vars

2013-10-12 Thread Sebastian Kügler
--- KPTY_ vars were set as uppercase, while camelcase is in line with frameworks. Diffs - tier3/kpty/KPtyConfig.cmake.in a59bce8 Diff: http://git.reviewboard.kde.org/r/113215/diff/ Testing --- Fixes a cmake error when trying to build konsole. Thanks, Sebastian Kügler

KNotifyConfig cmake vars problem

2013-10-12 Thread Sebastian Kügler
Hey, I'm trying to build konsole, which requires KNotifyConfig, but I'm having trouble importing the target. When applying the attached patch to KNotifyConfig (which I believe should add the right variables), I'm getting CMake Error at /home/sebas/kf5/install/lib/x86_64-linux-

Re: Review Request 113215: Fix casing in KPty cmake vars

2013-10-12 Thread Sebastian Kügler
--- Fixes a cmake error when trying to build konsole. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

plasma-framework build broken

2013-10-12 Thread Sebastian Kügler
Hi Steve, It seems that one of your recent commits to plasma-frameworks broke its build: /home/sebas/kf5/src/plasma- framework/src/declarativeimports/qtextracomponents/tests/columnproxymodeltest.cpp:23:23: fatal error: qtest_kde.h: No such file or directory Readding the things you removed

Re: plasma-framework build broken

2013-10-12 Thread Sebastian Kügler
On Saturday, October 12, 2013 21:48:28 Sebastian Kügler wrote: It seems that one of your recent commits to plasma-frameworks broke its build: /home/sebas/kf5/src/plasma- framework/src/declarativeimports/qtextracomponents/tests/columnproxymodeltes t.cpp:23:23: fatal error: qtest_kde.h

Re: KNotifyConfig cmake vars problem

2013-10-12 Thread Sebastian Kügler
On Saturday, October 12, 2013 14:29:19 Stephen Kelly wrote: Sebastian Kügler wrote: Hey, I'm trying to build konsole, which requires KNotifyConfig, but I'm having trouble importing the target. Update your ecm, and konsole repos and discard your patch. It is not needed. Thanks

Re: Review Request 113179: Make the runners compile again

2013-10-10 Thread Sebastian Kügler
be committed, as it's not going to cause merge conflicts. - Sebastian Kügler On Oct. 8, 2013, 5:14 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113179

Re: kio-related build error in plasma-framework

2013-10-10 Thread Sebastian Kügler
On Friday, October 04, 2013 17:56:52 Sebastian Kügler wrote: I'm getting a build error in a few places in plasma-framework, kio isn't found. I can't seem to figure out why, maybe someone who has a better overview of what in KIO is where, and what I need to tell cmake to figure this out

Re: Review Request 112929: Remove KPluginVerificationData

2013-10-09 Thread Sebastian Kügler
rid of it. Diffs - staging/kservice/src/plugin/kexportplugin.h 216923e staging/kservice/src/plugin/kpluginloader.cpp 91a3857 Diff: http://git.reviewboard.kde.org/r/112929/diff/ Testing --- It builds, the warning is gone. Thanks, Sebastian Kügler

libnm-qt Qt5 port: -fPIC or fPIE needed?

2013-10-09 Thread Sebastian Kügler
Hi, While porting libnm-qt to Qt5, I'm running into the following problem when building the tests. I've not seen this error before, and I'd like advice how to fix it. [ 59%] Building CXX object tests/CMakeFiles/test_8021xsetting.dir/8021xsetting.cpp.o In file included from

Re: [Kde-hardware-devel] libnm-qt Qt5 port: -fPIC or fPIE needed?

2013-10-09 Thread Sebastian Kügler
On Wednesday, October 09, 2013 18:14:10 Daniel Nicoletti wrote: I have added this to some of my qt5 projects and it worked: add_definitions(-fPIC) Thanks Daniel, that helps. :) 2013/10/9 Sebastian Kügler se...@kde.org: /home/sebas/kf5/qt5/qtbase/include/QtCore/../../src/corelib/global

kf5_add_kdeinit_executable broken?

2013-10-08 Thread Sebastian Kügler
Hi, in Kwin (kde-workspace) we're running into the following error: CMake Error: File /home/sebas/kf5/src/kde- workspace/kwin/kcmkwin/kwinrules/_KDE5INIT_DUMMY_FILEPATH-NOTFOUND does not exist. CMake Error at /home/sebas/kf5/install/lib64/cmake/KInit/KInitMacros.cmake:17 (configure_file):

Re: Review Request 112880: Added KColorSchemeToken class.

2013-10-08 Thread Sebastian Kügler
On Oct. 1, 2013, 2:47 p.m., Sebastian Kügler wrote: kdeui/colors/kcolorschemetoken.h, line 70 http://git.reviewboard.kde.org/r/112880/diff/6/?file=192050#file192050line70 using int here loses the type-safety. Why no use the corresponding enums? It would also make the code more

<    1   2   3   4   5   >