Re: Review Request 114989: kapidox and other components from frameworks should use kde5-config instead of kde4-config, remove kde4 references

://git.reviewboard.kde.org/r/114989/diff/ Testing --- Thanks, Siddharth Sharma ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114987: khtml and other components from frameworks should use kde5_install , remove kde4 refs

--- None Thanks, Siddharth Sharma ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114991: I think frameworks 5 should use kde5 based emoticons ? , though i am not sure changing it now would make any sense o_O ? would leave up to reviewers

Diff: https://git.reviewboard.kde.org/r/114991/diff/ Testing --- none Thanks, Siddharth Sharma ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114990: removing kde4 references from kauth

discarded. Review request for KDE Frameworks. Repository: kauth Description --- removing kde4 references from kauth Diffs - src/kauthactionreply.h a7d2020 Diff: https://git.reviewboard.kde.org/r/114990/diff/ Testing --- none Thanks, Siddharth Sharma

Re: Review Request 114990: removing kde4 references from kauth

Thanks looking into porting guide , will do legitimate requests next time. :) ~siddharth On Mon, Jan 13, 2014 at 6:15 PM, Alex Merry wrote: > On 13/01/14 12:41, Siddharth Sharma wrote: > > so basically of all yesterdays review requests, were to know if things > > would chang

Re: Review Request 114990: removing kde4 references from kauth

e5_install_auth_actions( ) > > I'm sure no such macro exists. Have a look in > kauth/cmake/KF5AuthMacros.cmake for what it should become. > > > - Alex Merry > > On January 12th, 2014, 8:12 p.m. UTC, Siddharth Sharma wrote: > Review request for KDE Frameworks. >

Review Request 114991: I think frameworks 5 should use kde5 based emoticons ? , though i am not sure changing it now would make any sense o_O ? would leave up to reviewers

, Siddharth Sharma ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 114990: removing kde4 references from kauth

--- removing kde4 references from kauth Diffs - src/kauthactionreply.h a7d2020 Diff: https://git.reviewboard.kde.org/r/114990/diff/ Testing --- none Thanks, Siddharth Sharma ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Review Request 114989: kapidox and other components from frameworks should use kde5-config instead of kde4-config, remove kde4 references

--- kapidox and other components from frameworks should use kde5-config instead of kde4-config, remove kde4 references Diffs - src/doxygen-preprocess-kcfg.sh 567a248 Diff: https://git.reviewboard.kde.org/r/114989/diff/ Testing --- Thanks, Siddharth Sharma

Re: Review Request 114987: khtml and other components from frameworks should use kde5_install , remove kde4 refs

Diffs - tests/pics/CMakeLists.txt 3d2f8d5 Diff: https://git.reviewboard.kde.org/r/114987/diff/ Testing --- None Thanks, Siddharth Sharma ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Review Request 114987: khtml and other components from frameworks should use kde5-config , remove kde4 refs

--- khtml and other components from frameworks should use kde5-config , remove kde4 refs Diffs - tests/pics/CMakeLists.txt 3d2f8d5 Diff: https://git.reviewboard.kde.org/r/114987/diff/ Testing --- None Thanks, Siddharth Sharma ___ Kde

Re: Review Request 114917: KDE Frameworks 5 should have kde5rc naming convention instead of kde4rc

/diff/ Testing --- Thanks, Siddharth Sharma ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114917: KDE Frameworks 5 should have kde5rc naming convention instead of kde4rc

--- Thanks, Siddharth Sharma ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 114917: KDE Frameworks 5 should have kde5rc naming convention instead of kde4rc

--- KDE Frameworks 5 should have kde5rc naming convention instead of kde4rc Diffs - docs/README.kiosk 4974ace src/core/kconfig.cpp 4f5553d Diff: https://git.reviewboard.kde.org/r/114917/diff/ Testing --- Thanks, Siddharth Sharma

Re: TODO: Reduce the mentions of KDE4 in the source code to those that are correct/needed

Aha :) , Ok on it On Wed, Jan 8, 2014 at 1:20 AM, David Faure wrote: > On Wednesday 08 January 2014 01:17:50 Siddharth Sharma wrote: > > Hiya Folks, > > > > I want to give a helping hand to that task, hence added my name. So if i > > understood correctly do

TODO: Reduce the mentions of KDE4 in the source code to those that are correct/needed

Hiya Folks, I want to give a helping hand to that task, hence added my name. So if i understood correctly does it needs to be done with kde4support, i mean kde4support -> kf5support ? Regards, Siddharth Sharma ___ Kde-frameworks-devel mailing list

Re: KF5 Update Meeting Minutes 2014-w2

Hello, I am also looking to maintain a project, if there is something where i can help. I would try to join the meeting. Regards, Siddharth Sharma On Tue, Jan 7, 2014 at 9:23 PM, Kevin Ottens wrote: > Hello everyone, > > This is the minutes of the Week 48 KF5 meeting. As usu