D26342: Allow overriding to disable auto language detection

sdepiets added a comment. Please see below proposal to restore the previous default behavior https://invent.kde.org/frameworks/sonnet/-/merge_requests/1 REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D26342 To: sdepiets, #frameworks, cullmann, mlaurent, mludwig,

D26342: Allow overriding to disable auto language detection

sdepiets added a comment. In D26342#675142 , @dfaure wrote: > This actually breaks language auto-detection for me in the KMail composer. > > Testcase: > > - New Mail > - I type "Bonjour," in the body > > Before: It's detected as

D26342: Allow overriding to disable auto language detection

sdepiets updated this revision to Diff 81177. sdepiets added a comment. Bump since + autotest checks the language as well REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26342?vs=81176=81177 BRANCH master REVISION DETAIL

D26342: Allow overriding to disable auto language detection

sdepiets updated this revision to Diff 81176. sdepiets added a comment. - Merge branch 'master' of git.kde.org:sonnet REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26342?vs=76992=81176 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26342

D26342: Allow overriding to disable auto language detection

sdepiets added a comment. In D26342#623729 , @aacid wrote: > Would it make sense to enshrine this behaviour with an autotest? Sorry what do you mean by that? Similar to tests/BackgroundTest.cpp ? REPOSITORY R246 Sonnet REVISION DETAIL

D26342: Allow overriding to disable auto language detection

sdepiets added a comment. I don't see a use case where you would want to set the Language, but then let the system override it (and only if the user has auto-detection). I left the option in the API to "setAutoDetectLanguageDisabled" to false, for instance if you are not sure which

D26342: Allow overriding to disable auto language detection

sdepiets updated this revision to Diff 76992. sdepiets added a comment. Disable autodetect on language change REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26342?vs=74851=76992 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26342

D26342: Allow overriding to disable auto language detection

sdepiets added a reviewer: mludwig. sdepiets added a comment. Can we get some traction on this? It's a relatively light change that doesn't affect the default Sonnet behavior. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D26342 To: sdepiets, #frameworks,

D26342: Allow overriding to disable auto language detection

sdepiets added reviewers: cullmann, mlaurent. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D26342 To: sdepiets, #frameworks, cullmann, mlaurent Cc: mludwig, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26342: Allow overriding to disable auto language detection

sdepiets added a comment. In D26342#585867 , @mludwig wrote: > I'd support such a change for the BackgroundChecker as well. KTextEditor needs a way to do its own language detection or override the detected language. I've updated the diff

D26342: Allow overriding to disable auto language detection

sdepiets updated this revision to Diff 74851. sdepiets added a comment. Allow overriding to disable auto language detection in BackGround Checker REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26342?vs=72540=74851 BRANCH master REVISION DETAIL

D26342: Allow overriding to disable auto language detection

sdepiets edited the summary of this revision. sdepiets added a reviewer: Frameworks. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D26342 To: sdepiets, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26342: Allow overriding to disable auto language detection

sdepiets created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sdepiets requested review of this revision. REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D26342 AFFECTED FILES src/ui/highlighter.cpp

D18424: Instantiate QApplication before KCrash/KCatalog

sdepiets closed this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18424 To: sdepiets, #baloo, bruns, poboiko, mlaurent Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18424: Instantiate QApplication before KCrash/KCatalog

sdepiets edited the summary of this revision. sdepiets added a reviewer: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18424 To: sdepiets, #baloo Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18424: Instantiate QApplication before KCrash/KCatalog

sdepiets created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. sdepiets requested review of this revision. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D18424 AFFECTED FILES

D15686: Prevent highlighter from erasing selected text

sdepiets closed this revision. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D15686 To: sdepiets, #framework_syntax_highlighting, mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15686: Prevent highlighter from erasing selected text

sdepiets updated this revision to Diff 42121. sdepiets added a comment. Coding style REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15686?vs=42120=42121 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15686 AFFECTED FILES

D15686: Prevent highlighter from erasing selected text

sdepiets edited the summary of this revision. sdepiets added reviewers: Framework: Syntax Highlighting, mlaurent, dfaure. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D15686 To: sdepiets, #framework_syntax_highlighting, mlaurent, dfaure Cc: kde-frameworks-devel,

D15686: Prevent highlighter from erasing selected text

sdepiets created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sdepiets requested review of this revision. REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D15686 AFFECTED FILES src/ui/highlighter.cpp

D14938: Force ki18n to build with the libintl.so path

sdepiets added a comment. In D14938#325850 , @sars wrote: > If I understand the comments correct it assumes that if we use a libc that already has what we need, we don't need to use a separate library for it. Correct me if I'm wrong, but

D14938: Force ki18n to build with the libintl.so path

sdepiets added a comment. In D14938#325850 , @sars wrote: > If I understand the comments correct it assumes that if we use a libc that already has what we need, we don't need to use a separate library for it. Correct me if I'm wrong, but