D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi added a comment. In D27951#645212 , @meven wrote: > I might take over to finish it eventually. Yes, please. I'm very glad that you support this. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27951 To: trm

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi abandoned this revision. trmdi added a comment. In D27951#641173 , @meven wrote: > In D27951#639386 , @trmdi wrote: > > > In D27951#639350 , @meven wr

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi added a comment. In D27951#639350 , @meven wrote: > Anything that concerns a kdeconnet:/ url is handled by the kdeconnect ioslave, including the stat call made in `KIO::StatJob`. > It is in the kdeconnect code base, the issue you point t

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi added a comment. In D27951#637690 , @meven wrote: > Look into kde connect kioslave. > That does not concern this diff much though. I don't understand this. I'm using KMountPoint to check if source and dest are on the same partion

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi added a comment. In D27951#637038 , @dfaure wrote: > Indeed. Bug in kio_file, fixed in D28388 . Ok, it works for symlinks now. How about normal files in a KDE Connect's mountpoint? It still have

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi added a comment. In D27951#636980 , @dfaure wrote: > Seems to work for symlinks here. We *don't* want it to follow symlinks, right? > > I have /opt a symlink to /d/opt, where /d is on another partition > > $ kioclient5 openPropertie

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi added a comment. In D27951#636646 , @dfaure wrote: > Note sure how you're testing UDS_* but you need to pass KIO::StatInode to KIO::statDetails for inode and device ID to be filled in. > > Testcase: apply http://www.davidfaure.fr/2020/u

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi updated this revision to Diff 78691. trmdi added a comment. Improve the logic a bit. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27951?vs=78427&id=78691 BRANCH add-dndToMove (branched from master) REVISION DETAIL https://phabricator.kde.org/D2795

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi added a comment. In D27951#635596 , @dfaure wrote: > Symlinks are a bit special, we could add a way to ask kio_file not to follow them. > > But at least it should work for regular files and directories, right? > > Anyhow, we don't h

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi added a comment. In D27951#633820 , @dfaure wrote: > Implementation note: the fastest way to know if two items are on the same partition is to compare KIO::UDSEntry::UDS_DEVICE_ID values. But unfortunately it looks like this code takes URL

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi updated this revision to Diff 78427. trmdi added a comment. Improve the symlink case, any symlink is considered as on the same device with any destination. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27951?vs=78426&id=78427 BRANCH add-dndToMove (br

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi added inline comments. INLINE COMMENTS > davidedmundson wrote in dropjob.cpp:286 > Why QStorageInfo? We're in kio. There's a KMountPoint which is similar > > I suspect this is a recursive list up the tree resolving symlinks. This will > mean blocking stat calls, so this somewhat undermine

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi updated this revision to Diff 78426. trmdi marked 2 inline comments as done. trmdi added a comment. - Always move files if all of them are symlinks - Use KMountPoint REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27951?vs=77511&id=78426 BRANCH add-dn

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi added a comment. Friendly ping. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27951 To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson Cc: elvisangelaccio, davidedmundson, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi added a comment. In D27951#627849 , @elvisangelaccio wrote: > > With dndToMove=true in kdeglobals, drag&drop files will move them without showing the menu. (holding Shift shows it) > > Are we going to expose this setting in Plasma?

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi added a comment. In D27951#627283 , @ngraham wrote: > My interpretation of the use case is that a user who chooses dndToMove prefers Move over Copy and Link, but not necessarily Extract or Set as Wallpaper, since those are context-specific

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi added a comment. In D27951#627041 , @ngraham wrote: > In D27951#626346 , @trmdi wrote: > > > When drop an image to the desktop in the FolderView layout, there would be no menu, so users can not

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi updated this revision to Diff 77511. trmdi added a comment. Minor improvement REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27951?vs=77508&id=77511 BRANCH add-dndToMove (branched from master) REVISION DETAIL https://phabricator.kde.org/D27951 AFFE

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi edited the summary of this revision. trmdi edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27951 To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson Cc: davidedmundson, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, m

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi updated this revision to Diff 77508. trmdi added a comment. Allow to explicitly show the menu when holding Shift REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27951?vs=77433&id=77508 BRANCH add-dndToMove (branched from master) REVISION DETAIL https

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi added a comment. In D27951#626135 , @ngraham wrote: > it needs more discussion first... When drop an image to the desktop in the FolderView layout, there would be no menu, so users can not change the wallpaper in this case. How do y

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi added a comment. In D27951#625881 , @ngraham wrote: > Excellent. The behavior seems correct to me now. There are a few more issues I've like to bring up: > > - While dragging, the cursor always shows a "copying" icon, even though with

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi updated this revision to Diff 77433. trmdi added a comment. Apply only when all the sources and the dest are on a same device. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27951?vs=77391&id=77433 BRANCH add-dndToMove (branched from master) REVISION

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi updated this revision to Diff 77391. trmdi added a comment. Code style REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27951?vs=77390&id=77391 BRANCH add-dndToMove (branched from master) REVISION DETAIL https://phabricator.kde.org/D27951 AFFECTED FI

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi updated this revision to Diff 77390. trmdi added a comment. Code style REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27951?vs=77389&id=77390 BRANCH add-dndToMove (branched from master) REVISION DETAIL https://phabricator.kde.org/D27951 AFFECTED FI

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi updated this revision to Diff 77389. trmdi added a comment. Apply only when all items are local. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27951?vs=77351&id=77389 BRANCH add-dndToMove (branched from master) REVISION DETAIL https://phabricator.k

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi added a comment. In D27951#625470 , @ngraham wrote: > However dragging a URL still doesn't show the menu; it just downloads the entire page. We need the drop menu in this case because it's probably more common to want to create a link to t

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi updated this revision to Diff 77351. trmdi added a comment. Move comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27951?vs=77350&id=77351 BRANCH add-dndToMove (branched from master) REVISION DETAIL https://phabricator.kde.org/D27951 AFFECTED

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi retitled this revision from "Allow users to change dropAction to MoveAction through workspace kcm" to "Allow users to change dropAction to MoveAction through kdeglobals". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27951 To: trmdi, ngraham, dfaure, meven Cc: meve

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27951 To: trmdi, ngraham, dfaure, meven Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27951: Allow users to change dropAction to MoveAction through workspace kcm

trmdi updated this revision to Diff 77350. trmdi added a comment. Address meven's comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27951?vs=77349&id=77350 BRANCH add-dndToMove (branched from master) REVISION DETAIL https://phabricator.kde.org/D27951

D27951: Allow users to change dropAction to MoveAction through workspace kcm

trmdi retitled this revision from "Allow users to change dropAction to MoveAction through workspace-option kcm" to "Allow users to change dropAction to MoveAction through workspace kcm". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27951 To: trmdi, ngraham, dfaure, meve

D27951: Allow users to change dropAction to MoveAction through workspace-option kcm

trmdi marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27951 To: trmdi, ngraham, dfaure, meven Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27951: Allow users to change dropAction to MoveAction through workspace-option kcm

trmdi updated this revision to Diff 77349. trmdi added a comment. Move fileItem back to the local scope REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27951?vs=77329&id=77349 BRANCH add-dndToMove (branched from master) REVISION DETAIL https://phabricator.

D27951: Allow users to change dropAction to MoveAction through workspace-option kcm

trmdi updated this revision to Diff 77329. trmdi added a comment. - Check possible actions in determineDropAction REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27951?vs=77298&id=77329 BRANCH add-dndToMove (branched from master) REVISION DETAIL https://ph

D27961: GIT_SILENT Upgrade ECM and KF5 version requirements for 5.68.0 release.

trmdi created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trmdi requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D27961 AFFECTED FILES CMakeLists.txt src/widgets/dro

D27961: GIT_SILENT Upgrade ECM and KF5 version requirements for 5.68.0 release.

trmdi abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27961 To: trmdi Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27951: Allow users to change dropAction to MoveAction through workspace-option kcm

trmdi planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27951 To: trmdi, ngraham, dfaure Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27951: Allow users to change dropAction to MoveAction through workspace-option kcm

trmdi edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27951 To: trmdi, ngraham, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27951: Allow users to change dropAction to MoveAction through workspace-option kcm

trmdi added reviewers: ngraham, dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27951 To: trmdi, ngraham, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27951: Allow users to change dropAction to MoveAction through workspace-option kcm

trmdi created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trmdi requested review of this revision. REVISION SUMMARY Lots of users request to be able to change the default behavior of the drag&drop action to MoveAction. TEST PLAN With dn

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

trmdi added a comment. Hmm, I think you need to rebase to remove unrelated files in this patch e.g. `dropjob.cpp` ... ? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham, cblack Cc: trmdi, cblack, ndavis, filipf,

D26691: Optimize code when dropping files into the desktop

trmdi added a comment. In D26691#605802 , @jjazeix wrote: > Compilation fails: https://build.kde.org/view/Failing/job/Plasma/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/288/console > Missing the new file in the CMakeLists.txt (https://cgit.

D26691: Optimize code when dropping files into the desktop

This revision was automatically updated to reflect the committed changes. Closed by commit R242:f8be3ea7102f: Optimize code when dropping files into the desktop (authored by trmdi). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26691?vs=746

D26691: Optimize code when dropping files into the desktop

trmdi added a comment. @mart Do you have any objection? REPOSITORY R242 Plasma Framework (Library) BRANCH improve-file-drop-menu (branched from master) REVISION DETAIL https://phabricator.kde.org/D26691 To: trmdi, #plasma, mart, broulik, #vdg, davidedmundson Cc: davidedmundson, anth

D26691: Optimize code when dropping files into the desktop

trmdi updated this revision to Diff 74672. trmdi added a comment. - Rebase REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26691?vs=74036&id=74672 BRANCH improve-file-drop-menu (branched from master) REVISION DETAIL https://phabricat

D26484: Add KIO::DropJobFlag to allow manually showing the menu

trmdi added a dependent revision: D26514: Delay popup for containments. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure Cc: ngraham, broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, m

D26691: Optimize code when dropping files into the desktop

trmdi edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH improve-file-drop-menu REVISION DETAIL https://phabricator.kde.org/D26691 To: trmdi, #plasma, mart, broulik, #vdg, davidedmundson Cc: davidedmundson, anthonyfieroni, #plasma, kde-frameworks-devel,

D26691: Optimize code when dropping files into the desktop

trmdi marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) BRANCH improve-file-drop-menu REVISION DETAIL https://phabricator.kde.org/D26691 To: trmdi, #plasma, mart, broulik, #vdg, davidedmundson Cc: davidedmundson, anthonyfieroni, #plasma, kde-frameworks-devel, Le

D26691: Optimize code when dropping files into the desktop

trmdi updated this revision to Diff 74036. trmdi marked 2 inline comments as done. trmdi added a comment. - Address comment REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26691?vs=74030&id=74036 BRANCH improve-file-drop-menu REVISION

D26691: Optimize code when dropping files into the desktop

trmdi marked 3 inline comments as done. trmdi added inline comments. INLINE COMMENTS > davidedmundson wrote in containmentinterface.cpp:548 > can you be sure urls has at least 1 at this point? Yes, because all `clearDataForMimeJob` are called from inside of `mimeTypeRetrieved` which is only cal

D26691: Optimize code when dropping files into the desktop

trmdi updated this revision to Diff 74030. trmdi added a comment. - Code style REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26691?vs=74025&id=74030 BRANCH improve-file-drop-menu REVISION DETAIL https://phabricator.kde.org/D26691

D26691: Optimize code when dropping files into the desktop

trmdi updated this revision to Diff 74025. trmdi added a comment. - Handle the case in which the menu is not shown REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26691?vs=73815&id=74025 BRANCH improve-file-drop-menu REVISION DETAIL

D26691: Optimize code when dropping files into the desktop

trmdi added inline comments. INLINE COMMENTS > davidedmundson wrote in dropmenu.cpp:48 > where does this menu get deleted? It seems to leak It is set to be deleted on close, at line 43. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26691 To: trmdi

D26691: Optimize code when dropping files into the desktop

trmdi updated this revision to Diff 73815. trmdi added a comment. - Add DropMenu class to combine choices/dropjobMenu - Only 1 menu can be created - Fix some possible memory leaks REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26691?v

D26691: Optimize code when dropping files into the desktop

trmdi updated this revision to Diff 73716. trmdi added a comment. - Change the cursor to the busy state when the first file is not local REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26691?vs=73694&id=73716 BRANCH improve-file-drop-me

D26691: Optimize code when dropping files into the desktop

trmdi updated this revision to Diff 73694. trmdi marked an inline comment as done. trmdi added a comment. - Remove unneeded code REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26691?vs=73693&id=73694 BRANCH improve-file-drop-menu REVI

D26691: Optimize code when dropping files into the desktop

trmdi marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26691 To: trmdi, #plasma, mart, broulik, #vdg Cc: anthonyfieroni, #plasma, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26691: Optimize code when dropping files into the desktop

trmdi updated this revision to Diff 73693. trmdi added a comment. - Remove unneeded code REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26691?vs=73634&id=73693 BRANCH improve-file-drop-menu REVISION DETAIL https://phabricator.kde.or

D26691: Optimize code when dropping files into the desktop

trmdi added reviewers: broulik, VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26691 To: trmdi, #plasma, mart, broulik, #vdg Cc: anthonyfieroni, #plasma, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26691: Optimize code when dropping files into the desktop

trmdi edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26691 To: trmdi, #plasma, mart Cc: #plasma, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26691: Optimize code when dropping files into the desktop

trmdi edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26691 To: trmdi, #plasma, mart Cc: #plasma, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26691: Optimize code when dropping files into the desktop

trmdi edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26691 To: trmdi, #plasma, mart Cc: #plasma, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26691: Optimize code when dropping files into the desktop

trmdi retitled this revision from "[WIP] Optimize code when dropping files into the desktop" to "Optimize code when dropping files into the desktop". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26691 To: trmdi, #plasma, mart Cc: #plasma, kde-frame

D26691: [WIP] Optimize code when dropping files into the desktop

trmdi edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26691 To: trmdi, #plasma, mart Cc: #plasma, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26691: [WIP] Optimize code when dropping files into the desktop

trmdi added reviewers: Plasma, mart. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26691 To: trmdi, #plasma, mart Cc: #plasma, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26691: [WIP] Optimize code when dropping files into the desktop

trmdi edited the summary of this revision. trmdi added a subscriber: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26691 To: trmdi Cc: #plasma, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26691: [WIP] Optimize code when dropping files into the desktop

trmdi created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trmdi requested review of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH improve-file-drop-menu REVISION DETAIL https://phabricator.kde.org/D26691 AFFECTED F

D26484: Add KIO::DropJobFlag to allow manually showing the menu

This revision was automatically updated to reflect the committed changes. Closed by commit R241:fbb2be9aad19: Add KIO::DropJobFlag to allow manually showing the menu (authored by trmdi). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26484?vs=73399&id=73400 REVIS

D26484: Add KIO::DropJobFlag to allow manually showing the menu

trmdi updated this revision to Diff 73399. trmdi added a comment. - Comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26484?vs=73364&id=73399 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26484 AFFECTED FILES src/widgets/dropjob.cpp

D26484: Add KIO::DropJobFlag to allow manually showing the menu

trmdi updated this revision to Diff 73364. trmdi added a comment. - Typo REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26484?vs=73363&id=73364 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26484 AFFECTED FILES src/widgets/dropjob.cpp sr

D26484: Add KIO::DropJobFlag to allow manually showing the menu

trmdi marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure Cc: ngraham, broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26484: Add KIO::DropJobFlag to allow manually showing the menu

trmdi updated this revision to Diff 73363. trmdi added a comment. - Improve comment/doc REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26484?vs=73337&id=73363 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26484 AFFECTED FILES src/widgets/d

D26484: Add KIO::DropJobFlag to allow manually showing the menu

trmdi edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure Cc: ngraham, broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26484: Add KIO::DropJobFlag to allow manually showing the menu

trmdi retitled this revision from "Add KIO::DropJobFlag flag and DropJob::menuPopup()" to "Add KIO::DropJobFlag to allow manually showing the menu". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure

D26484: Add KIO::DropJobFlag flag and DropJob::menuPopup()

trmdi retitled this revision from "Add KIO::DelayPopup flag and DropJob::menuPopup()" to "Add KIO::DropJobFlag flag and DropJob::menuPopup()". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure Cc: ngr

D26484: Add KIO::DelayPopup flag and DropJob::menuPopup()

trmdi updated this revision to Diff 73337. trmdi added a comment. - Move the flag to DropJob header, rename REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26484?vs=73273&id=73337 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26484 AFFECTED F

D26484: Add KIO::DelayPopup flag and DropJob::menuPopup()

trmdi marked 5 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure Cc: ngraham, broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26484: Add KIO::DelayPopup flag and DropJob::menuPopup()

trmdi retitled this revision from "Popup menu again to reposition it" to "Add KIO::DelayPopup flag and DropJob::menuPopup()". trmdi edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangela

D26484: Popup menu again to reposition it

trmdi updated this revision to Diff 73273. trmdi added a comment. - use the flag approach and add DropJob::menuPopup() REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26484?vs=73175&id=73273 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26484

D26484: Popup menu again to reposition it

trmdi added inline comments. INLINE COMMENTS > elvisangelaccio wrote in dropjob.cpp:415 > `QCursor::pos()` should be avoided as it's not reliable on wayland. > > The whole "popup() again" here looks like a workaround to me. Can't this be > fixed on the plasma side? > Can't this be fixed on the

D26484: Popup menu again to reposition it

trmdi added inline comments. INLINE COMMENTS > elvisangelaccio wrote in dropjob.cpp:415 > `QCursor::pos()` should be avoided as it's not reliable on wayland. > > The whole "popup() again" here looks like a workaround to me. Can't this be > fixed on the plasma side? I'm having a plan to make it

D26484: Popup menu again to reposition it

trmdi added a comment. In D26484#591782 , @dfaure wrote: > Sorry I have no idea about the calling side in plasma. It sounds buggy indeed, if those are all calls on the same DropJob instance. Yes, you could check it here: https://phabrica

D26484: Popup menu again to reposition it

trmdi added a comment. @mart @dfaure I have some question. 1, Should `DropJob::setApplicationActions()` be called only one time? 2, I see this when I drop multiple file types at once to the desktop (e.g. 2 jpg and 1 zip), the `DropJob::setApplicationActions()` is called 3 times as fo

D26484: Popup menu again to reposition it

trmdi retitled this revision from "Add a new parameter for delaying showing menu" to "Popup menu again to reposition it". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure Cc: broulik, anthonyfieroni,

D26484: Add a new parameter for delaying showing menu

trmdi removed a dependent revision: D26514: Delay popup for containments. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D26484: Add a new parameter for delaying showing menu

trmdi edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26484: Add a new parameter for delaying showing menu

trmdi updated this revision to Diff 73175. trmdi added a comment. - Simplify the approach REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26484?vs=73114&id=73175 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26484 AFFECTED FILES src/widgets

D26484: Add a new parameter for delaying showing menu

trmdi planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26484: Add a new parameter for delaying showing menu

trmdi updated this revision to Diff 73114. trmdi added a comment. - Improve code - Improve code REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26484?vs=73113&id=73114 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26484 AFFECTED FILES src

D26484: Add a new parameter for delaying showing menu

trmdi updated this revision to Diff 73113. trmdi added a comment. - Improve code REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26484?vs=73112&id=73113 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26484 AFFECTED FILES src/core/job_base.h

D26484: Add a new parameter for delaying showing menu

trmdi updated this revision to Diff 73112. trmdi added a comment. - Remove the new signal and show a "Fetching data" menu while delaying REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26484?vs=73076&id=73112 BRANCH master REVISION DETAIL https://phabricat

D26484: Add a new parameter for delaying showing menu

trmdi planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26484: Add a new parameter for delaying showing menu

trmdi edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26484: Add a new parameter for delaying showing menu

trmdi marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26484: Add a new parameter for delaying showing menu

trmdi updated this revision to Diff 73076. trmdi added a comment. - Move delayPopup to JobFlag REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26484?vs=73030&id=73076 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26484 AFFECTED FILES src/co

D26484: Add a new parameter for delaying showing menu

trmdi marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26484: Add a new parameter for delaying showing menu

trmdi updated this revision to Diff 73030. trmdi added a comment. - Add a new function instead of changing the old exported one REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26484?vs=72975&id=73030 BRANCH master REVISION DETAIL https://phabricator.kde.or

D26484: Add a new parameter for delaying showing menu

trmdi added a dependent revision: D26514: Delay popup for containments. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26484: Add a new parameter for delaying showing menu

trmdi edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

  1   2   >