D18628: [server] Generate correct touch ids

This revision was automatically updated to reflect the committed changes. Closed by commit R127:e167526d0bdb: [server] Generate correct touch ids (authored by zzag). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18628?vs=50599=50606 REVISION DETAIL

D18421: [autotests] Stabilize testWindowmanagement

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R127:e6aa2c847df5: [autotests] Stabilize testWindowmanagement (authored by zzag). REPOSITORY R127 KWayland CHANGES

D18421: [autotests] Stabilize testWindowmanagement

zzag added a comment. If there are no objections, I'm going to land this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18421 To: zzag, #kwin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18628: [server] Generate correct touch ids

zzag added a comment. I don't own any device with touchscreen. Could someone please test this patch? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18628 To: zzag, #kwin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18628: [server] Generate correct touch ids

zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY testWaylandSeat fails because the seat interface generates incorrect id for the second touch.

D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

zzag added a comment. In D18545#402636 , @ngraham wrote: > It there indeed a bug in the KWin effect somewhere? I don't think so. Both the blur and the background contrast effect operate on regions. Rounded corners are approximated by a

D18582: Add explicit SurfaceInterface::commited signal

zzag accepted this revision. zzag added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > surface_interface.h:347 > + * @since 5.54 > + */ > +void committed(); **/ REPOSITORY R127 KWayland BRANCH master REVISION DETAIL

D18577: Make XdgTest spec compliant

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D18577 To: davidedmundson, #kwin, zzag Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18577: Make XdgTest spec compliant

zzag added inline comments. INLINE COMMENTS > xdgtest.cpp:124 > Q_ASSERT(m_xdgShellSurface); > -connect(m_xdgShellSurface, ::sizeChanged, this, > ::render); > -render(); > +connect(m_xdgShellSurface, ::configureRequested, > this, [this](const

D18521: [server] Send initial org_kde_plasma_virtual_desktop_management.rows

This revision was automatically updated to reflect the committed changes. Closed by commit R127:87d9d440919f: [server] Send initial org_kde_plasma_virtual_desktop_management.rows (authored by zzag). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D18521: [server] Send initial org_kde_plasma_virtual_desktop_management.rows

zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REPOSITORY R127 KWayland BRANCH send-initla-row-event REVISION DETAIL https://phabricator.kde.org/D18521

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

zzag added a comment. In D18167#398076 , @graesslin wrote: > The human error exists as long as clang-tidy is not used. What I fear is that someone does a hand porting - we have seen several attempts to do that in KWin from various developers.

D18440: [client] Wrap wl_shell_surface_set_{class,title}

This revision was automatically updated to reflect the committed changes. Closed by commit R127:0a2c807ad21e: [client] Wrap wl_shell_surface_set_{class,title} (authored by zzag). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18440?vs=50030=50045 REVISION

D18440: [client] Wrap wl_shell_surface_set_{class,title}

zzag added a comment. In D18440#397756 , @davidedmundson wrote: > ShellSurface is super-duper deprecated. I wouldn't invest too much time on it. Yes, I know. I just need set_class in some KWin's tests. :-) REPOSITORY R127 KWayland

D18440: [client] Wrap wl_shell_surface_set_{class,title}

zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY We have to wrap these two requests just for convenience. REPOSITORY R127 KWayland BRANCH

D17691: Add rows info to the plasma virtual desktop protocol

zzag added inline comments. INLINE COMMENTS > plasmavirtualdesktop_interface.cpp:94 > > const quint32 PlasmaVirtualDesktopManagementInterface::Private::s_version = > 1; > This one should be bumped as well. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D17691

D18421: [autotests] Stabilize testWindowmanagement

zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY In rare cases testWindowmanagement fails because the initial iconChanged signal gets emitted

D18365: Add flag to keep a window on top.

zzag added a comment. Looks good to me. (please remove period from the title) REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18365 To: davidedmundson, #kwin Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D17691: Add rows info to the plasma virtual desktop protocol

zzag added a comment. David's comment is still not done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D17691 To: mart, #plasma, #kwin Cc: zzag, davidedmundson, hein, kde-frameworks-devel, michaelh, ngraham, bruns

D17122: Add option to use wl_display_add_socket_auto

zzag added inline comments. INLINE COMMENTS > display.cpp:86-87 > QString socketName = QStringLiteral("wayland-0"); > -bool running = false; > +bool running = false, > + automaticSocketNaming = false; > QList outputs; Style:

D18248: Guard resource deletion in OuptutConfiguration::sendApplied

zzag accepted this revision. zzag added a comment. This revision is now accepted and ready to land. OK, makes sense. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D18248 To: davidedmundson, #kwin, zzag Cc: zzag, kde-frameworks-devel, michaelh,

D18248: Guard resource deletion in OuptutConfiguration::sendApplied

zzag added a comment. If I understand it correctly, KWin tries to notify whether the changes have been applied successfully after the interface was unbound, but before OutputConfigurationInterface object is deleted, is it correct? (sorry if that's a stupid question) REPOSITORY R127

D17691: Add rows info to the plasma virtual desktop protocol

zzag added inline comments. INLINE COMMENTS > plasmavirtualdesktop_interface.h:55 > + * Sets how many rows the virtual desktops should be laid into > + * @since 5.53 > + */ Wrong version. > davidedmundson wrote in plasmavirtualdesktop_interface.h:51 > Is this even implemented?? I

D17691: Add rows info to the plasma virtual desktop protocol

zzag added inline comments. INLINE COMMENTS > mart wrote in test_plasma_virtual_desktop.cpp:280 > why? we want to compare the number of rows, no? What if rowsChanged is never emitted? In KWin, we usually do QVERIFY(spy.wait()); REPOSITORY R127 KWayland REVISION DETAIL

D17691: Add rows info to the plasma virtual desktop protocol

zzag added inline comments. INLINE COMMENTS > test_plasma_virtual_desktop.cpp:280 > +m_plasmaVirtualDesktopManagementInterface->setRows(3); > +rowsChangedSpy.wait(); > +QCOMPARE(m_plasmaVirtualDesktopManagement->rows(), 3); QVERIFY > plasmavirtualdesktop.h:168 > > +void

D18114: FakeInput: add support for pointer move with absolute coordinates

zzag accepted this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin, zzag Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

zzag accepted this revision. zzag added inline comments. INLINE COMMENTS > fakeinput.cpp:106 > +Q_ASSERT(d->manager.isValid()); > +if (wl_proxy_get_version(d->manager) < > ORG_KDE_KWIN_FAKE_INPUT_POINTER_MOTION_ABSOLUTE_SINCE_VERSION) > +return; Use curly braces even when the

D18114: FakeInput: add support for pointer move with absolute coordinates

zzag requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin, zzag Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

zzag added inline comments. INLINE COMMENTS > fake-input.xml:86 > > + > + since="3" REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin, zzag Cc: graesslin, zzag, kde-frameworks-devel, michaelh,

D18114: FakeInput: add support for pointer move with absolute coordinates

zzag accepted this revision. zzag added a comment. Please wait for @davidedmundson and @graesslin. :-) REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin, zzag Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham,

D18114: FakeInput: add support for pointer move with absolute coordinates

zzag added inline comments. INLINE COMMENTS > fakeinput_interface.cpp:164 > + > + > void FakeInputInterface::Private::axisCallback(wl_client *client, > wl_resource *resource, uint32_t axis, wl_fixed_t value) Please delete one extra empty line. REPOSITORY R127 KWayland REVISION DETAIL

D18114: FakeInput: add support for pointer move with absolute coordinates

zzag added a comment. maxVersion in src/client/registry.cpp should be updated as well. INLINE COMMENTS > fakeinput.h:138 > + * Request an absolute pointer motion to @p pos position. > + **/ > +void requestPointerMoveAbsolute(const QPointF ); Missing `@since`. >

D18114: FakeInput: add support for pointer move with absolute coordinates

zzag added inline comments. INLINE COMMENTS > fakeinput.h:139 > + **/ > +void requestPointerMoveAbsolute(const QSizeF ); > /** Wouldn't QPointF be a better choice? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson Cc:

D18114: FakeInput: add support for pointer move with absolute coordinates

zzag added inline comments. INLINE COMMENTS > fake-input.xml:19 >]]> > > Version of the interface has to be bumped. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson Cc: zzag, kde-frameworks-devel, michaelh, ngraham,

D17755: Add clarifying about using both KDE's ServerDecoation and XdgDecoration

zzag added a comment. Also, there's a typo: ServerDecoation. :-) REPOSITORY R127 KWayland BRANCH xdg_deco REVISION DETAIL https://phabricator.kde.org/D17755 To: davidedmundson, #kwin, zzag Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17755: Add clarifying about using both KDE's ServerDecoation and XdgDecoration

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH xdg_deco REVISION DETAIL https://phabricator.kde.org/D17755 To: davidedmundson, #kwin, zzag Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17558: Fix XDGForeign Client header installs

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D17558 To: davidedmundson, zzag Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17498: Xdg Decoration Support

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D17498 To: davidedmundson, #kwin, zzag Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D17498: Xdg Decoration Support

zzag added inline comments. INLINE COMMENTS > test_xdg_decoration.cpp:104 > +QSignalSpy compositorSpy(m_registry, ::compositorAnnounced); > +QSignalSpy v6xdgShellSpy(m_registry, > ::xdgShellUnstableV6Announced); > +QSignalSpy xdgShellSpy(m_registry, ::xdgShellStableAnnounced); Do

D17052: Simplify reference counting of FrameData

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D17052 To: apol, #plasma, #frameworks, zzag Cc: mart, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D17052: Simplify reference counting of FrameData

zzag added a comment. In gneral, +1 for shared pointers. INLINE COMMENTS > framesvg.cpp:375 > //#define DEBUG_FRAMESVG_CACHE > FrameSvgPrivate::~FrameSvgPrivate() > +{} = default; > framesvg.cpp:569 > > -QRect FrameSvgPrivate::contentGeometry(FrameData* frame, const QSize& size) >

D17052: Simplify reference counting of FrameData

zzag added a comment. > as it can change sometimes and crash the system. Could you please provide example when it can crash? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D17052 To: apol, #plasma, #frameworks Cc: zzag, kde-frameworks-devel,

D16701: Correct version of newly added PlasmaVirtualDesktop interface

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D16701 To: davidedmundson, #kwin, zzag Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16708: [server] Text input content hint and purpose per protocol version

zzag accepted this revision. zzag added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > romangg wrote in textinput_interface.cpp:67 > wlPurpose is also an abbreviation. ;) > > And in the header file it is named `purpose`. Makes more sense to me to have > the

D16708: [server] Text input content hint and purpose per protocol version

zzag added inline comments. INLINE COMMENTS > textinput_interface.cpp:67 > +const auto hints = p->convertContentHints(hint); > +const auto purp = p->convertContentPurpose(purpose); > +if (hints != p->contentHints || purp != p->contentPurpose) { purpose_? or just keep previous name

D16676: [server] Put text-input (de-)activate, en-/disable callbacks in child classes

zzag accepted this revision. REPOSITORY R127 KWayland BRANCH textInputActivateEnable REVISION DETAIL https://phabricator.kde.org/D16676 To: romangg, #kwin, #frameworks, davidedmundson, zzag Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16676: [server] Put text-input (de-)activate, en-/disable callbacks in child classes

zzag added inline comments. INLINE COMMENTS > textinput_interface_v0.cpp:92 > emit q_func()->enabledChanged(); > -emit q_func()->requestActivate(seat, surface); > } This seems to be different. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D16676 To:

D16675: [server] Put set surrounding text callback with uint in v0 class

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH textInputSurroundingTextCallback REVISION DETAIL https://phabricator.kde.org/D16675 To: romangg, #kwin, #frameworks, zzag Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16675: [server] Put set surrounding text callback with uint in v0 class

zzag added a comment. In D16675#354181 , @romangg wrote: > Could the renaming be problematic in regards to binary compatibility? All are private interfaces though. I don't think so. Otherwise PIMPL is pointless. REPOSITORY R127

D16701: Correct version of newly added PlasmaVirtualDesktop interface

zzag added inline comments. INLINE COMMENTS > registry.h:180 > ServerSideDecorationPalette, ///Refers to > org_kde_kwin_server_decoration_palette_manager @since 5.42 > -RemoteAccessManager, ///< Refers to > org_kde_kwin_remote_access_manager interface, @since 5.45 >

D16318: [xdgshell] Add positioner constraint adjustment flag operators

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D16318 To: davidedmundson, #kwin, zzag Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16294: [test/xdgtest] Create/destroy popup on click

zzag added inline comments. INLINE COMMENTS > xdgtest.cpp:202 > QImage image(buffer->address(), size.width(), size.height(), > QImage::Format_ARGB32_Premultiplied); > -image.fill(QColor(255, 0, 0, 255)); > +image.fill(QColor(0, 0, 255, 255)); > Also, you could use Qt::blue. :-)

D16294: [test/xdgtest] Create/destroy popup on click

zzag accepted this revision. zzag added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > xdgtest.cpp:172 > +positioner.setGravity(Qt::BottomEdge); > +positioner.setConstraints(XdgPositioner::Constraint::FlipX | > XdgPositioner::Constraint::FlipX); > +

D15910: Implement wl_surface::damage_buffer

zzag added inline comments. INLINE COMMENTS > surface.cpp:244 > +{ > +for (const QRect : region.rects()) { > +damageBuffer(r); `for (const QRect : region) {` rects() is obsolete. http://doc.qt.io/qt-5/qregion-obsolete.html#rects REPOSITORY R127 KWayland REVISION DETAIL

D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX

This revision was automatically updated to reflect the committed changes. Closed by commit R278:9658d727bdae: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX (authored by zzag). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

zzag added a comment. > QRectF(QPoint(0, 0), size()).contains(position) Shouldn't it be QRect instead? (again) If it should be QRectF indeed, could someone please explain why? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7038 To: romangg, #frameworks,

D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX

zzag added a comment. Ping. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D15353 To: zzag, #kwin Cc: romangg, aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX

zzag added a comment. Ping. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D15353 To: zzag, #kwin Cc: romangg, aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX

zzag added a comment. In D15353#329431 , @romangg wrote: > Whoops, yea. My fault. I think it's fine to replace the name, since Qt/GTK use the correct one and normally apps use these libs instead of setting such properties directly. Can

D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX

zzag added a comment. In D15353#329424 , @romangg wrote: > ... to KWindowSystem as well? Isn't it KWindowSystem repo? (maybe, I don't understand your question) REPOSITORY R278 KWindowSystem REVISION DETAIL

D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX

zzag added a comment. Ping. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D15353 To: zzag, #kwin Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX

zzag added a comment. Ping. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D15353 To: zzag, #kwin Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

zzag added inline comments. INLINE COMMENTS > davidedmundson wrote in surface_interface.cpp:819 > position is a float So, it would be fine to return `true` in the following case: QRectF(QPoint(0, 0), QSize(10, 10)).contains(QPointF(10, 10)); ? REPOSITORY R127 KWayland REVISION DETAIL

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

zzag added inline comments. INLINE COMMENTS > surface_interface.cpp:819 > + > +return !size.isEmpty() && QRectF(QPoint(0, 0), size).contains(position); > +} Shouldn't it be QRect instead? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7038 To: romangg,

D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX

zzag added a comment. In D15353#322991 , @aacid wrote: > I'm not a KWindowSystem developer so take this with a grain of salt, but maybe it makes sense to still support the old name in case someone is really using it and add the new one as a

D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX

zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY The EWMH spec doesn't have the _NET_WM_WINDOW_TYPE_COMBOBOX atom. Instead, it has

D15330: [autotests] Compare booleans to booleans

This revision was automatically updated to reflect the committed changes. Closed by commit R127:3c128a612c1f: [autotests] Compare booleans to booleans (authored by zzag). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15330?vs=41149=41152 REVISION DETAIL

D15330: [autotests] Compare booleans to booleans

zzag created this revision. zzag added reviewers: KWin, romangg. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY Compiler errors: 17:06:23

D14946: [DialogShadows] Use 0 offset for disabled borders on Wayland

This revision was automatically updated to reflect the committed changes. Closed by commit R242:8497832a8bf0: [DialogShadows] Use 0 offset for disabled borders on Wayland (authored by zzag). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D14946: [DialogShadows] Use 0 offset for disabled borders on Wayland

zzag added a comment. I suppose it has to go in 5.51 (tagging will be tomorrow). REPOSITORY R242 Plasma Framework (Library) BRANCH wayland-shadows REVISION DETAIL https://phabricator.kde.org/D14946 To: zzag, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14946: [DialogShadows] Use 0 offset for disabled borders on Wayland

zzag added a comment. This change depends on D14783 . I also think that we don't need to attach empty tiles on X11. But it works, the Sliding Popups effect was fixed... So, maybe, that's fine. REPOSITORY R242 Plasma Framework (Library) BRANCH

D14946: [DialogShadows] Use 0 offset for disabled borders on Wayland

zzag updated this revision to Diff 40150. zzag added a comment. "QMarginsF margins = QMarginsF();" => "QMarginsF margins;" REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14946?vs=40044=40150 BRANCH wayland-shadows REVISION DETAIL

D14946: [DialogShadows] Use 0 offset for disabled borders on Wayland

zzag created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY On Wayland, DialogShadows doesn't attach empty tiles for disabled borders. Yet, it sets offset of 1 for them. This results

D14520: Open `skipPager` functionality

zzag added a comment. Please checkout .arclint from master (git checkout master -- .arclint). INLINE COMMENTS > plasmashell_interface.h:192-194 > + > + > + Unrelated change. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D14520 To: sharvey, #plasma_on_wayland,

D14009: [Plasma PluginLoader] Cache plugins during startup

zzag added inline comments. INLINE COMMENTS > pluginloader.cpp:194-196 > +const QString pluginName = name.section(QLatin1Char('/'), -1); > > +QVector plugins; Nitpick: IMHO, it would be better to move these two down (right before `if (useRuntimeCache) {`). So, cache invalidation and

D13496: FrameSvg: Update mask frame if image path has been changed

This revision was automatically updated to reflect the committed changes. Closed by commit R242:0c8dd9dc2b54: FrameSvg: Update mask frame if image path has been changed (authored by zzag). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D13384: FrameSvg: Do not wreck shared mask frames

This revision was automatically updated to reflect the committed changes. Closed by commit R242:412a517576d5: FrameSvg: Do not wreck shared mask frames (authored by zzag). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13384?vs=36056=36758

D13402: FrameSvg: Simplify updateSizes

This revision was automatically updated to reflect the committed changes. Closed by commit R242:acdaefa221cc: FrameSvg: Simplify updateSizes (authored by zzag). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13402?vs=35748=36757 REVISION

D13402: FrameSvg: Simplify updateSizes

zzag added a comment. Ping. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13402 To: zzag, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13496: FrameSvg: Update mask frame if image path has been changed

zzag added a comment. Ping. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13496 To: zzag, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13384: FrameSvg: Do not wreck shared mask frames

zzag added a comment. Ping. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13384 To: zzag, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13601: OutputManagement fractional scaling

zzag added inline comments. INLINE COMMENTS > outputdevice.cpp:413 > > + > bool OutputDevice::isValid() const Extra new line. > outputconfiguration_interface.cpp:73 > +static void scaleFCallback(wl_client *client, wl_resource *resource, > + wl_resource *

D13384: FrameSvg: Do not wreck shared mask frames

zzag added a comment. Ping. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13384 To: zzag, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13402: FrameSvg: Simplify updateSizes

zzag added a comment. Ping. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13402 To: zzag, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13496: FrameSvg: Update mask frame if image path has been changed

zzag added a comment. Ping. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13496 To: zzag, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13601: OutputManagement fractional scaling

zzag added inline comments. INLINE COMMENTS > outputconfiguration_interface.cpp:194 > +Q_UNUSED(client); > +qreal scale = wl_fixed_to_double(scale_fixed); > + Nitpick: can be const. :-) REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13601 To:

D13500: Honor BUILD_TESTING

This revision was automatically updated to reflect the committed changes. Closed by commit R127:2d06b24a86f2: Honor BUILD_TESTING (authored by zzag). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13500?vs=36068=36307 REVISION DETAIL

D13500: Honor BUILD_TESTING

zzag added a comment. Ping. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13500 To: zzag, #kwin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13510: Add XDG WM Base support to our XDGShell API

zzag added inline comments. INLINE COMMENTS > xdgshell_stable.cpp:305 > +Q_UNUSED(surface) > +auto s = reinterpret_cast(data); > +s->q->configureRequested(s->pendingSize, s->pendingState, serial); Did you forget to change it to static_cast? Or there is a reason why it's still

D13402: FrameSvg: Simplify updateSizes

zzag added a comment. Ping. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13402 To: zzag, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13384: FrameSvg: Do not wreck shared mask frames

zzag added a comment. Ping? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13384 To: zzag, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13502: Fix compiler warning about hidden virtual overloads

zzag accepted this revision. zzag added a comment. This revision is now accepted and ready to land. In D13502#277837 , @davidedmundson wrote: > ... > But if this is accepted as a good solution for the problem, ... Well, yeah, that's

D13502: Fix compiler warning about hidden virtual overloads

zzag added a comment. In D13502#277828 , @davidedmundson wrote: > I meant the class I changed no longer had warnings. Oh, I thought you were talking about all -Woverloaded-virtual warnings. I think it would be better to fix those

D13502: Fix compiler warning about hidden virtual overloads

zzag added a comment. > Compiles with no warnings \o/ Nope. In file included from /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_v6.cpp:20: /home/vlad/KDE/src/frameworks/kwayland/src/client/xdgshell_p.h:49:13: warning: ‘virtual

D13510: Add XDG WM Base support to our XDGShell API

zzag added inline comments. INLINE COMMENTS > zzag wrote in xdgshell_stable.cpp:525 > Shouldn't it be also static? Ignore it. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13510 To: davidedmundson, #kwin Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D13510: Add XDG WM Base support to our XDGShell API

zzag added inline comments. INLINE COMMENTS > test_xdg_shell.cpp:120 > +break; > +} > Missing `default`. Is it okay if version is unknown? > xdgshell_stable.cpp:28 > + > +#include > + Seems like QDebug is not used here. > xdgshell_stable.cpp:307 > +Q_UNUSED(surface) > +

D13501: Fix 'unused parameter' warnings

This revision was automatically updated to reflect the committed changes. Closed by commit R127:1028770d48e5: Fix unused parameter warnings (authored by zzag). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13501?vs=36069=36075 REVISION DETAIL

D13501: Fix 'unused parameter' warnings

zzag created this revision. zzag added a reviewer: KWin. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY The warnings:

D13500: Honor BUILD_TESTING

zzag created this revision. zzag added a reviewer: KWin. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY Don't build tests if BUILD_TESTING is OFF. TEST PLAN - Passed

D13496: FrameSvg: Update mask frame if image path has been changed

zzag updated this revision to Diff 36057. zzag added a comment. Compare against frame->imagePath. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13496?vs=36053=36057 BRANCH dont-wreck-shared-mask-frames REVISION DETAIL

<    1   2   3   >