D28765: KSettings::Dialog: add support for KPluginInfos without a KService

wbauer added a comment. This caused a crash in openSUSE: https://bugs.kde.org/show_bug.cgi?id=421566 REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D28765 To: dfaure, pino, broulik, mart, davidedmundson, ngraham, svuorela Cc: wbauer, kossebau, svuorela, cblack, kd

D27654: [kio] Fix running konsole on Wayland

This revision was automatically updated to reflect the committed changes. Closed by commit R241:07ab04bfe774: Fix running konsole on Wayland (authored by wbauer). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27654?vs=76387&id=76607 REVISION DETAIL https://pha

D27654: [kio] Fix running konsole on Wayland

wbauer added a comment. In D27654#617946 , @dfaure wrote: > Wait, you're actually passing the icon of the command being executed now (while the old code would end up using the stuff from konsole.desktop I think) AFAICT passing the ic

D27654: [kio] Fix running konsole on Wayland

wbauer updated this revision to Diff 76387. wbauer added a comment. Use `KShell::quoteArg()` in case the icon name contains spaces or other special chars. No idea if that's possible/allowed, but better be safe than sorry I suppose. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://

D27654: [kio] Fix running konsole on Wayland

wbauer edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27654 To: wbauer, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27654: [kio] Fix running konsole on Wayland

wbauer created this revision. wbauer added a reviewer: dfaure. wbauer added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. wbauer requested review of this revision. REVISION SUMMARY %i expands to "--icon someicon", but Qt recognizes this option only on X11/xcb. So kon

D27589: Try to apply the colorscheme of the current theme to QIcons

wbauer added a comment. Confirmed. I tried out the patch now, and that problem is gone. REPOSITORY R242 Plasma Framework (Library) BRANCH qiconcolor (branched from master) REVISION DETAIL https://phabricator.kde.org/D27589 To: davidre, #plasma, cblack Cc: wbauer, cblack, kde-framework

D27589: Try to apply the colorscheme of the current theme to QIcons

wbauer added a comment. Sounds like it would fix https://bugs.kde.org/show_bug.cgi?id=417780 ? REPOSITORY R242 Plasma Framework (Library) BRANCH qiconcolor (branched from master) REVISION DETAIL https://phabricator.kde.org/D27589 To: davidre, #plasma, cblack Cc: wbauer, cblack, kde-fr

D11880: Add firewall-config and firewall-applet icons

wbauer added a comment. In D11880#331450 , @ngraham wrote: > However, there seems to be a problem for the breeze dark versions: > F6283726: Screenshot_20180924_215524.png > > Shouldn't the wall be lig

D27433: Check activeModule before using it

wbauer closed this revision. wbauer added a comment. Committed with https://commits.kde.org/kcmutils/ea7120ed901bf6161bb483ab73211a6491daac8f REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D27433 To: wbauer, #frameworks, davidedmundson, ervin Cc: kde-frameworks-dev

D27433: Check activeModule before using it

wbauer edited the summary of this revision. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D27433 To: wbauer, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26519: Show button respecting what is declared by KCModule

wbauer added inline comments. INLINE COMMENTS > kcmultidialog.cpp:184 > > +auto buttons = activeModule->buttons(); > + `activeModule` can be a nullptr here, as this is outside/after the `if (activeModule)`. This causes the kontact crash. Possible fix: D27433

D27433: Check activeModule before using it

wbauer created this revision. wbauer added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. wbauer requested review of this revision. REVISION SUMMARY `activeModule` can be a nullptr here, as this is outside/after the `if (activeModule

D26519: Show button respecting what is declared by KCModule

wbauer added a comment. This change causes kontact to crash when opening its settings: https://bugs.kde.org/show_bug.cgi?id=417396 REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D26519 To: bport, ervin, meven, crossi, davidedmundson Cc: wbauer, kde-frameworks-deve

D24314: Improve KFloppy icon

wbauer accepted this revision. wbauer added a comment. Thanks! REPOSITORY R266 Breeze Icons BRANCH better-kfloppy-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D24314 To: ngraham, #vdg, ndavis, wbauer Cc: wbauer, ndavis, kde-frameworks-devel, LeGast00n, GB_2,

D22258: Improve plugin caching

wbauer added a comment. In D22258#539682 , @davidedmundson wrote: > I don't know the situation well enough to know whether it's valid that it's invalid or not. Let's follow that up in your bug report. The problem apparently is that the m

D22258: Improve plugin caching

wbauer added inline comments. INLINE COMMENTS > davidedmundson wrote in pluginloader.cpp:860 > Changed. > Though that won't stop the warning from appearing. True. Maybe it would be better to downgrade it to qCDebug()? (until the existing invalid metadata is fixed at least) REPOSITORY R242 Pla

D22258: Improve plugin caching

wbauer added inline comments. INLINE COMMENTS > pluginloader.cpp:860 > +if (!metadata.isValid()) { > +qWarning() << "invalid metadata" << pluginPath; > +return; Shouldn't this use categorized logging as well? It causes *lots* of warnings from plasmash

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

wbauer added a comment. What about the stable 5.16 branch? It has only be committed to master so far AFAICS, so the fix would only end up in Plasma 5.17 which is still 3 months away... REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D22525 To: arrowd, #fr

D21952: [ftp] Fix wrong access time in Ftp::ftpCopyGet()

This revision was automatically updated to reflect the committed changes. Closed by commit R241:f9c2dfb6e8df: [ftp] Fix wrong access time in Ftp::ftpCopyGet() (authored by wbauer). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21952?vs=60195&id=61105 REVISION DE

D21952: [ftp] Fix wrong access time in Ftp::ftpCopyGet()

wbauer added a subscriber: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21952 To: wbauer, #frameworks Cc: dfaure, kde-frameworks-devel, #dolphin, LeGast00n, michaelh, ngraham, bruns

D21955: [copyjob] Only set modification time if the kio-slave provided it

This revision was automatically updated to reflect the committed changes. Closed by commit R241:5e791ef216c2: [copyjob] Only set modification time if the kio-slave provided it (authored by wbauer). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21955?vs=60227&id=6

D21955: [copyjob] Only set modification time if the kio-slave provided it

wbauer updated this revision to Diff 60227. wbauer edited the summary of this revision. wbauer added a comment. Check already when setting info.mtime in CopyJobPrivate::addCopyInfoFromUDSEntry(). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21955?vs=60202&id

D21955: [copyjob] Only set modification time if the kio-slave provided it

wbauer marked an inline comment as done. wbauer added inline comments. INLINE COMMENTS > wbauer wrote in copyjob.cpp:1709 > I don't think mtime would be null or invalid in this case, but I'll check. Nope. I added this debug line: qDebug() << "mtime=" << (*it).mtime << "null:" << (*it).mtime.i

D21955: [copyjob] Only set modification time if the kio-slave provided it

wbauer added inline comments. INLINE COMMENTS > dfaure wrote in copyjob.cpp:1709 > Wouldn't mtime.isNull() or mtime.isValid() be simpler? I don't think mtime would be null or invalid in this case, but I'll check. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21955 To: w

D21955: [copyjob] Only set modification time if the kio-slave provided it

wbauer edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21955 To: wbauer, #frameworks Cc: kde-frameworks-devel, #dolphin, LeGast00n, michaelh, ngraham, bruns

D21955: [copyjob] Only set modification time if the kio-slave provided it

wbauer edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21955 To: wbauer, #frameworks Cc: kde-frameworks-devel, #dolphin, LeGast00n, michaelh, ngraham, bruns

D21955: [copyjob] Only set modification time if the kio-slave provided it

wbauer created this revision. wbauer added a reviewer: Frameworks. wbauer added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. wbauer requested review of this revision. REVISION SUMMARY If the slave didn't pass a modification time (e.g. the http slave doesn't), it is se

D21952: [ftp] Fix wrong access time in Ftp::ftpCopyGet()

wbauer created this revision. wbauer added a reviewer: Frameworks. wbauer added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. wbauer requested review of this revision. REVISION SUMMARY `sPartInfo` refers to the .part file which might not exist in the first place, resul

D19581: Fix build with cmake < 3.7

This revision was automatically updated to reflect the committed changes. Closed by commit R216:a08e2ebd589f: Fix build with cmake < 3.7 (authored by wbauer). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19581?vs=53332&id=53336 REVISION DETAIL

D19581: Fix build with cmake < 3.7

wbauer created this revision. wbauer added a project: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. wbauer requested review of this revision. REVISION SUMMARY VERSION_GREATER_EQUAL requires cmake 3.7 or high

D18479: Fix NTFS hidden check for symlinks to NTFS mountpoints

This revision was automatically updated to reflect the committed changes. Closed by commit R241:01a7e0e757d3: Fix NTFS hidden check for symlinks to NTFS mountpoints (authored by wbauer). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18479?vs=50132&id=53061 REVIS

D18479: Fix NTFS hidden check for symlinks to NTFS mountpoints

wbauer added a comment. Ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18479 To: wbauer, #frameworks, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18941: Fix build with cmake 3.5

This revision was automatically updated to reflect the committed changes. Closed by commit R286:1632a6972279: Fix build with cmake 3.5 (authored by wbauer). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18941?vs=51466&id=51475 REVISION DETAIL https:/

D18941: Fix build with cmake 3.5

wbauer edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18941 To: wbauer Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18941: Fix build with cmake 3.5

wbauer edited the test plan for this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18941 To: wbauer Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18941: Fix build with cmake 3.5

wbauer created this revision. wbauer added a project: Frameworks. Herald added subscribers: Baloo, kde-frameworks-devel. Herald added a project: Baloo. wbauer requested review of this revision. REVISION SUMMARY VERSION_GREATER_EQUAL requires cmake 3.7 or higher. So use NOT VERSION_LESS instead

D18479: Fix NTFS hidden check for symlinks to NTFS mountpoints

wbauer added a comment. In D18479#398655 , @wbauer wrote: > The existing check did work fine for me back in D13782 also for symlinks for some reason. > Maybe this broke because of some change in the kernel

D18479: Fix NTFS hidden check for symlinks to NTFS mountpoints

wbauer added a comment. The existing check did work fine for me back in D13782 also for symlinks for some reason. Maybe this broke because of some change in the kernel or glibc? :-/ REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18

D18479: Fix NTFS hidden check for symlinks to NTFS mountpoints

wbauer created this revision. wbauer added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. wbauer requested review of this revision. REVISION SUMMARY A symlink to the mountpoint of an NTFS partition can have the type DT_LNK. So exten

D17529: [proxysetting] Fix build with NM 1.4

This revision was automatically updated to reflect the committed changes. Closed by commit R282:88f3093c5237: [proxysetting] Fix build with NM 1.4 (authored by wbauer). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17529?vs=47446&id=47454 REVISION D

D17529: [proxysetting] Fix build with NM 1.4

wbauer edited the summary of this revision. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D17529 To: wbauer, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17529: [proxysetting] Fix build with NM 1.4

wbauer requested review of this revision. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D17529 To: wbauer, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17529: [proxysetting] Fix build with NM 1.4

wbauer updated this revision to Diff 47446. wbauer edited the summary of this revision. wbauer added a comment. Don't define the enum, rather use the numbers directly REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17529?vs=47426&id=47446 REVISION

D17529: [proxysetting] Fix build with NM 1.4

wbauer added a comment. In D17529#375909 , @jgrulich wrote: > So maybe go with the easiest approach and just instead of defines use 0 and 1? Fine with me. Should I make that conditional depending on the NM version maybe, or just unc

D17529: [proxysetting] Fix build with NM 1.4

wbauer added a comment. Hm, maybe I should add `extern "C"` though? This is inside `G_BEGIN_DECLS`/`G_END_DECLS` in nm-setting-proxy.h, which are defined as `extern "C" {` and `}` (according to the docs). REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D175

D17529: [proxysetting] Fix build with NM 1.4

wbauer added a comment. In D17529#375882 , @wbauer wrote: > I don't think that really is a problem here though, as it is defined in libnm/nm-setting-proxy.h (in NM 1.6+) which is included by this file (via NetworkManager.h that's included by set

D17529: [proxysetting] Fix build with NM 1.4

wbauer added a comment. In D17529#375867 , @jgrulich wrote: > I think the easiest solution here is just to set 0 and 1 to the enum values, instead of NM defines. Sure, that would work as well. But IMHO the version check would make it

D17529: [proxysetting] Fix build with NM 1.4

wbauer added a reviewer: jgrulich. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D17529 To: wbauer, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17529: [proxysetting] Fix build with NM 1.4

wbauer created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. wbauer requested review of this revision. REVISION SUMMARY The `NMSettingProxyMethod` enum only exists since NetworkManager 1.6. So define it appropriately when building with a lo

RE: Increasing KF5 cmake requirement to 3.6?

> -Original Message- > I'm going to suggest it to increase it to 3.6, it would still most probably be a lie > since i don't think any of use uses such an old (2 years version) either We currently do still build the latest KDE Frameworks, Plasma, and Applications on/for openSUSE Leap 42.3 (

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

wbauer added a comment. In D16692#355070 , @ngraham wrote: > The point is, there is no reason to reference distos (which are downstream from us) when we fix issues here. It does not matter that many or even most reports came from Neon. All rolli

D15096: [PreviewJob] Send enabled thumbnail plugins to the thumbnail slave

wbauer added inline comments. INLINE COMMENTS > previewjob.cpp:641 > job->addMetaData(QStringLiteral("plugin"), > currentItem.plugin->library()); > +//job->addMetaData(QStringLiteral("enabledPlugins"), > enabledPlugins.join(QLatin1Char(','))); > if (sequenceIndex) { That line is

D13782: Ignore NTFS hidden flag for root volume

wbauer added inline comments. INLINE COMMENTS > file_unix.cpp:567 > +if (ep->d_type == DT_DIR || ep->d_type == DT_UNKNOWN) { > +const QString fullFilePath = > QDir::cleanPath(QDir().absoluteFilePath(filename)); > +auto mountPoin

D13808: Fix KMainWindow saving incorrect widget settings

wbauer added a comment. In D13808#299791 , @ngraham wrote: > In the Bugzilla ticket, it was mentioned that KMail (and only KMail) still suffers from the issue even with this patch, so it might be a KMail-specific issue. For reference: h

D13782: RFC: Ignore NTFS hidden flag for root volume

wbauer added a comment. In D13782#297639 , @wbauer wrote: > Using QDir::canonicalPath() (instead of QDir::cleanPath() ) would fix all 3 cases: > > const QString fullFilePath = QDir(path + QLatin1Char('/') + filename).canonicalPath(); >

D13782: RFC: Ignore NTFS hidden flag for root volume

wbauer added a comment. In D13782#297547 , @wbauer wrote: > With additional debug output I do see the '.' entry in the root dir still marked as hidden (as mentioned in the test plan), and also the '..' entry in (first-level) subdirs is hidden.

D13782: RFC: Ignore NTFS hidden flag for root volume

wbauer added a subscriber: ngraham. wbauer added a comment. In D13782#296381 , @ngraham wrote: > @wbauer, does this work for you now? Yes, it does work as expected now here in all cases I tested, and I didn't notice problems. With ad

D13782: RFC: Ignore NTFS hidden flag for root volume

wbauer added inline comments. INLINE COMMENTS > file_unix.cpp:566 > +// Bug 392913: NTFS root volume is always "hidden", > ignore this > +if (ep->d_type == DT_DIR) { > +const QString fullFilePath = path + QLatin1Char('/') > + filen

D13782: RFC: Ignore NTFS hidden flag for root volume

wbauer added a comment. In D13782#287336 , @wbauer wrote: > I tried the patch and it doesn't make a difference here, the mountpoint of my NTFS partition is still hidden. > (it's on an internal drive and mounted to /windows/C via fstab in case

D13782: RFC: Ignore NTFS hidden flag for root volume

wbauer added a comment. I tried the patch and it doesn't make a difference here, the mountpoint of my NTFS partition is still hidden. (it's on an internal drive and mounted to /windows/C via fstab in case it matters) Additional debug output showed that ep->d_type is not DT_DIR but 0 (w

D13808: Fix KMainWindow saving incorrect widget settings

wbauer added a comment. In D13808#286965 , @maxrd2 wrote: > Relative Qt Bug is here: https://bugreports.qt.io/browse/QTBUG-69277 > Seems it's not their bug. Hm. Interestingly, Qt Creator has similar problems with Qt 5.11.1 that are al

D13808: Fix KMainWindow saving incorrect widget settings

wbauer added a comment. I just like to note that VirtualBox has the same problem with Qt 5.11.1, that the toolbar and the status bar disappear on next start if you close the window: http://bugzilla.opensuse.org/show_bug.cgi?id=1099589 So it does not only affect applications using KMainWind

D9675: Don't show context menu menu if right-clicking outside

wbauer added a comment. In D9675#207283 , @wbauer wrote: > I suppose that would fix https://bugs.kde.org/show_bug.cgi?id=373653 ? Just tried it myself, and it does fix it. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kd

D9675: Don't show context menu menu if right-clicking outside

wbauer added a comment. I suppose that would fix https://bugs.kde.org/show_bug.cgi?id=373653 ? REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D9675 To: broulik, #frameworks Cc: wbauer, michaelh

D10495: Workaround to restore KF5 programs from system tray

wbauer added a subscriber: KWin. wbauer added a comment. Indeed. One thing that started this is https://bugs.kde.org/show_bug.cgi?id=389663 I do think this should be fixed on the lower level if possible. Adding KWin as subscriber as well to hopefully get most people that have more

D9793: Fall back to language name for translations lookup if locale name fails

This revision was automatically updated to reflect the committed changes. Closed by commit R240:78443e0f0373: Fall back to language name for translations lookup if locale name fails (authored by wbauer). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D9793: Fall back to language name for translations lookup if locale name fails

wbauer updated this revision to Diff 25536. wbauer edited the summary of this revision. wbauer edited the test plan for this revision. wbauer added a comment. Leave bcp47Name() in for compatibility, add const. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricat

D9793: Fall back to language name for translations lookup if locale name fails

wbauer marked an inline comment as done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D9793 To: wbauer, #frameworks Cc: aacid, safaalfulaij, #build_system

D9793: Fall back to language name for translations lookup if locale name fails

wbauer added a comment. In https://phabricator.kde.org/D9793#189595, @safaalfulaij wrote: > > Why is this an issue? > > There's no difference really in loading ar/LC_MESSAGES/xxx.qm and LC_MESSAGES/xxx_ar.qm (or something like that), i.e. you would have the same problem if all transla

D9793: Fall back to language name for translations lookup if locale name fails

wbauer added a comment. In https://phabricator.kde.org/D9793#189494, @safaalfulaij wrote: > I went through Qt code, as Qt applications are opened with my language correctly where KF ones (those with QM) don't. I tested with your ar_BH locale meanwhile, and it is fixed too, i.e. L

Re: Problem in loading QM translations with LANGUAGE="" envar

Am Wed, 10 Jan 2018 20:09:35 +0100, Albert Astals Cid schrieb: > Why not use ar_BH as LANGUAGE? That probably won't help, see my previous reply here (that got delayed by moderation for some reason even though I am subscribed, so you may not have read it yet), or https://phabricator.kde.org/D9

Re: Problem in loading QM translations with LANGUAGE="" envar

Hi, I noticed a similar problem here. My LANG is set to "de_AT.UTF-8", and if LANGUAGE is not set, parts of KDE applications are untranslated (i.e. those frameworks translations that come from .qm files are missing). Sure, setting LANGUAGE to "de" will fix that, but it's not necessarily set on

D9793: Fall back to language name for translations lookup if locale name fails

wbauer added a comment. I don't think bcp47Name makes any sense here. According to the Qt documentation, this "Returns the dash-separated language, script and country (and possibly other BCP47 fields) of this locale as a string" (and "Unlike the uiLanguages() the returned value of the bcp47

D9793: Fall back to language name for translations lookup if locale name fails

wbauer created this revision. wbauer added a reviewer: Frameworks. wbauer added a project: Frameworks. Restricted Application added a project: Build System. Restricted Application added a subscriber: Build System. wbauer requested review of this revision. REVISION SUMMARY For locales like de_AT,

D8545: kio: fix handling of KCookieAdvice::AcceptForSession

wbauer added a comment. Has this been forgotten? It should be committed by somebody, I think... FYI, we do have this patch in openSUSE for a while. https://bugzilla.opensuse.org/show_bug.cgi?id=1049975 Also there is: https://bugs.kde.org/show_bug.cgi?id=374931 REVISION DETAIL

D7487: Make KCMultiDialog scrollable

wbauer added a comment. The referenced bug number seems to be wrong. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D7487 To: valeriymalov, #frameworks Cc: wbauer, broulik

D7341: [KDesktopPropsPlugin] Create destination directory if it doesn't exist

wbauer closed this revision. wbauer added a comment. Committed with https://phabricator.kde.org/R241:a0fc624d50bbd7942834913ece52d26849ba7243 (forgot to mention this review in the commit message, sorry) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7341 To: wbaue

D7341: [KDesktopPropsPlugin] Create destination directory if it doesn't exist

wbauer added a commit: R241:a0fc624d50bb: [KDesktopPropsPlugin] Create destination directory if it doesn't exist. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7341 To: wbauer, dfaure Cc: #frameworks

D7341: [KDesktopPropsPlugin] Create destination directory if it doesn't exist

wbauer created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY If the directory doesn't exist, applying the changes will fail with "Could not save properties. You do not have sufficient access to write to

D6701: Make ECMPoQmToolsTestactually fail if a translation is wrong

wbauer added a comment. In https://phabricator.kde.org/D6701#130417, @apol wrote: > Maybe a next iteration after merging this moving the function out of the `if` would be useful. Probably a good idea, yes. I'll have a look at it in the next days... REPOSITORY R240 Extra CMake

D6701: Make ECMPoQmToolsTestactually fail if a translation is wrong

This revision was automatically updated to reflect the committed changes. Closed by commit R240:899519f0be03: Make ECMPoQmToolsTest actually fail if a translation is wrong (authored by wbauer). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6701?vs

D6701: Make ECMPoQmToolsTestactually fail if a translation is wrong

wbauer added inline comments. INLINE COMMENTS > apol wrote in check.cmake.in:79 > It should also change the other `set(fail)` calls. > > Or am I missing something? The other `set(fail)` calls *are* at the top-level and not inside a function. So, no, it doesn't make sense there. The function on

D6701: Make ECMPoQmToolsTestactually fail if a translation is wrong

wbauer updated this revision to Diff 16705. wbauer added a comment. New diff with full context. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6701?vs=16701&id=16705 REVISION DETAIL https://phabricator.kde.org/D6701 AFFECTED FILES tests/EC

D6701: Make ECMPoQmToolsTestactually fail if a translation is wrong

wbauer added a comment. From the cmake documentation: > set( ... [PARENT_SCOPE]) > > Set the given in the current function or directory scope. > > If the ``PARENT_SCOPE`` option is given the variable will be set in > the scope above the current scope. Each new directory

D6701: Make ECMPoQmToolsTestactually fail if a translation is wrong

wbauer created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY Currently the test still passes even if one of the check_translations() calls fail. The reason is that check_tran

D6606: Support SVG too

This revision was automatically updated to reflect the committed changes. Closed by commit R313:ed5c039f2d19: Support SVG too (authored by wbauer). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6606?vs=16448&id=16505#toc REPOSITORY R313 KHtml CHANGES SINCE LAST UPDATE https://phabri

D6606: Support SVG too

wbauer edited the summary of this revision. REPOSITORY R313 KHtml REVISION DETAIL https://phabricator.kde.org/D6606 To: wbauer, dfaure Cc: #frameworks

D6606: Support SVG too

wbauer added a comment. Here are the promised pictures: before: F3808082: before.png after: F3808084: after.png I'd like to backport this to KDE4 too REPOSITORY R313 KHtml REVISION DETAIL htt

D6606: Support SVG too

wbauer created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Konqueror's about page doesn't show icons if the breeze icon theme is used. The reason is that khtml doesn't support it. This patch is

D5502: Fix relativePath calculation in KDesktopFile::locateLocal()

This revision was automatically updated to reflect the committed changes. Closed by commit R237:3ad00c4e56eb: Fix relativePath calculation in KDesktopFile::locateLocal() (authored by wbauer). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5502?vs=13778&id=1379

D5502: Fix relativePath calculation in KDesktopFile::locateLocal()

wbauer updated this revision to Diff 13778. wbauer added a comment. added more test cases as suggested REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5502?vs=13693&id=13778 REVISION DETAIL https://phabricator.kde.org/D5502 AFFECTED FILES autotests/kde

D5502: Fix relativePath calculation in KDesktopFile::locateLocal()

wbauer updated this revision to Diff 13693. wbauer edited the test plan for this revision. wbauer added a comment. added some tests REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5502?vs=13588&id=13693 REVISION DETAIL https://phabricator.kde.org/D5502 A

D5502: Fix relativePath calculation in KDesktopFile::locateLocal()

wbauer added a comment. In https://phabricator.kde.org/D5502#103316, @mdawson wrote: > Can you please add some unit tests for this, to ensure it doesn't break in the future? I think just three extra tests, one for a desktop file in a config directory, one in a data directory, and one pr

D5502: Fix relativePath calculation in KDesktopFile::locateLocal()

wbauer added a reviewer: Frameworks. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D5502 To: wbauer, #frameworks Cc: #frameworks

D5502: Fix relativePath calculation in KDesktopFile::locateLocal()

wbauer created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The "dir" and "path" variables are obviously swapped here by mistake. This results in the relativePath always being empty, and makes the fun

Re: Review Request 128831: Check whether kwallet is enabled in Wallet::isOpen(name)

marked as submitted. Review request for KDE Frameworks and Valentin Rusu. Changes --- Submitted with commit 48ec969bcf36fde17de027576859c98bae609c73 by Wolfgang Bauer to branch master. Bugs: 358260 https://bugs.kde.org/show_bug.cgi?id=358260 Repository: kwallet Description

Re: Review Request 128910: [kio_trash] Fill in UDS_LOCAL_PATH in UDSEntry

fixed ASAP IMHO, even if the problems exist since years. - Wolfgang Bauer On Sept. 14, 2016, 8:02 nachm., Wolfgang Bauer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 128831: Check whether kwallet is enabled in Wallet::isOpen(name)

using > > ksecretservice (though m_walletEnabled is already used all over the > > place)... > > > > Anyway +1 > > Wolfgang Bauer wrote: > This is inside the non-ksecretservice codepath, so it makes no difference > whether one uses m_walletEnabled

Re: Review Request 128831: Check whether kwallet is enabled in Wallet::isOpen(name)

ically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128831/#review99502 --- On Sept. 4, 2016, 11:20 p.m., Wolfgang Bauer wrote: > > --- >

  1   2   >