yuyichao accepted this revision.
yuyichao added a comment.
This revision is now accepted and ready to land.
Assuming the coordinate calculations are correct (which I can never get right
without seeing the result) this LGTM.
There was a previous issue on scaled display but I guess this
yuyichao accepted this revision.
yuyichao added a comment.
This revision is now accepted and ready to land.
Is this the new review platform?
LGTM. Hopefully I'm doing the right action here (phabricator always seem
to have way more buttons than I need..)
REVISION DETAIL
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126624/#review91526
---
Ship it!
- Yichao Yu
On 一月 18, 2016, 11:48 a.m., René
> On 一月 11, 2016, 10:17 a.m., Yichao Yu wrote:
> > qt5/style/qtcurve_api.cpp, line 3211
> > <https://git.reviewboard.kde.org/r/126624/diff/1/?file=428407#file428407line3211>
> >
> > Should this be turned on only when KF5 is enabled?
>
> Aleix Po
tps://git.reviewboard.kde.org/r/126624/#comment62107>
Should this be turned on only when KF5 is enabled?
- Yichao Yu
On 一月 4, 2016, 11:28 a.m., René J.V. Bertin wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
tps://git.reviewboard.kde.org/r/126304/#comment61892>
Also here
- Yichao Yu
On 十二月 10, 2015, 12:12 p.m., René J.V. Bertin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboar
for the delay. I'm checking my email for the review requests but maybe
I'm not using the right filter or not subscribing to the right list.
- Yichao Yu
On 十二月 10, 2015, 12:12 p.m., René J.V. Bertin wrote:
>
> ---
> This is an auto
tps://git.reviewboard.kde.org/r/126304/#comment61891>
trailing white space
- Yichao Yu
On 十二月 10, 2015, 12:12 p.m., René J.V. Bertin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboar
://git.reviewboard.kde.org/r/121390/
---
(Updated 十二月 8, 2014, 4:59 p.m.)
Review request for KDE Frameworks, Qt KDE and Yichao Yu.
Repository: qtcurve
Description
---
Yesterday's patches for OS X building broke the build of the Qt5
expensive when X11 is the only
platform that provides a certain functionality ... :)
(I do seem to recall that using function pointers instead of normal
functions was hardly more expensive on x86)
Yichao Yu wrote:
Sorry somehow my filter missed this review request and I've just seen
expensive when X11 is the only
platform that provides a certain functionality ... :)
(I do seem to recall that using function pointers instead of normal
functions was hardly more expensive on x86)
Yichao Yu wrote:
Sorry somehow my filter missed this review request and I've just seen
11 matches
Mail list logo
