D17430: highlight token strings and delimited strings

2019-01-03 Thread aG0aep6G aG0aep6G
aG0aep6G added a comment. In D17430#386026 , @dhaumann wrote: > Unfortunately, this patch also has an issue: > > XSDError in data/syntax/d.xml, at line 413, column 53: Element context is missing required attribute lineEndContext. >

D17430: highlight token strings and delimited strings

2019-01-03 Thread aG0aep6G aG0aep6G
aG0aep6G updated this revision to Diff 48636. aG0aep6G added a comment. - add missing lineEndContext attribute REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17430?vs=47371=48636 BRANCH tokenstring-delimitedstring REVISION DETAIL

D17460: fixups for `extern` and `pragma`

2019-01-03 Thread aG0aep6G aG0aep6G
aG0aep6G added a comment. In D17460#386002 , @dhaumann wrote: > Can you provide an updated patch to fix this? Or at least tell me what lineEndContext should be used here? Fixed, I hope. REPOSITORY R216 Syntax Highlighting BRANCH

D17460: fixups for `extern` and `pragma`

2019-01-03 Thread aG0aep6G aG0aep6G
aG0aep6G updated this revision to Diff 48634. aG0aep6G added a comment. - add missing lineEndContext attribute REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17460?vs=47369=48634 BRANCH extern-and-pragma REVISION DETAIL

D17430: highlight token strings and delimited strings

2018-12-11 Thread aG0aep6G aG0aep6G
aG0aep6G updated this revision to Diff 47371. aG0aep6G added a comment. - add test lines for token strings and delimited strings REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17430?vs=47115=47371 BRANCH tokenstring-delimitedstring REVISION

D17460: fixups for `extern` and `pragma`

2018-12-11 Thread aG0aep6G aG0aep6G
aG0aep6G added a comment. In D17460#374942 , @dhaumann wrote: > Could you also extend the unit test in autotest/input/highlight.d? Done. I also noticed that my last patch broke `version = X;` so I fixed that, too. REPOSITORY R216

D17460: fixups for `extern` and `pragma`

2018-12-11 Thread aG0aep6G aG0aep6G
aG0aep6G updated this revision to Diff 47369. aG0aep6G added a comment. - update test files - fix `version = foo;` - add some more test lines REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17460?vs=47214=47369 BRANCH extern-and-pragma

D17460: fixups for `extern` and `pragma`

2018-12-09 Thread aG0aep6G aG0aep6G
aG0aep6G created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. aG0aep6G requested review of this revision. REVISION SUMMARY add "Objective-C" linkage type fix `extern(C++)` and add support for `extern(C++, ...)`

D17430: highlight token strings and delimited strings

2018-12-08 Thread aG0aep6G aG0aep6G
aG0aep6G created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. aG0aep6G requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH tokenstring-delimitedstring REVISION DETAIL

D17413: stay in context Linkage2/Pragma2 until closing paren

2018-12-08 Thread aG0aep6G aG0aep6G
aG0aep6G added a comment. In D17413#372902 , @dhaumann wrote: > Could you use your real name please? no REPOSITORY R216 Syntax Highlighting BRANCH stay-in-context-until-closing-paren REVISION DETAIL

D17413: stay in context Linkage2/Pragma2 until closing paren

2018-12-07 Thread aG0aep6G aG0aep6G
aG0aep6G updated this revision to Diff 47069. aG0aep6G added a comment. - also fix contexts Version2 and Scope2 REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17413?vs=47062=47069 BRANCH stay-in-context-until-closing-paren REVISION DETAIL

D17406: add attributes `shared` and `__gshared`

2018-12-07 Thread aG0aep6G aG0aep6G
aG0aep6G added a comment. In D17406#372806 , @cullmann wrote: > I can add the keywords myself then, no problem. Great, thanks. > Thought for larger contributions, I really would appreciate some real name, copyright wise I don't

D17413: stay in context Linkage2/Pragma2 until closing paren

2018-12-07 Thread aG0aep6G aG0aep6G
aG0aep6G created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. aG0aep6G requested review of this revision. REVISION SUMMARY Otherwise the closing paren isn't matched properly with the opening one. REPOSITORY R216 Syntax

D17406: add attributes `shared` and `__gshared`

2018-12-07 Thread aG0aep6G aG0aep6G
aG0aep6G added a comment. In D17406#372788 , @cullmann wrote: > Google tells me this are valid attributes: https://dlang.org/spec/attribute.html > > Could you extend the unit test (or add one, if none there) I don't know how to do

D17395: add attributes `shared` and `__gshared`

2018-12-07 Thread aG0aep6G aG0aep6G
aG0aep6G abandoned this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D17395 To: aG0aep6G Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D17406: add attributes `shared` and `__gshared`

2018-12-07 Thread aG0aep6G aG0aep6G
aG0aep6G created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. aG0aep6G requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH shared-__gshared REVISION DETAIL https://phabricator.kde.org/D17406

D17405: add attributes `shared` and `__gshared`

2018-12-07 Thread aG0aep6G aG0aep6G
aG0aep6G abandoned this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D17405 To: aG0aep6G Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D17405: add attributes `shared` and `__gshared`

2018-12-07 Thread aG0aep6G aG0aep6G
aG0aep6G created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. aG0aep6G requested review of this revision. REVISION SUMMARY stay in context Linkage2/Pragma2 until closing paren Otherwise the closing paren isn't matched

D17395: add attributes `shared` and `__gshared`

2018-12-06 Thread aG0aep6G aG0aep6G
aG0aep6G set the repository for this revision to R216 Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D17395 To: aG0aep6G Cc: