Re: KDE review for KWeatherCore

2021-01-06 Thread hanyoung
I've applied the following changes: * Remove @brief * DailyWeatherForecast and HourlyWeatherForecast constructor now take one QDate/QDateTime arguement. The previous "one for all" constructor has been removed * various setters now take const reference * other naming, misc changes Regards, Han

Re: KDE review for KWeatherCore

2020-12-31 Thread hanyoung
I've made some changes to KWeatherCore according to the feedback. Namely: * More Private Classes * Removed inline functions * Lowered coordinates resolution * Listed API services in use on README * Switched to LGPL Regards, Han

KDE review for KWeatherCore

2020-12-21 Thread hanyoung
KWeatherCore: https://invent.kde.org/libraries/kweathercore is a library for querying weather forecast data. During the development of KWeather, we found the need to have a weather library. KWeatherCore is the result of extracting weather data fetching code from KWeather. I think having a

Re: T13975: Move hanyoung/libkweather to frameworks/kweathercore

2020-12-20 Thread hanyoung
Sorry I thought I need to get it moved to frameworks first then KDE review. I'll request for KDE review then beta release first. Sorry for the disturbance. Regards, Han Young