[Differential] [Accepted] D3958: [PackageLoader] Don't access invalid KPluginMetadata

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D3958 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, apol,

[Differential] [Accepted] D3939: fix description for option -t in man page

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D3939 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: lueck, #plasma,

[Differential] [Accepted] D3953: Improve error message

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D3953 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #plasma, mart Cc:

[Differential] [Closed] D3936: use KPluginMetaData::readStringList()

This revision was automatically updated to reflect the committed changes. Closed by commit R242:94edfa149f1d: use KPluginMetaData::readStringList() (authored by mart). REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3936?vs=9660=9663 REVISION DETAIL

[Differential] [Commented On] D3892: [Icon Item] Support non-square icons

mart added a comment. +1 from me REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D3892 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, hein Cc: #frameworks, mart, davidedmundson, plasma-devel,

[Differential] [Request, 10 lines] D3936: use KPluginMetaData::readStringList()

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY replace the last remaining place in pluginloader where a string list was read as a normal

[Differential] [Updated] D3936: use KPluginMetaData::readStringList()

mart added a reviewer: broulik. REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D3936 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, broulik Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed,

[Differential] [Closed] D3934: Fix the help message for --type

This revision was automatically updated to reflect the committed changes. Closed by commit R290:d04769cf7459: Fix the help message for --type (authored by mart). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3934?vs=9648=9649 REVISION DETAIL

[Differential] [Request, 2 lines] D3934: Fix the help message for --type

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY the type as "package", "wallpaper", "theme" was coming from the old plasmapkg2 tool, which

[Differential] [Accepted] D3812: Deprecate Plasma::Package API in PluginLoader

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Frameworks BRANCH deprecate-package-in-pluginloader REVISION DETAIL https://phabricator.kde.org/D3812 EMAIL PREFERENCES

[Differential] [Accepted] D3680: Don't list separately plasmoids from metadata.desktop and .json

mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > packageloader.cpp:251 > + > +if (dirs.contains(dir)) > +continue; use { } BRANCH master REVISION DETAIL

[Differential] [Commented On] D3530: Import plasma-workspace kioslaves

mart added a comment. In https://phabricator.kde.org/D3530#65734, @aacid wrote: > > Dolphin in other environments currently gives a big error until you install plasma-workspace, which defeats the point of the split. > > Maybe Dolphin needs to be patched not to assume remote:/ will

[Differential] [Commented On] D3530: Import plasma-workspace kioslaves

mart added a comment. In https://phabricator.kde.org/D3530#65867, @dfaure wrote: > But desktop:/ and applications:/ make no sense in other workspaces (I'm surprised we even still have applications:/, it's kind of a toy, isn't it?). > > (ok applications:/ might make sense in gnome,

[Differential] [Accepted] D3315: We don't need to iterate through paths

mart accepted this revision. This revision is now accepted and ready to land. BRANCH master REVISION DETAIL https://phabricator.kde.org/D3315 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #frameworks, winterz, mart

[Differential] [Accepted] D3299: Let KPackage know about X-Plasma-RootPath

mart accepted this revision. This revision is now accepted and ready to land. BRANCH master REVISION DETAIL https://phabricator.kde.org/D3299 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #frameworks, lbeltrame, mart

[Differential] [Updated] D3234: Separate sort roles and filters

mart added a comment. to me looks good, is probably better to wait the merge by dan? INLINE COMMENTS > provider_p.h:63 > +Updates, > +ExactId > +}; EntryId? REVISION DETAIL https://phabricator.kde.org/D3234 EMAIL PREFERENCES