[Differential] [Commented On] D1924: KXMLGui: Fix merge indices when removing xmlgui clients with actions in groups.

2016-06-17 Thread svuorela (Sune Vuorela)
svuorela added inline comments. INLINE COMMENTS > kxmlgui_unittest.cpp:306 > +if (i >= actions.count()) > +break; > +QAction *action = actions.at(i); Isn't it better to move the last QCOMPARE(count,count); up first? Or is it to be able to easier debug if something

[Differential] [Accepted] D1902: KRun: add runApplication method.

2016-06-16 Thread svuorela (Sune Vuorela)
svuorela accepted this revision. svuorela added a reviewer: svuorela. BRANCH master REVISION DETAIL https://phabricator.kde.org/D1902 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: dfaure, hein, broulik, davidedmundson, svuorela Cc: #plasma,