sebas accepted this revision.
sebas added a comment.
This revision is now accepted and ready to land.
Almost good, you can add the signalspy and then ship it from my side.
INLINE COMMENTS
> iconitemtest.cpp:526
> +
> + item->setProperty("roundToIconSize", false);
> +
Might as well check for the roundToIconSizeChanged signal here as well. We
should test what we reasonably can, and that's an easy one.
> drosca wrote in iconitem.h:147
> The property is documented, I think there's no point in documenting the
> getters/setters as you can't use them from QML anyway.
Right. :)
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
arcpatch-D4689
REVISION DETAIL
https://phabricator.kde.org/D4689
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: drosca, sebas, #plasma
Cc: sebas, mart, davidedmundson, plasma-devel, #frameworks, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, apol
