apol added inline comments.
INLINE COMMENTS
> knotificationmanager.cpp:56
>
> +bool inSandbox;
> +bool portalDBusServiceExists;
These could be a local variable, it's not being used outside for figuring out
the backend.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabr
jgrulich added inline comments.
INLINE COMMENTS
> apol wrote in knotificationmanager.cpp:93
> Maybe instead of querying for dbus things we could figure out a what
> QPlatformTheme is in use somehow?
Not sure how that would help. It would help maybe to detect whether we are in
sandbox if we che
apol added inline comments.
INLINE COMMENTS
> knotificationmanager.cpp:93
> +
> +if (d->inSandbox) {
> +QDBusConnectionInterface *interface =
> QDBusConnection::sessionBus().interface();
Maybe instead of querying for dbus things we could figure out a what
QPlatformTheme is in use s
apol added a comment.
Some coding style suggestions.
General +1.
INLINE COMMENTS
> knotificationmanager.cpp:85
> +const QString runtimeDir = qgetenv("XDG_RUNTIME_DIR");
> +if (!runtimeDir.isEmpty()) {
> +d->inSandbox = QFile::exists(runtimeDir +
> QLatin1String("/flatpak-in
