subdiff created this revision. subdiff added a project: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY The ToolButton has a rather odd looking style, which often conflicts with its placement and other lines in an applications: It shows the normal Button frame, when hovered. For example take a look at the calendar: F2611313: video-alt.mp4 <https://phabricator.kde.org/F2611313> It doesn't fit the overall design and coders often srew up the borders, which are in the upper example not aligned with the other lines and even overlap with the pin highlight. In comparision with the simplified background colors: F2611324: video.mp4 <https://phabricator.kde.org/F2611324> The highlight color for the background fits together with the other elements much better and the misalignment is less noticeable because of the rounded edges. That there is no overlap anymore is only lucky though. If you look closely the pin in the top right corner of the calendar is a (checkable) ToolButton as well and has a stronger checked color after the patch. I would say it's a matter of taste, but we could soften this by reducing the opacity also in pressed/checked mode (when hovered it's already at 0.25%) in any case or only if it is a checkable ToolButton . REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4797 AFFECTED FILES src/declarativeimports/plasmastyle/ToolButtonStyle.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, #plasma Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
