davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY Unlike the visible property, the opacity does not inherit parent values and refers to the relative opacity of that item. The current style code is checking that an item we can't control externally has an opacity > 0, this doesn't really acheive anything. This was a breakage from when we ported *to* QtQuickControls 1. TEST PLAN I was running a plasmoid I had written years ago (my RSS tutorial) and had abnormally high CPU usage in an animation that I didn't have then. Code was: BusyIndicator { opacity: 0 running: true } REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D4729 AFFECTED FILES src/declarativeimports/plasmastyle/BusyIndicatorStyle.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol