davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY Just because the metadata is invalid doesn't mean the DataEngine actually failed to load, we're still returning a valid object, and as seen with the MPris DataEngine bug. It's important that we still release it properly. It looks like this was designed to make sure you don't delete the null data engine multiple times, but that shouldn't cause an issue here. TEST PLAN https://phabricator.kde.org/tag/plasma/ REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D4556 AFFECTED FILES src/plasma/dataengine.cpp src/plasma/dataengineconsumer.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol