[KParts] patch: don't emit urlChanged, when url is the same

2013-12-24 Thread Michal Humpula
Hi there, as suggested without fully functional reviewboard, here is the little patch for discussion. Emit urlChanged only when actually changing url trough setUrl. The drawback of this is that now the fast assignment is replaced by possibly expensive string comparison. On the other hand,

Re: [KParts] patch: don't emit urlChanged, when url is the same

2013-12-24 Thread David Faure
On Tuesday 24 December 2013 12:30:56 Michal Humpula wrote: Hi there, as suggested without fully functional reviewboard, here is the little patch for discussion. Emit urlChanged only when actually changing url trough setUrl. The drawback of this is that now the fast assignment is replaced

Re: [KParts] patch: don't emit urlChanged, when url is the same

2013-12-24 Thread David Faure
On Tuesday 24 December 2013 13:50:29 Michal Humpula wrote: On Tuesday 24 of December 2013 13:22:05 David Faure wrote: On Tuesday 24 December 2013 12:30:56 Michal Humpula wrote: Hi there, as suggested without fully functional reviewboard, here is the little patch for discussion.

Re: [KParts] patch: don't emit urlChanged, when url is the same

2013-12-24 Thread Michal Humpula
On Tuesday 24 of December 2013 14:05:36 David Faure wrote: On Tuesday 24 December 2013 13:50:29 Michal Humpula wrote: On Tuesday 24 of December 2013 13:22:05 David Faure wrote: On Tuesday 24 December 2013 12:30:56 Michal Humpula wrote: Hi there, as suggested without fully