Re: [RFC] [kservice] KPluginMetadata indexing

2014-12-20 Thread David Faure
On Sunday 16 November 2014 13:31:46 Sebastian Kügler wrote: The problem with the change detection is of course - Which process is the one watching? - What to do when this process is not running during plugin installation? (User could be logged out, for example) Argh, yes, that's the kded +

Re: [RFC] [kservice] KPluginMetadata indexing

2014-11-17 Thread Sebastian Kügler
Hi Milian, Thanks for looking at my patches. Since the branch, as you noticed, is quite contaminated with unrelated changes, merging in and out stuff, I'll push these changes to a cleaned branch, and will address the issues you pointed out. I'll post a new RR then. On Sunday, November 16,

Re: [RFC] [kservice] KPluginMetadata indexing

2014-11-17 Thread Sebastian Kügler
Hi David, On Sunday, November 16, 2014 18:10:27 David Faure wrote: Cool that you're looking into this. On Thursday 06 November 2014 03:44:58 Sebastian Kügler wrote: - a small tool called kplugin-update-index collects the json metadata from the plugins, and puts the list of plugins in a

Re: [RFC] [kservice] KPluginMetadata indexing

2014-11-16 Thread Sebastian Kügler
On Thursday, November 06, 2014 17:06:38 Mark Gaiser wrote: Ah right, i think i missed the I/O reducing goal in your initial post. I haven't checked your draft implementation in detail, but what you might want to do is: - Monitor all plugin folders for changes - If a change in any of the

Re: [RFC] [kservice] KPluginMetadata indexing

2014-11-16 Thread Milian Wolff
On Thursday 06 November 2014 03:44:58 Sebastian Kügler wrote: Hi all, especially Alex and David, tl;dr: I've done a proof-of-concept implementation of a metadata index for KPluginTrader::query(), the main entry point when it comes to finding binary plugins. This index considerably speeds

Re: [RFC] [kservice] KPluginMetadata indexing

2014-11-16 Thread David Faure
Hi Sebas, Cool that you're looking into this. On Thursday 06 November 2014 03:44:58 Sebastian Kügler wrote: - a small tool called kplugin-update-index collects the json metadata from the plugins, and puts the list of plugins in a given plugin directory into a QJsonArray, and dumps that in

Re: [RFC] [kservice] KPluginMetadata indexing

2014-11-11 Thread Sebastian Kügler
Hi Nicolas, Sorry for my late reply, I thought I had replied, but apparently that was never sent. :/ On Thursday, November 06, 2014 16:26:01 Nicolás Alvarez wrote: 2014-11-05 23:44 GMT-03:00 Sebastian Kügler se...@kde.org: So, this code is in a bit of a draft stage, I'd very much welcome

Re: [RFC] [kservice] KPluginMetadata indexing

2014-11-06 Thread Mark Gaiser
On Thu, Nov 6, 2014 at 3:44 AM, Sebastian Kügler se...@kde.org wrote: Hi all, especially Alex and David, tl;dr: I've done a proof-of-concept implementation of a metadata index for KPluginTrader::query(), the main entry point when it comes to finding binary plugins. This index considerably

Re: [RFC] [kservice] KPluginMetadata indexing

2014-11-06 Thread Milian Wolff
On Thursday 06 November 2014 10:09:51 Mark Gaiser wrote: On Thu, Nov 6, 2014 at 3:44 AM, Sebastian Kügler se...@kde.org wrote: Hi all, especially Alex and David, tl;dr: I've done a proof-of-concept implementation of a metadata index for KPluginTrader::query(), the main entry point

Re: [RFC] [kservice] KPluginMetadata indexing

2014-11-06 Thread Marco Martin
On Thursday 06 November 2014, Sebastian Kügler wrote: Basic Mechanism - a small tool called kplugin-update-index collects the json metadata from the plugins, and puts the list of plugins in a given plugin directory into a QJsonArray, and dumps that in Qt's json binary format to disk since

Re: [RFC] [kservice] KPluginMetadata indexing

2014-11-06 Thread Sebastian Kügler
On Thursday, November 06, 2014 10:09:51 Mark Gaiser wrote: I'm curious about one thing. Have you done some profiling on the current KPluginMetaData to see where the actual hot spot is? In case you don't know how to do that, here are some tips: 1. Recompile Qt with debug symbols (not debug

Re: [RFC] [kservice] KPluginMetadata indexing

2014-11-06 Thread Mark Gaiser
On Thu, Nov 6, 2014 at 4:43 PM, Sebastian Kügler se...@kde.org wrote: On Thursday, November 06, 2014 10:09:51 Mark Gaiser wrote: I'm curious about one thing. Have you done some profiling on the current KPluginMetaData to see where the actual hot spot is? In case you don't know how to do that,

Re: [RFC] [kservice] KPluginMetadata indexing

2014-11-06 Thread Milian Wolff
On Thursday 06 November 2014 17:06:38 Mark Gaiser wrote: On Thu, Nov 6, 2014 at 4:43 PM, Sebastian Kügler se...@kde.org wrote: On Thursday, November 06, 2014 10:09:51 Mark Gaiser wrote: I'm curious about one thing. Have you done some profiling on the current KPluginMetaData to see where the

Re: [RFC] [kservice] KPluginMetadata indexing

2014-11-06 Thread Nicolás Alvarez
2014-11-05 23:44 GMT-03:00 Sebastian Kügler se...@kde.org: So, this code is in a bit of a draft stage, I'd very much welcome feedback about the approach, and of course the code itself. It can be found in kservice[sebas/kpluginindex]. the kpluginmetadata autotest gives a useful testing target.

[RFC] [kservice] KPluginMetadata indexing

2014-11-05 Thread Sebastian Kügler
Hi all, especially Alex and David, tl;dr: I've done a proof-of-concept implementation of a metadata index for KPluginTrader::query(), the main entry point when it comes to finding binary plugins. This index considerably speeds up all current use cases, but comes at the cost of having to