Re: [extra-cmake-modules] modules: Revert "use the NAME_PREFIX only for the test, not for the executable"

2014-06-14 Thread Alex Merry
On 07/06/14 23:31, Alex Merry wrote: > OK, since this seems to be what pretty much everyone who has said > anything to me about this wants, let's make the name prefix only for the > test name, then. I won't have time until Friday. If anyone wants to > create an RR for it before then, I'll just say

Re: [extra-cmake-modules] modules: Revert "use the NAME_PREFIX only for the test, not for the executable"

2014-06-07 Thread Alex Merry
On 07/06/14 19:29, David Faure wrote: > On Friday 06 June 2014 20:55:16 Alex Merry wrote: >> I guess this depends on the purpose of the name prefix. If it's purely >> to say "go look here in the codebase for this test", which is how it was >> used in kdelibs before the splitting, just changing the

Re: [extra-cmake-modules] modules: Revert "use the NAME_PREFIX only for the test, not for the executable"

2014-06-07 Thread David Faure
On Friday 06 June 2014 20:55:16 Alex Merry wrote: > I guess this depends on the purpose of the name prefix. If it's purely > to say "go look here in the codebase for this test", which is how it was > used in kdelibs before the splitting, just changing the test name is > fine. Yes, that was the id

Re: [extra-cmake-modules] modules: Revert "use the NAME_PREFIX only for the test, not for the executable"

2014-06-06 Thread Alex Merry
On 06/06/14 20:29, David Faure wrote: > On Saturday 10 May 2014 10:28:43 Alex Merry wrote: >> Git commit 7213137a75e832976c25168ae640d26369c771a7 by Alex Merry. >> Committed on 10/05/2014 at 10:26. >> Pushed by alexmerry into branch 'master'. >> >> Revert "use the NAME_PREFIX only for the test, not

Re: [extra-cmake-modules] modules: Revert "use the NAME_PREFIX only for the test, not for the executable"

2014-06-06 Thread David Faure
On Saturday 10 May 2014 10:28:43 Alex Merry wrote: > Git commit 7213137a75e832976c25168ae640d26369c771a7 by Alex Merry. > Committed on 10/05/2014 at 10:26. > Pushed by alexmerry into branch 'master'. > > Revert "use the NAME_PREFIX only for the test, not for the executable" I didn't follow the fu

Re: [extra-cmake-modules] modules: Revert "use the NAME_PREFIX only for the test, not for the executable"

2014-05-10 Thread Alex Merry
On 10/05/14 20:37, Patrick Spendrin wrote: > As you can see in my commits in ktextwidgets, kio, kxmlgui and several > other locations, only the add_test call had the name prefix and not the > executable. > One occurance where the previous (and now current) will fail is kxmlgui > autotests, where df

Re: [extra-cmake-modules] modules: Revert "use the NAME_PREFIX only for the test, not for the executable"

2014-05-10 Thread Patrick Spendrin
Am 10.05.2014 12:28, schrieb Alex Merry: > Git commit 7213137a75e832976c25168ae640d26369c771a7 by Alex Merry. > Committed on 10/05/2014 at 10:26. > Pushed by alexmerry into branch 'master'. > > Revert "use the NAME_PREFIX only for the test, not for the executable" > > This reverts commits > b90

Re: [extra-cmake-modules] modules: Revert "use the NAME_PREFIX only for the test, not for the executable"

2014-05-10 Thread Bhushan Shah
On Sat, May 10, 2014 at 3:58 PM, Alex Merry wrote: > These were causing configure failures in frameworks that use > ECMAddTests. Still kcoreaddons is failing.. -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode ___ Kde-frameworks-de

[extra-cmake-modules] modules: Revert "use the NAME_PREFIX only for the test, not for the executable"

2014-05-10 Thread Alex Merry
Git commit 7213137a75e832976c25168ae640d26369c771a7 by Alex Merry. Committed on 10/05/2014 at 10:26. Pushed by alexmerry into branch 'master'. Revert "use the NAME_PREFIX only for the test, not for the executable" This reverts commits b90b64632f46e929f26ab9a4ee0033478febe0eb ba8600088b8838d54