D10024: Add supportedSchemes feature

2018-01-22 Thread Milian Wolff
mwolff created this revision. mwolff added reviewers: Plasma, dfaure. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. mwolff requested review of this revision. REVISION SUMMARY This addds a whitelist of supported URL

D10024: Add supportedSchemes feature

2018-01-22 Thread Milian Wolff
mwolff added a dependent revision: D10025: Use KFileWidget::setSupportedSchemes when available. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10024 To: mwolff, #plasma, dfaure Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abe

D10024: Add supportedSchemes feature

2018-01-22 Thread Aleix Pol Gonzalez
apol added a comment. Makes sense I guess. Sounds like it would be useful to set this through kiosk, would that work? INLINE COMMENTS > kdiroperator.cpp:2650 > +{ > +d->supportedSchemes = schemes; > +rereadDir(); only if d->supportedSchemes != schemes? REPOSITORY R241 KIO RE

D10024: Add supportedSchemes feature

2018-01-23 Thread Milian Wolff
mwolff added a comment. In https://phabricator.kde.org/D10024#194431, @apol wrote: > Makes sense I guess. > > Sounds like it would be useful to set this through kiosk, would that work? Probably, but I have zero experience about kiosk. I'd have to read the defaults from a setti

D10024: Add supportedSchemes feature

2018-01-23 Thread Marco Martin
mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. ship it with the extra check Aleix noted REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D10024 To: mwolff, #plasma, dfaure, mart Cc: mart, apol, plasma-de

D10024: Add supportedSchemes feature

2018-01-24 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > kfilewidget.h:498 > +/** > + * Set the URL schemes that the file widget should allow navigating to. > + * All of these public methods should indicate that the default list is *empty* and that empty means "all schemes are supported". I

D10024: Add supportedSchemes feature

2018-01-24 Thread Milian Wolff
mwolff updated this revision to Diff 25891. mwolff added a comment. extend apidox, mention empty list == everything allowed REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10024?vs=25764&id=25891 BRANCH master REVISION DETAIL https://phabricator.kde.org/D1

D10024: Add supportedSchemes feature

2018-01-24 Thread Milian Wolff
mwolff added a comment. In https://phabricator.kde.org/D10024#194708, @mart wrote: > ship it with the extra check Aleix noted Can you guys explain me more what would be required for KIOSK support? REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.or

D10024: Add supportedSchemes feature

2018-01-30 Thread Milian Wolff
mwolff added a comment. @apol any hint what to do about KIOSK? any resources I should have a look at? REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D10024 To: mwolff, #plasma, dfaure, mart Cc: ngraham, mart, apol, plasma-devel, #frameworks, michaelh, Zr

D10024: Add supportedSchemes feature

2018-02-06 Thread Milian Wolff
mwolff added a comment. I've committed this now. If someone tells me how to add KIOSK support, I can add that later on as needed REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D10024 To: mwolff, #plasma, dfaure, mart Cc: ngraham, mart, apol, plasma-deve

D10024: Add supportedSchemes feature

2018-02-06 Thread Milian Wolff
This revision was automatically updated to reflect the committed changes. Closed by commit R241:6ab218dba91f: Add supportedSchemes feature (authored by mwolff). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10024?vs=25891&id=26632#toc REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE h