D10166: Add -Wlogical-op -Wzero-as-null-pointer-constant to KF5 warnings

This revision was automatically updated to reflect the committed changes. Closed by commit R240:60cb4b74bce8: Add -Wlogical-op -Wzero-as-null-pointer-constant to KF5 warnings (authored by aacid). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D10166: Add -Wlogical-op -Wzero-as-null-pointer-constant to KF5 warnings

apol accepted this revision. apol added inline comments. INLINE COMMENTS > aacid wrote in KDEFrameworkCompilerSettings.cmake:70 > problem it's i also need the version check and since we already have it here > it doesn't make the code any more simpler. Ugh true, sorry. REPOSITORY R240 Extra

D10166: Add -Wlogical-op -Wzero-as-null-pointer-constant to KF5 warnings

aacid added inline comments. INLINE COMMENTS > apol wrote in KDEFrameworkCompilerSettings.cmake:70 > Maybe you can add `-Wzero-as-null-pointer-constant` to the if above which is > `gcc or clang`? problem it's i also need the version check and since we already have it here it doesn't make the

D10166: Add -Wlogical-op -Wzero-as-null-pointer-constant to KF5 warnings

apol added a comment. INLINE COMMENTS > KDEFrameworkCompilerSettings.cmake:70 > if (NOT CMAKE_CXX_COMPILER_VERSION VERSION_LESS "5.0.0") > - set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wsuggest-override" ) > + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wsuggest-override >

D10166: Add -Wlogical-op -Wzero-as-null-pointer-constant to KF5 warnings

cgiboudeaux added a comment. Thanks, just remove the trailing space before the 2 closing parenthesis. REPOSITORY R240 Extra CMake Modules BRANCH arcpatch-D10166 (branched from master) REVISION DETAIL https://phabricator.kde.org/D10166 To: aacid, cgiboudeaux Cc: kde-frameworks-devel,

D10166: Add -Wlogical-op -Wzero-as-null-pointer-constant to KF5 warnings

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH arcpatch-D10166 (branched from master) REVISION DETAIL https://phabricator.kde.org/D10166 To: aacid, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem,

D10166: Add -Wlogical-op -Wzero-as-null-pointer-constant to KF5 warnings

aacid updated this revision to Diff 36684. aacid added a comment. Restricted Application edited subscribers, added: kde-buildsystem, kde-frameworks-devel; removed: Frameworks, Build System. make logical-op gcc only REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D10166: Add -Wlogical-op -Wzero-as-null-pointer-constant to KF5 warnings

aacid planned changes to this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D10166 To: aacid Cc: cgiboudeaux, dhaumann, #frameworks, #build_system, michaelh

D10166: Add -Wlogical-op -Wzero-as-null-pointer-constant to KF5 warnings

aacid added a comment. -Wzero-as-null-pointer-constant does exist here, you're right the other one doesn't I'll try to get this fixed once i recover for the havoc caused by my hd dying REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D10166 To: aacid

D10166: Add -Wlogical-op -Wzero-as-null-pointer-constant to KF5 warnings

cgiboudeaux added a comment. These flags are not in the Clang warnings (list for each version here: https://github.com/Barro/compiler-warnings) REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D10166 To: aacid Cc: cgiboudeaux, dhaumann, #frameworks,

D10166: Add -Wlogical-op -Wzero-as-null-pointer-constant to KF5 warnings

dhaumann added a comment. +1, but someone else must approve. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D10166 To: aacid Cc: dhaumann, #frameworks, #build_system, michaelh

D10166: Add -Wlogical-op -Wzero-as-null-pointer-constant to KF5 warnings

aacid created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. aacid requested review of this revision. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL