This revision was automatically updated to reflect the committed changes.
Closed by commit R243:61d39cae560a: Use nullptr for passing a null pointer to
crc32 (authored by aacid).
REPOSITORY
R243 KArchive
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10168?vs=26154=28852
REVISION
mpyne accepted this revision.
mpyne added a comment.
This revision is now accepted and ready to land.
Actually `-Wzero-as-null-pointer-constant` is probably a good idea, and this
is a correct fix. A decade ago when everything was going from 32 to 64-bits,
we ran into a JuK crash bug because
aacid added a comment.
ping?
REPOSITORY
R243 KArchive
REVISION DETAIL
https://phabricator.kde.org/D10168
To: aacid
Cc: #frameworks, michaelh
aacid created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
aacid requested review of this revision.
REVISION SUMMARY
I'm a bit unconvinced, wihtout it we get a warning if we enable
-Wzero-as-null-pointer-constant
