ngraham created this revision.
ngraham added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
ngraham requested review of this revision.
REVISION SUMMARY
FEATURE: 389880
FIXED-IN: 5.44
TEST PLAN
Shortcut works and toggles the aside preview.
However, in doing
ngraham edited the test plan for this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10314
To: ngraham, #frameworks
Cc: michaelh, ngraham
markg added a comment.
+1 for the idea, just a question about the key.
Windows uses ALT+P:
https://lifehacker.com/5811238/quickly-show-the-preview-pane-in-windows-7-with-alt-%252B-p
I don't know what Finder uses, you can probably tell ;)
As it stands now, i'd go for ALT+P. It also fee
ngraham added a comment.
I use F11 to be consistent with Dolphin, where F11 toggles the information
panel. It's not //exactly// the same thing, but I figured re-using existing KDE
muscle memory was worthwhile. Alt-P could work too though, and would probably
conflict less. Easier to type on a
ngraham updated this revision to Diff 26584.
ngraham removed a reviewer: markg.
ngraham added a comment.
This revision now requires review to proceed.
Fix "ambiguous shortcut" issue by using plain old QKey instead of QKeySequence
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabr
markg accepted this revision.
markg added a comment.
This revision is now accepted and ready to land.
In https://phabricator.kde.org/D10314#201388, @ngraham wrote:
> I use F11 to be consistent with Dolphin, where F11 toggles the information
panel. It's not //exactly// the same thing, but
ngraham added a comment.
Fixed it!
Changing Dolphin to Alt-P would open a can of worms since the other panels
are triggered with Function keys, so I think F11 makes sense here.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10314
To: ngraham, #fra
markg accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10314
To: ngraham, #frameworks, markg
Cc: markg, michaelh, ngraham
markg added a comment.
In https://phabricator.kde.org/D10314#201419, @ngraham wrote:
> Fixed it!
>
> Changing Dolphin to Alt-P would open a can of worms since the other panels
are triggered with Function keys, so I think F11 makes sense here.
Nice!
That could indeed be a
ngraham closed this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10314
To: ngraham, #frameworks, markg
Cc: markg, michaelh, ngraham
ltoscano reopened this revision.
ltoscano added a comment.
This revision is now accepted and ready to land.
Let phabricator close it...
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10314
To: ngraham, #frameworks, markg
Cc: ltoscano, markg, michaelh, n
ltoscano closed this revision.
ltoscano added a comment.
Too late.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10314
To: ngraham, #frameworks, markg
Cc: ltoscano, markg, michaelh, ngraham
ngraham added a comment.
Hmm, I thought I did. I just did a standard `arc land`.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10314
To: ngraham, #frameworks, markg
Cc: ltoscano, markg, michaelh, ngraham
ltoscano added a comment.
Interesting, it seems that phabricator updated the link to the commit, but
did not close the bug. Let's ignore it, unless it happens again.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10314
To: ngraham, #frameworks, markg
Cc: ltoscano, mark
graesslin added a comment.
I'm a little bit late to the party, but F11is kind of the standard key for
fullscreen.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10314
To: ngraham, #frameworks, markg
Cc: graesslin, ltoscano, markg, michaelh, ngraham
ngraham added a comment.
Yeah, and Dolphin already overloads that by using F11 to show and hide the
Information panel. I wouldn't object to using a different keyboard shortcut,
but then we'd want to but we'd want to do it for all of for Dolphin's panels,
and change the shortcuts here, too, w
graesslin added a comment.
In https://phabricator.kde.org/D10314#201553, @ngraham wrote:
> Yeah, and Dolphin already overloads that by using F11 to show and hide the
Information panel. I wouldn't object to using a different keyboard shortcut,
but then we'd want to but we'd want to do it
ngraham edited the test plan for this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10314
To: ngraham, #frameworks, markg
Cc: graesslin, ltoscano, markg, michaelh, ngraham
18 matches
Mail list logo
