This revision was automatically updated to reflect the committed changes.
Closed by commit R265:b1e30535eca4: Improve KLanguageButton::insertLanguage
when no name is passed (authored by aacid).
REPOSITORY
R265 KConfigWidgets
CHANGES SINCE LAST UPDATE
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
LGTM
REPOSITORY
R265 KConfigWidgets
BRANCH
arcpatch-D10444_1
REVISION DETAIL
https://phabricator.kde.org/D10444
To: aacid, apol
Cc: apol, #frameworks, michaelh
aacid updated this revision to Diff 27027.
aacid added a comment.
fix suggestion by Aleix
REPOSITORY
R265 KConfigWidgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10444?vs=26924=27027
BRANCH
arcpatch-D10444_1
REVISION DETAIL
https://phabricator.kde.org/D10444
AFFECTED
aacid added inline comments.
INLINE COMMENTS
> apol wrote in klanguagebutton.cpp:148
> Why `QStringLiteral("locale") + QLatin1Char('/')`?
Because i wrote that as result of copy, i'll fix it.
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D10444
To: aacid
Cc:
apol added inline comments.
INLINE COMMENTS
> klanguagebutton.cpp:148
> if (name.isEmpty()) {
> -text = languageCode;
> -QLocale locale(languageCode);
> -if (locale != QLocale::c()) {
> -text = locale.nativeLanguageName();
> -} else {
> -
aacid updated this revision to Diff 26924.
aacid added a comment.
Do not return "without name" in nameFromEntryFile
An empty string is better so the fallback ifs try to get a name for the
language code
REPOSITORY
R265 KConfigWidgets
CHANGES SINCE LAST UPDATE
aacid created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
aacid requested review of this revision.
REVISION SUMMARY
Move the reading of kf5_entry.desktop from KLanguageButton::loadAllLanguages
to
