michaelh created this revision.
michaelh added reviewers: Baloo, Frameworks, dfaure, alexeymin.
Restricted Application added a project: Frameworks.
michaelh requested review of this revision.
REVISION SUMMARY
Keep monitoring until terminated by ctrl+c
TEST PLAN
While monitor is running variou
michaelh added a project: Baloo.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D10712
To: michaelh, #baloo, #frameworks, dfaure, alexeymin
Cc: ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin
michaelh added a comment.
*ping*
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D10712
To: michaelh, #baloo, #frameworks, dfaure, alexeymin
Cc: ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin
mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.
some minor comments, otherwise lgtm
INLINE COMMENTS
> monitorcommand.cpp:45
> +connect(m_dbusServiceWatcher, &QDBusServiceWatcher::serviceUnregistered,
> [this]() {
> +
michaelh updated this revision to Diff 28909.
michaelh marked 8 inline comments as done.
michaelh edited the test plan for this revision.
michaelh added a comment.
- Apply suggested changes
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10712?vs=27678&id=2890
michaelh added inline comments.
INLINE COMMENTS
> mwolff wrote in monitorcommand.cpp:45
> just make it i18n("Baloo died"), though I personally think that message
> should be improved - maybe "Baloo became unavailable" ?
>
> also, call `balooIsNotAvailable()` from the slot here, that way you saf
mwolff accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R293 Baloo
BRANCH
resume-wait (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D10712
To: michaelh, #baloo, #frameworks, dfaure, alexeymin, mwolff
Cc: mwolff, ashaposhnikov, michae
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:add3284efdca: balooctl monitor: Resume to wait for
service (authored by michaelh).
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10712?vs=28909&id=28933
REVISION DE
