D10749: Add ECMSetupQtPluginMacroNames

This revision was automatically updated to reflect the committed changes. Closed by commit R240:36d42640576e: Add ECMSetupQtPluginMacroNames (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10749?vs=29426&id=29791#toc REPOSITORY R240 Extra CMake Modules CHANGES S

D10749: Add ECMSetupQtPluginMacroNames

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH addECMSetupQtPluginMacroNames REVISION DETAIL https://phabricator.kde.org/D10749 To: kossebau, #build_system, #frameworks, apol Cc: apol, michaelh, ngraham

D10749: Add ECMSetupQtPluginMacroNames

kossebau added a comment. In D10749#225709 , @apol wrote: > LGTM Thanks for having had a look :) > Do you think it would be possible to come up with a test for it? Sadly no experience with cmake stuff testing and no initial idea

D10749: Add ECMSetupQtPluginMacroNames

apol added a comment. LGTM Do you think it would be possible to come up with a test for it? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D10749 To: kossebau, #build_system, #frameworks Cc: apol, michaelh, ngraham

D10749: Add ECMSetupQtPluginMacroNames

kossebau added a comment. Questions had been: A) names of macro and arguments okay? B) other/similar/related use cases which should be covered? C) how to design argument passing for all the arg1, arg2, arg3? Is the currrent approach sane or how to support someone needing some arg5?

D10749: Add ECMSetupQtPluginMacroNames

kossebau retitled this revision from "[RFC] Add ECMSetupQtPluginMacroNames" to "Add ECMSetupQtPluginMacroNames". kossebau edited the summary of this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D10749 To: kossebau, #build_system, #frameworks Cc: