This revision was automatically updated to reflect the committed changes.
Closed by commit R241:bff960d67162: Ensure that the model is set when
resetResizing is called (authored by fabiank).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11998?vs=31525=31578
dfaure accepted this revision.
REPOSITORY
R241 KIO
BRANCH
fixConnectWarning
REVISION DETAIL
https://phabricator.kde.org/D11998
To: fabiank, dfaure, ngraham, apol
Cc: apol, ngraham, #frameworks, michaelh, bruns
apol accepted this revision.
apol added a comment.
I'm not familiar with the issue but the patch makes 100% sense.
REPOSITORY
R241 KIO
BRANCH
fixConnectWarning
REVISION DETAIL
https://phabricator.kde.org/D11998
To: fabiank, dfaure, ngraham, apol
Cc: apol, ngraham, #frameworks,
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Confirmed that this fixes the issue, and it makes sense, code-wise. I did not
see any resizing-related regressions.
REPOSITORY
R241 KIO
BRANCH
fixConnectWarning
REVISION DETAIL
fabiank added a reviewer: dfaure.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D11998
To: fabiank, dfaure
Cc: #frameworks, michaelh, ngraham, bruns
fabiank created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
fabiank requested review of this revision.
REVISION SUMMARY
Previously, KDirOperatorDetailView::setModel called resetResizing before
QTreeView::setModel
