D12221: Fix problem that font/italic/... attributes no longer work with e.g. >= Qt 5.9

2018-04-16 Thread René J . V . Bertin
rjvbb added a comment. Actually, no. I haven't been following that part at all (and am taking 2 weeks off of intensive dev stuff ;) ) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12221 To: cullmann, #frameworks, #kate, dhaumann Cc: rjvbb, bcooksley, ngraham,

D12221: Fix problem that font/italic/... attributes no longer work with e.g. >= Qt 5.9

2018-04-15 Thread Nathaniel Graham
ngraham added a subscriber: rjvbb. ngraham added a comment. In D12221#246716 , @dhaumann wrote: > @ngraham So what is the current state of a proper fix in KFontRequester? I have no idea, sorry. The issue is honestly too complicated for me

D12221: Fix problem that font/italic/... attributes no longer work with e.g. >= Qt 5.9

2018-04-15 Thread Ben Cooksley
bcooksley added a comment. @dhaumann Please note that Phabricator review closing can take a few minutes to be processed. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12221 To: cullmann, #frameworks, #kate, dhaumann Cc: bcooksley, ngraham, dhaumann, michaelh,

D12221: Fix problem that font/italic/... attributes no longer work with e.g. >= Qt 5.9

2018-04-15 Thread Dominik Haumann
dhaumann added a comment. @ngraham So what is the current state of a proper fix in KFontRequester? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12221 To: cullmann, #frameworks, #kate, dhaumann Cc: ngraham, dhaumann, michaelh, kevinapavew, bruns, demsking,

D12221: Fix problem that font/italic/... attributes no longer work with e.g. >= Qt 5.9

2018-04-15 Thread Nathaniel Graham
ngraham added a comment. Nice fix, but it would be a shame if every client needs to work around this in the same way. I'm still holding out hope for a fix to KFontRequester, if possible. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12221 To: cullmann,

D12221: Fix problem that font/italic/... attributes no longer work with e.g. >= Qt 5.9

2018-04-15 Thread Christoph Cullmann
cullmann added a comment. Perhaps the fix is only a hack, but at least it solves the issue for me on my company workstation ;=) I was confused what did look strange after the upgrade, until I noticed the missing bold keywords. REPOSITORY R39 KTextEditor REVISION DETAIL

D12221: Fix problem that font/italic/... attributes no longer work with e.g. >= Qt 5.9

2018-04-15 Thread Dominik Haumann
dhaumann added a comment. See: - https://bugs.kde.org/show_bug.cgi?id=376094 - https://bugs.kde.org/show_bug.cgi?id=383665 - https://bugs.kde.org/show_bug.cgi?id=387401 - https://bugs.kde.org/show_bug.cgi?id=391040 They all are closed as a general KFontChooser issue. Maybe we

D12221: Fix problem that font/italic/... attributes no longer work with e.g. >= Qt 5.9

2018-04-15 Thread Christoph Cullmann
cullmann closed this revision. cullmann added a comment. Git commit 4d91fa7e918d983e6569798dfe20c7c9faf4bb9e by Christoph Cullmann. Committed on 15/04/2018 at 11:36. Pushed by cullmann into branch 'master'. Fix problem that font/italic/... attributes no longer work with e.g. >= Qt 5.9

D12221: Fix problem that font/italic/... attributes no longer work with e.g. >= Qt 5.9

2018-04-15 Thread Christoph Cullmann
cullmann added a comment. > Btw there are bug reports for this. Could you link the Kate related ones, if existing? I failed to find them :( I remembered that this was brought up some time ago, but I had no time to take a look at that time. And now I no longer find the mails/bugs :P

D12221: Fix problem that font/italic/... attributes no longer work with e.g. >= Qt 5.9

2018-04-15 Thread Dominik Haumann
dhaumann added a comment. Btw there are bug reports for this. Could you link the Kate related ones, if existing? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12221 To: cullmann, #frameworks, #kate, dhaumann Cc: dhaumann, michaelh, kevinapavew, ngraham, bruns,

D12221: Fix problem that font/italic/... attributes no longer work with e.g. >= Qt 5.9

2018-04-15 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. A simple fix for a severe issue - please commit! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12221 To: cullmann, #frameworks, #kate, dhaumann Cc:

D12221: Fix problem that font/italic/... attributes no longer work with e.g. >= Qt 5.9

2018-04-15 Thread Christoph Cullmann
cullmann created this revision. cullmann added reviewers: Frameworks, Kate. Restricted Application added projects: Kate, Frameworks. cullmann requested review of this revision. REVISION SUMMARY On e.g. openSUSE 15.0, which has 5.9 as default Qt, bold/italic/... styles no longer work. The