elvisangelaccio removed a reviewer: Frameworks.
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D12342
To: michaelh, #baloo, #dolphin, elvisangelaccio, #frameworks
Cc: ashaposhnikov, astippich, spoorun
elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> michaelh wrote in CMakeLists.txt:4
> There is not indication that `baloo-widgets` is an Application. Yet it
> resides in the `kde/applicatio
michaelh added a reviewer: elvisangelaccio.
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D12342
To: michaelh, #baloo, #dolphin, #frameworks, elvisangelaccio
Cc: ashaposhnikov, astippich, spoorun
michaelh added inline comments.
INLINE COMMENTS
> CMakeLists.txt:4
> +set(KF5_VERSION "5.45.0") # handled by release scripts
> +#TODO: Verify it is handled by release scripts
> +
There is not indication that `baloo-widgets` is an Application. Yet it resides
in the `kde/applications` folder. Sho
michaelh added a dependent revision: D11245: infopanel: Add choice of date
display formats.
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D12342
To: michaelh, #baloo, #dolphin, #frameworks
Cc: ashaposhnikov, astippich, spoorun
michaelh created this revision.
michaelh added reviewers: Baloo, Dolphin, Frameworks.
Restricted Application added a project: Baloo.
michaelh requested review of this revision.
REVISION SUMMARY
Update CMakeLists.txt taking `kwidgetsaddons` as a template
TEST PLAN
make clean && make
Dolphin
