sitter accepted this revision.
This revision is now accepted and ready to land.
Herald added a subscriber: kde-frameworks-devel.
REPOSITORY
R282 NetworkManagerQt
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D12493
To: jgrulich, #frameworks, sitter
Cc: kde-frameworks-devel, #f
This revision was automatically updated to reflect the committed changes.
Closed by commit R282:d5d45a61e324: Require NetworkManager 1.4.0 and newer
(authored by jgrulich).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D12493?vs=32965&id=40692#toc
REPOSITORY
R282 NetworkManagerQt
CHAN
bruns added a comment.
You have missed the checks added in https://phabricator.kde.org/D11353, e.g.
in src/dnsconfiguration.h
Also, the API documentation has a lot of `@note`s referencing NM < 1.2.0,
1.0.6, ...
REPOSITORY
R282 NetworkManagerQt
REVISION DETAIL
https://phabricator.kd
jgrulich created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
jgrulich requested review of this revision.
REVISION SUMMARY
NM 1.4.0 was released in 2016, even Debian stable has newer version in
repositories
so it sho
jgrulich added a reviewer: Frameworks.
REPOSITORY
R282 NetworkManagerQt
REVISION DETAIL
https://phabricator.kde.org/D12493
To: jgrulich, #frameworks
Cc: #frameworks, michaelh, bruns
