D12521: KFileWidget use hidpi icons

anemeth abandoned this revision. anemeth added a comment. In D12521#253806 , @elvisangelaccio wrote: > Every application that opens a file dialog is supposed to do this in their own startup code (usually in `main()`). Looks like this is

D12521: KFileWidget use hidpi icons

elvisangelaccio added a comment. In D12521#253764 , @anemeth wrote: > In D12521#253761 , @broulik wrote: > > > A widget setting an attribute on the application is bad > > > Where should I set i

D12521: KFileWidget use hidpi icons

anemeth added a comment. In D12521#253761 , @broulik wrote: > A widget setting an attribute on the application is bad Where should I set it? I can't find a mainwindow class in kio REPOSITORY R241 KIO BRANCH qt_scaling (branched fro

D12521: KFileWidget use hidpi icons

ngraham added a comment. Only for the purpose of showing this dialog though, right? REPOSITORY R241 KIO BRANCH qt_scaling (branched from master) REVISION DETAIL https://phabricator.kde.org/D12521 To: anemeth, #frameworks, #vdg, ngraham Cc: broulik, ngraham, #frameworks, michaelh, brun

D12521: KFileWidget use hidpi icons

broulik added a comment. -1 A widget setting an attribute on the application is bad REPOSITORY R241 KIO BRANCH qt_scaling (branched from master) REVISION DETAIL https://phabricator.kde.org/D12521 To: anemeth, #frameworks, #vdg, ngraham Cc: broulik, ngraham, #frameworks, michaelh,

D12521: KFileWidget use hidpi icons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Well that was easy, lol. REPOSITORY R241 KIO BRANCH qt_scaling (branched from master) REVISION DETAIL https://phabricator.kde.org/D12521 To: anemeth, #frameworks, #vdg, ngraham Cc

D12521: KFileWidget use hidpi icons

anemeth retitled this revision from "KFileWidget fix hidpi icons" to "KFileWidget use hidpi icons". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12521 To: anemeth, #frameworks, #vdg Cc: ngraham, #frameworks, michaelh, bruns